[issue12751] Use macros for surrogates in unicodeobject.c

[Marc-Andre Lemburg]

Marc-Andre Lemburg <mal at egenix.com> added the comment:

Ezio Melotti wrote:
> 
> Ezio Melotti <ezio.melotti at gmail.com> added the comment:
> 
> #10542 proposes the following macros to factor out common code:
>  #define _Py_UNICODE_ISSURROGATE
>  #define _Py_UNICODE_ISHIGHSURROGATE
>  #define _Py_UNICODE_ISLOWSURROGATE
>  #define _Py_UNICODE_JOIN_SURROGATES
> and to avoid checking for narrow/wide builds and recombine surrogates manually (so still refactoring):
>  #define _Py_UNICODE_NEXT
>  #define _Py_UNICODE_PUT_NEXT
> 
> Your patch proposes the same 4 macros:
>  #define IS_SURROGATE
>  #define IS_HIGH_SURROGATE
>  #define IS_LOW_SURROGATE
>  #define COMBINE_SURROGATES
> + 3 additional macros:
>  #define IS_NONBMP
>  #define HIGH_SURROGATE
>  #define LOW_SURROGATE
> 
> So the two issue looks quite similar to me.

Can we please fold this issue into #10542. We've already had the
discussion there.

Thanks,
-- 
Marc-Andre Lemburg
eGenix.com

________________________________________________________________________
2011-10-04: PyCon DE 2011, Leipzig, Germany                49 days to go

::: Try our new mxODBC.Connect Python Database Interface for free ! ::::

   eGenix.com Software, Skills and Services GmbH  Pastor-Loeh-Str.48
    D-40764 Langenfeld, Germany. CEO Dipl.-Math. Marc-Andre Lemburg
           Registered at Amtsgericht Duesseldorf: HRB 46611
               http://www.egenix.com/company/contact/

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue12751>
_______________________________________