[issue12721] Chaotic use of helper functions in test_shutil for reading and writing files

Petri Lehtinen report at bugs.python.org
Thu Aug 11 08:39:12 CEST 2011


Petri Lehtinen <petri at digip.org> added the comment:

I'd call os.path.join() in the test functions rather than in read_file() and write_file(). This makes it easier to understand what the test is doing without looking at the code of read_file() and write_file().

Otherwise, looks good to me, and I think this would be useful cleanup.

----------
keywords: +needs review
nosy: +eric.araujo, petri.lehtinen, tarek
stage:  -> patch review
versions:  -Python 2.6, Python 2.7, Python 3.1, Python 3.2

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue12721>
_______________________________________


More information about the Python-bugs-list mailing list