[issue10517] test_concurrent_futures crashes with "--with-pydebug" on RHEL5 with "Fatal Python error: Invalid thread state for this thread"

[Antoine Pitrou]

Antoine Pitrou <pitrou at free.fr> added the comment:

> > Thank you. I like this patch, except that _PyGILState_ReInit() should be
> > declared in the appropriate .h file, not in signalmodule.c.
> 
> I asked myself this question when writing the patch: what's the
> convention  regarding functions ? Should they always be declared in a
> header with PyAPI_FUNC, or should this be reserved to functions
> exported through the API?

IMO they should always be exposed in header files. It makes them easier
to discover and re-use than with some "extern" decls sprinkled in .c
files. As for PyAPI_FUNC, I think we always use it out of convention,
although it's probably not useful for private API functions.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue10517>
_______________________________________