[issue7443] test.support.unlink issue on Windows platform

[Jeff Dean]

Jeff Dean <chimalus at gmail.com> added the comment:

> * Patch Py_DeleteFileW in posixmodule.c so that it renames before
> deleting: should solve the problem overall but obviously has a
> possible wider impact, in general and on performance in particular.
> This rename might be a simple rename-to-guid or something more
> sophisticated such as the rename-to-recycler which cygwin uses.
> 
> * Patch support.unlink in the test package to do the rename dance on
> the basis that it'll fix at least some of the problems with less
> impact overall.
> 
> Opinions? I'm willing to do either.

I vote for fixing the test package.

File system "extensions" may track and record this activity.  To use DropBox as an example, doing the rename and delete will cause the renamed and deleted file to be recorded.

Just my opinion, but the code path to delete a file should be as short as possible.  Making lots of other OS calls just doesn't seem right.

I understand the wish to have a reliable unlink call but I'd be uncomfortable with a workaround that may be visible around the edges.

----------
nosy: +jdigital

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue7443>
_______________________________________