[issue9188] test_gdb fails for UCS2 builds with UCS2 gdb

[Dave Malcolm]

Dave Malcolm <dmalcolm at redhat.com> added the comment:

One minor quibble with the patch:

In the line:
   while i < field_length:
you're trusting that field_length has a sane value.  If field_str points somewhere readable, and field_length is huge (e.g. 0xfffffff), then gdb could sit there for a while reading all that data until it either completes, or hits memory that it can't read (leading to a python exception within gdb).

In other places in that code I used safe_range() to limit iterations to a safety threshold; I suggest the use of
  safety_limit(field_length)

But this is a minor nit.


I don't think this

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue9188>
_______________________________________