[issue8214] Add exception logging function to syslog module
Sean Reifschneider
report at bugs.python.org
Sun May 2 00:40:26 CEST 2010
Sean Reifschneider <jafo at tummy.com> added the comment:
Thanks for the review Jack.
I was very tempted to split it into C and Python components, but I decided
against it because it's so close to the 2.7 release. I think it would be
best to defer that for the Python 3 release, because of potential packaging
issues. I'm open to discussion on that though.
I've changed all the return(NULL)s in the package.
NULL check on saved_hook is done.
I also had the same thought about the saved_hook/syslog ordering, so I've
changed it.
I've added soe unit tests. I tried getting fancy and testing the exception
handling, but had to fork to do it and then unittests were still catching
the exception, so I just left it the minimal set of tests I put in there.
Thanks.
----------
Added file: http://bugs.python.org/file17174/logexception3.patch
_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue8214>
_______________________________________
More information about the Python-bugs-list
mailing list