[issue3928] os.mknod missing on Solaris

[Jesús Cea Avión]

Jesús Cea Avión <jcea at jcea.es> added the comment:

Roumen Petrov (rpetrov) wrote:
>>
>> Jesús Cea Avión<jcea at jcea.es>  added the comment:
>>
>> I just did the minimal change. I don't know if removing "defined(HAVE_MAKEDEV)" is safe.

> The python build system is full with minimal changes and result is a
> big mess. Did you found which revision add ".. defined(HAVE_MAKEDEV)"
> in posix*.c ?

The code was added in 2002-07-30 by nnorwitz, to support OSF1 (Dec Unix). Is that platform still supported?. I don't see any related  buildbot.

>> "HAVE_DEVICE_MACROS" is defined if "configure" finds "makedev()" macro.

> And what is result on you platform ?

It is defined if I add the new "include".


> Cases:
> 1) platform is no longer supported - it is save to remove test case from 
> configure and defined(HAVE_MAKEDEV) from posixmodule.c

Do we have a list of officially supported?.

> 2) HAVE_DEVICE_MACROS is defined for you . Then check how is written 
> test for HAVE_DEVICE_MACROS and make test for makedev similar.

Investigating the issue, I could say that HAVE_MAKEDEV should be deleted, but I don't have access to a OSF1 machine for trying.

How should I proceed?

----------
nosy:  -barry, rpetrov

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue3928>
_______________________________________