[issue6882] uuid creates zombies

Eric Smith report at bugs.python.org
Thu Sep 17 16:31:05 CEST 2009


Eric Smith <eric at trueblade.com> added the comment:

The py3k version of the file already contains 3.x only code, and it's
missing the comment at the top that it should be compatible. But it's
not really a big deal to me.

The py3k version also already has some try/finally logic on some popen
calls that the trunk version doesn't, so I suspect this was a known
problem that was addressed, and this case was missed or added later.

<research ensues>

Looking at svn blame, this was a change made by Guido in r59477. In the
checkin, he points to issue 1597 where this was originally discussed.

So I suggest that the original patch be applied. I have not checked if
there are other cases in util.py where this should be cleaned up.

I also think it would be reasonable to change the try/finally's to
with's, since those are the very places that the 2.x code differs from
the 3.x code. But as I said, I don't feel too strongly about that.

I don't know why this problem doesn't show up in 2.x. I agree it would
be nice to understand why, but I don't have time to research it. Since
the new code (with try/finally) looks "more correct", if there's a
desire to keep them in sync then the try/finally fixes should be
back-ported to 2.x.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue6882>
_______________________________________


More information about the Python-bugs-list mailing list