[issue6615] multiprocessing logging support test

Antoine Pitrou report at bugs.python.org
Tue Nov 24 23:46:53 CET 2009


Antoine Pitrou <pitrou at free.fr> added the comment:

Some quick comments on your patch (not an in-depth review):
- you should add some tests for the problem you're trying to solve
- using __del__ when you have a weakref is counter-productive; use the
weakref's optional callback instead
- if you remove arbitrary elements from it, _handlerList should probably
be a set rather a list (but it's more of an optimization concern)
- `for h in [wr() for wr in handlerList if wr() is not None]` isn't a
pretty notation; just put the `if` inside the `for` instead

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue6615>
_______________________________________


More information about the Python-bugs-list mailing list