[issue3001] RLock's are SLOW
Antoine Pitrou
report at bugs.python.org
Sat Nov 7 16:06:59 CET 2009
Antoine Pitrou <pitrou at free.fr> added the comment:
Thanks for the review. I will make the suggested modifications.
http://codereview.appspot.com/150055/diff/1/4
File Modules/_threadmodule.c (right):
http://codereview.appspot.com/150055/diff/1/4#newcode221
Modules/_threadmodule.c:221: return PyBool_FromLong((long) r);
On 2009/11/07 07:48:05, gregory.p.smith wrote:
> This explicit (long) cast is unnecessary.
Right.
http://codereview.appspot.com/150055/diff/1/4#newcode246
Modules/_threadmodule.c:246: PyThread_release_lock(self->rlock_lock);
On 2009/11/07 07:48:05, gregory.p.smith wrote:
> reset self->rlock_owner to 0 before releasing the lock.
We always check rlock_count before rlock_owner anyway but, yes, I could
reset rlock_owner out of safety.
http://codereview.appspot.com/150055
----------
_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue3001>
_______________________________________
More information about the Python-bugs-list
mailing list