[issue4910] Remove uses of nb_long slot, and rename to nb_reserved.

Mark Dickinson report at bugs.python.org
Thu Jan 15 17:48:16 CET 2009


Mark Dickinson <dickinsm at gmail.com> added the comment:

Thanks, Benjamin!  Checked in in r68553, backported to 3.0 in r68556.

Here's the second patch, which fixes almost all remaining uses of nb_long 
but stops short of actually removing/renaming the nb_long slot.

Notes:

(1) I haven't tested the change to PC/winreg.c

(2) The Modules/_struct.c change does introduce a change in behaviour:
for example, before the patch,

struct.pack('q', decimal.Decimal(1))

raises struct.error.  After the patch, the packing succeeds.  I *think*
the patched behaviour is probably the right behaviour, since it agrees 
with 2.x, but it's not 100% clear to me what the intentions of the struct 
module are with respect to integer packing of non-integer types.  This is 
probably a question for another issue.

Added file: http://bugs.python.org/file12754/issue4910_2.patch

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue4910>
_______________________________________


More information about the Python-bugs-list mailing list