[issue4893] Use separate thread support code under MS Windows CE

Martin v. Löwis report at bugs.python.org
Sun Jan 11 21:22:01 CET 2009


Martin v. Löwis <martin at v.loewis.de> added the comment:

> Actually, I made the distinction between the 'int e' and the 'unsigned 
> e' consciously. When using 'errno', using an 'int' is correct. When
> using GetLastError(), I would have used a win32 DWORD if there was a 
> format sequence that correctly and portably formats it, so I 
> chose 'unsigned' as one that IMHO most likely matches it. 

That's all fine, but why do you need a variable named "e" in the first
place? Can't you leave the code as it was before?

> That is also 
> the reason for the two different error messages, otherwise I don't 
> think it makes a big difference.

Introducing an unnecessary variable should be avoided; this is just
cruft that accumulates. Please remove both variables.

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue4893>
_______________________________________


More information about the Python-bugs-list mailing list