[issue5780] test_float fails for 'legacy' float repr style

Eric Smith report at bugs.python.org
Fri Apr 17 13:43:31 CEST 2009


Eric Smith <eric at trueblade.com> added the comment:

I agree that there should be 2 behaviors, not 3.

This patch looks okay to me, and tests pass both with and without
defining PY_NO_SHORT_FLOAT_REPR.

One nit: You don't need to use Py_CHARMASK when using the ISDIGIT macro
locally defined in pystrtod.c. On the other hand, that macro (ISDIGIT)
should completely go away. I think it's there because this file is
trying to be locale-unaware, but isdigit from ctype.h is defined as
being locale-unaware (at least on all platforms I have access to and a
search on the net; my copy of C89 is at home and I can't triple-check
just yet).

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue5780>
_______________________________________


More information about the Python-bugs-list mailing list