[issue3623] _json: fix raise_errmsg(), py_encode_basestring_ascii() and linecol()

Alexandre Vassalotti report at bugs.python.org
Tue Oct 7 05:46:48 CEST 2008


Alexandre Vassalotti <alexandre at peadrop.com> added the comment:

The patch looks good to me. 

You may want to fix the refleak in the PyList_Append() calls (I counted
4) too:

            if (PyList_Append(chunks, chunk)) {
                goto bail;
            }

should be:

            if (PyList_Append(chunks, chunk)) {
                Py_DECREF(chunk);
                goto bail;
            }

Also, line 384 and 548:

    Py_DECREF(chunks);
    chunks = NULL;

should changed to

    Py_CLEAR(chunks);

----------
nosy: +alexandre.vassalotti

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue3623>
_______________________________________


More information about the Python-bugs-list mailing list