[ python-Bugs-1551427 ] tiny bug in win32_urandom

[SourceForge.net]

Bugs item #1551427, was opened at 2006-09-03 12:03
Message generated for change (Comment added) made by gbrandl
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1551427&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Python Library
Group: Python 2.4
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Rocco Matano (rocco_m)
Assigned to: Nobody/Anonymous (nobody)
Summary: tiny bug in win32_urandom

Initial Comment:
In the file ...\Python-2.4.3\Modules\posixmodule.c the
function win32_urandom
tries to get the addresses of the functions
'CryptAcquireContextA' and
'CryptGenRandom' like this:

pCryptAcquireContext=(CRYPTACQUIRECONTEXTA)GetProcAddress(
    hAdvAPI32, "CryptAcquireContextA");
if (pCryptAcquireContext == NULL)
    return PyErr_Format(PyExc_NotImplementedError,
        "CryptAcquireContextA not found");

pCryptGenRandom = (CRYPTGENRANDOM)GetProcAddress(
    hAdvAPI32, "CryptGenRandom");
if (pCryptAcquireContext == NULL) /* <- test
pCryptGenRandom instead */
    return PyErr_Format(PyExc_NotImplementedError,
        "CryptGenRandom not found");
        
After the second call to GetProcAddress()
pCryptGenRandom should be tested
against NULL.


----------------------------------------------------------------------

>Comment By: Georg Brandl (gbrandl)
Date: 2006-09-06 06:04

Message:
Logged In: YES 
user_id=849994

Thanks! Fixed in rev. 51762, 51763 (2.4), 51764 (2.5).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1551427&group_id=5470