[ python-Bugs-1175848 ] poorly named variable in urllib2.py

[SourceForge.net]

Bugs item #1175848, was opened at 2005-04-03 15:26
Message generated for change (Settings changed) made by gbrandl
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1175848&group_id=5470

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Python Library
Group: Python 2.3
Status: Closed
Resolution: Fixed
Priority: 5
Submitted By: Roy Smith (roysmith)
>Assigned to: Georg Brandl (gbrandl)
Summary: poorly named variable in urllib2.py

Initial Comment:
This is kind of trivial, but in urllib2.OpenerDirector.__init__, the local 
variable "server_version" is poorly named.  The name makes it 
sound like it's the version of the HTTP (or whatever) server we're 
talking to.  How about client_version or library_version or 
module_version?


----------------------------------------------------------------------

Comment By: Georg Brandl (birkenfeld)
Date: 2005-06-26 22:01

Message:
Logged In: YES 
user_id=1188172

Fixed as of Lib/urllib2.py r1.82.

----------------------------------------------------------------------

Comment By: John J Lee (jjlee)
Date: 2005-05-19 19:10

Message:
Logged In: YES 
user_id=261020

My, you're picky. ;-)

Yes, that does seem a poor name, +1 on changing it to
client_version.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=105470&aid=1175848&group_id=5470