[Python-3000-checkins] r66326 - in python/branches/py3k/Lib: cgi.py test/test_cgi.py

facundo.batista python-3000-checkins at python.org
Tue Sep 9 04:43:20 CEST 2008


Author: facundo.batista
Date: Tue Sep  9 04:43:19 2008
New Revision: 66326

Log:

Added a warning filter to don't show the warning during
the tests. Also fixed the warning message in cgi.py


Modified:
   python/branches/py3k/Lib/cgi.py
   python/branches/py3k/Lib/test/test_cgi.py

Modified: python/branches/py3k/Lib/cgi.py
==============================================================================
--- python/branches/py3k/Lib/cgi.py	(original)
+++ python/branches/py3k/Lib/cgi.py	Tue Sep  9 04:43:19 2008
@@ -168,7 +168,7 @@
 
 def parse_qsl(qs, keep_blank_values=0, strict_parsing=0):
     """Parse a query given as a string argument."""
-    warn("cgi.parse_qsl is deprecated, use urllib.parse.parse_qs instead",
+    warn("cgi.parse_qsl is deprecated, use urllib.parse.parse_qsl instead",
             DeprecationWarning)
     return urllib.parse.parse_qsl(qs, keep_blank_values, strict_parsing)
 

Modified: python/branches/py3k/Lib/test/test_cgi.py
==============================================================================
--- python/branches/py3k/Lib/test/test_cgi.py	(original)
+++ python/branches/py3k/Lib/test/test_cgi.py	Tue Sep  9 04:43:19 2008
@@ -5,6 +5,7 @@
 import tempfile
 import unittest
 from io import StringIO
+from warnings import catch_warnings, filterwarnings
 
 class HackedSysModule:
     # The regression test will have real values in sys.argv, which
@@ -308,13 +309,21 @@
 
     def test_deprecated_parse_qs(self):
         # this func is moved to urlparse, this is just a sanity check
-        self.assertEqual({'a': ['A1'], 'B': ['B3'], 'b': ['B2']},
-                         cgi.parse_qs('a=A1&b=B2&B=B3'))
+        with catch_warnings():
+            filterwarnings('ignore',
+                'cgi.parse_qs is deprecated, use urllib.parse.parse_qs instead',
+                DeprecationWarning)
+            self.assertEqual({'a': ['A1'], 'B': ['B3'], 'b': ['B2']},
+                             cgi.parse_qs('a=A1&b=B2&B=B3'))
 
     def test_deprecated_parse_qsl(self):
         # this func is moved to urlparse, this is just a sanity check
-        self.assertEqual([('a', 'A1'), ('b', 'B2'), ('B', 'B3')],
-                         cgi.parse_qsl('a=A1&b=B2&B=B3'))
+        with catch_warnings():
+            filterwarnings('ignore',
+                'cgi.parse_qsl is deprecated, use urllib.parse.parse_qsl instead',
+                DeprecationWarning)
+            self.assertEqual([('a', 'A1'), ('b', 'B2'), ('B', 'B3')],
+                             cgi.parse_qsl('a=A1&b=B2&B=B3'))
 
 def test_main():
     run_unittest(CgiTests)


More information about the Python-3000-checkins mailing list