[Python-3000-checkins] r55220 - python/branches/py3k-struni/Lib/test/test_codecs.py

[Guido van Rossum]

On 5/11/07, Walter Dörwald <walter at livinglogic.de> wrote:
> >> BTW, the message from the pre-commit hook is somewhat unhelpful:
> >>
> >> svn: 'pre-commit' hook failed with error output:
> >> file /python/branches/py3k-struni/Lib/encodings/idna.py is not
> >> whitespace-normalized
> >>
> >> If possible the message should include info about the nature of the
> >> problem (tabs, trailing whitespace) and it's location.
> >
> > This is not so easy since reindent.py doesn't have a way to show that,
> > you could generate a diff, but it wouldn't be so helpful either because
> > it can't show whitespaces so well :)
>
> At least it could report the line where the problem occurs.
>
> > But why do you need to know the exact location if you can just let
> > reindent.py run over the file?
>
> I didn't realize that. I fixed the file by hand! This would have indeed
> been simpler.

Maybe the error message can suggest this approach?

-- 
--Guido van Rossum (home page: http://www.python.org/~guido/)