[Python-3000-checkins] r56910 - python/branches/py3k/Lib/test/test_telnetlib.py

[guido.van.rossum]

Author: guido.van.rossum
Date: Fri Aug 10 23:28:41 2007
New Revision: 56910

Modified:
   python/branches/py3k/Lib/test/test_telnetlib.py
Log:
Use an event variable to wait for the server to be ready, rather than sleep(0.1).


Modified: python/branches/py3k/Lib/test/test_telnetlib.py
==============================================================================
--- python/branches/py3k/Lib/test/test_telnetlib.py	(original)
+++ python/branches/py3k/Lib/test/test_telnetlib.py	Fri Aug 10 23:28:41 2007
@@ -7,12 +7,13 @@
 from test import test_support
 
 
-def server(evt):
+def server(evt, ready):
     serv = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
     serv.settimeout(3)
     serv.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
     serv.bind(("", 9091))
     serv.listen(5)
+    ready.set()
     try:
         conn, addr = serv.accept()
     except socket.timeout:
@@ -25,8 +26,9 @@
 
     def setUp(self):
         self.evt = threading.Event()
-        threading.Thread(target=server, args=(self.evt,)).start()
-        time.sleep(.1)
+        ready = threading.Event()
+        threading.Thread(target=server, args=(self.evt, ready)).start()
+        ready.wait()
 
     def tearDown(self):
         self.evt.wait()