From nicoddemus at gmail.com Wed May 1 16:25:58 2019 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Wed, 1 May 2019 17:25:58 -0300 Subject: [pytest-dev] [core] Tidelift Funding Message-ID: Hi core maintainers, Half a year ago Keenan Szulik from Tidelift reached me and Holger about the possibility of pytest joining Tidelift for funding. At first our answer was "not right now" for two reasons: we didn't actually knew the platform (for example what expect in terms of obligations) and how to split the funding among maintainers. Some time later Keenan reached us again to see if we had thought about the idea some more. I reached some other OS maintainers which have joined Tidelift and the overall response was positive: they were getting paid and there were no obligations whatsoever after joining the platform other than "maintain the project", which they were already doing anyway. There's no obligation to market the platform in anyway as well (say, being forced to put their logo on the website). Here's a nice discussion of the Pillow maintainers about how to split the funding: https://github.com/python-pillow/Pillow/issues/3469. I decided then to join Tidelift with pytest-mock: it is a small project and I'm the sole maintainer, so it seemed like a good choice to beta test the platform. After two months, the overall experience is positive: I didn't get any demands from Tidelift other than the occasional email (twice a month) about how the project is doing in terms of Tidelift subscribers, and I've been paid twice know without fuss. So I think the overall experience is positive. So my question is: how do the core maintainers feel about pytest joining Tidelift? Here's their license agreement: https://tidelift.com/docs/lifting/agreement If we are to join, there's the question about how to split the funds over the core maintainers. I propose we follow how other projects are handling it: * The amount is split evenly between active maintainers. By "active maintainer" here I mean that has been participating in discussions and/or contributing PRs "lately". I think every core maintainer is reasonable regarding being active or not, so I don't expect misunderstandings here. * If an inactive maintainer becomes active again, they will start to get their share on the next payment (by the end of every month as per Tidelift policy). Same if an active maintainer stops activity. With the above guidelines, I would say the current "active" core maintainers are Daniel, Anthony and myself, with Ronny joining back soon. The amount involved is not much, but it is an extra which is nice to have for (what I can see) work we are already doing anyway. It is also possible to cancel the subscription for any time given 30 days notice. Thoughts? Cheers, Bruno. -------------- next part -------------- An HTML attachment was scrubbed... URL: From craig.ds at gmail.com Wed May 1 22:18:42 2019 From: craig.ds at gmail.com (Craig de Stigter) Date: Thu, 2 May 2019 14:18:42 +1200 Subject: [pytest-dev] Adding a marker to items that have a fixture Message-ID: Hi there Not sure if I'm missing something in the docs. I'm trying to add a marker to every test that's decorated with a given fixture. What I have currently is this: def pytest_itemcollected(item): if 'solr' in item.fixturenames: # so you can skip it with "-m 'not solr'" item.add_marker('solr') This sort of works ( the marker is present by the time the test runs), but command-line filtering options (`-m 'not solr'`) don't filter based on it. I guess this hook is running after those options have been consulted? I also tried the same thing in pytest_collection_modifyitems, but that happens later so is even less likely to work. Is there an earlier hook where I can modify an item before the command line filtering options are checked? Thanks Craig -------------- next part -------------- An HTML attachment was scrubbed... URL: From me at the-compiler.org Thu May 2 03:30:18 2019 From: me at the-compiler.org (Florian Bruhin) Date: Thu, 2 May 2019 09:30:18 +0200 Subject: [pytest-dev] Adding a marker to items that have a fixture In-Reply-To: References: Message-ID: <20190502073018.rpov2wlp3r2yrbp2@hooch.localdomain> On Thu, May 02, 2019 at 02:18:42PM +1200, Craig de Stigter wrote: > This sort of works ( the marker is present by the time the test runs), but > command-line filtering options (`-m 'not solr'`) don't filter based on it. > I guess this hook is running after those options have been consulted? > > I also tried the same thing in pytest_collection_modifyitems, but that > happens later so is even less likely to work. Works fine for me in pytest_collection_modifyitems. There's also a plugin which does the same: https://github.com/rciorba/pytest-fixture-marker Florian -- https://www.qutebrowser.org | me at the-compiler.org (Mail/XMPP) GPG: 916E B0C8 FD55 A072 | https://the-compiler.org/pubkey.asc I love long mails! | https://email.is-not-s.ms/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: From me at the-compiler.org Thu May 2 03:44:02 2019 From: me at the-compiler.org (Florian Bruhin) Date: Thu, 2 May 2019 09:44:02 +0200 Subject: [pytest-dev] [core] Tidelift Funding In-Reply-To: References: Message-ID: <20190502074402.zetxdfwb3hozevgw@hooch.localdomain> Hey, On Wed, May 01, 2019 at 05:25:58PM -0300, Bruno Oliveira wrote: > there were no obligations whatsoever after joining the platform other than > "maintain the project", which they were already doing anyway. There's no > obligation to market the platform in anyway as well (say, being forced to > put their logo on the website). Their website says otherwise: https://tidelift.com/docs/lifting/marketing "At Tidelift, we're working with maintainers to jointly create a product. As with any product offering, we need to tell people the product exists." "When you sign up to lift a package and get paid, we're asking for you to keep a mention of the Tidelift Subscription at minimum on your project's main "home page"?whether that's a dedicated website or simply a README on GitHub. We're flexible about the exact wording and format, and happy to consult with you on it." "But the main reason is that we do need to tell potential subscribers about the product, so they can support you by buying it!" Not sure if I want to think of pytest as a product which should be bought by subscribers ;) There's also some other "tasks" - not that I'd disagree with them being a good thing, but it's way more than "no obligations whatsoever" (like looking at their dependency scanner, and disclosing security vulnerabilities to them in their dashboard): https://tidelift.com/docs/lifting/tasks-overview Florian -- https://www.qutebrowser.org | me at the-compiler.org (Mail/XMPP) GPG: 916E B0C8 FD55 A072 | https://the-compiler.org/pubkey.asc I love long mails! | https://email.is-not-s.ms/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: From nicoddemus at gmail.com Thu May 2 05:05:23 2019 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Thu, 2 May 2019 06:05:23 -0300 Subject: [pytest-dev] [core] Tidelift Funding In-Reply-To: <20190502074402.zetxdfwb3hozevgw@hooch.localdomain> References: <20190502074402.zetxdfwb3hozevgw@hooch.localdomain> Message-ID: Em qui, 2 de mai de 2019 04:44, Florian Bruhin escreveu: > Hey, > > On Wed, May 01, 2019 at 05:25:58PM -0300, Bruno Oliveira wrote: > > there were no obligations whatsoever after joining the platform other > than > > "maintain the project", which they were already doing anyway. There's no > > obligation to market the platform in anyway as well (say, being forced to > > put their logo on the website). > > Their website says otherwise: > > https://tidelift.com/docs/lifting/marketing > > "At Tidelift, we're working with maintainers to jointly create a product. > As > with any product offering, we need to tell people the product exists." > > "When you sign up to lift a package and get paid, we're asking for you to > keep > a mention of the Tidelift Subscription at minimum on your project's main > "home > page"?whether that's a dedicated website or simply a README on GitHub. > We're > flexible about the exact wording and format, and happy to consult with you > on > it." > > "But the main reason is that we do need to tell potential subscribers > about the > product, so they can support you by buying it!" > Hmm you are right, but I think it is more of a suggestion rather than an obligation. > > Not sure if I want to think of pytest as a product which should be bought > by > subscribers ;) > Me neither, but I don't think that is the case... Companies subscribe to tidelift, and pytest happens to be one of the projects on the platform. We the maintainers own the project and may unsubscribe from the platform at any time. > > There's also some other "tasks" - not that I'd disagree with them being a > good > thing, but it's way more than "no obligations whatsoever" (like looking at > their dependency scanner, and disclosing security vulnerabilities to them > in > their dashboard): https://tidelift.com/docs/lifting/tasks-overview You are right. Fortunately those were very quick to do in my experience with pytest-mock. I believe the same amount of work would be required by pytest, even if it is a much larger project. Other than that, any other opinions Florian? :) Cheers, Bruno > > > Florian > > -- > https://www.qutebrowser.org | me at the-compiler.org (Mail/XMPP) > GPG: 916E B0C8 FD55 A072 | https://the-compiler.org/pubkey.asc > I love long mails! | https://email.is-not-s.ms/ > -------------- next part -------------- An HTML attachment was scrubbed... URL: From florian.schulze at gmx.net Thu May 2 05:22:08 2019 From: florian.schulze at gmx.net (Florian Schulze) Date: Thu, 02 May 2019 11:22:08 +0200 Subject: [pytest-dev] Keeping failing test ids for git bisect Message-ID: Hi! Is there a way to run a bunch of tests like with --lf but don't clear the cache when they pass? This would be mighty helpful for git bisect. For now I helped myself by copying the test ids, but that requires editing the list copied from the terminal before being able to paste them to the command line. Regards, Florian Schulze From me at the-compiler.org Thu May 2 05:28:16 2019 From: me at the-compiler.org (Florian Bruhin) Date: Thu, 2 May 2019 11:28:16 +0200 Subject: [pytest-dev] Keeping failing test ids for git bisect In-Reply-To: References: Message-ID: <20190502092816.2udu4fkqveuccllj@hooch.localdomain> Hey, On Thu, May 02, 2019 at 11:22:08AM +0200, Florian Schulze wrote: > Is there a way to run a bunch of tests like with --lf but don't clear > the cache when they pass? This would be mighty helpful for git bisect. > For now I helped myself by copying the test ids, but that requires > editing the list copied from the terminal before being able to paste > them to the command line. I've needed something similar before (like when I want to run a set of failing tests, but maybe run some other set in between). What would be nice is something like a --save-collected and --load-collected . Then you could do "--lf --save-collected bisect" once, and do "--load-collected bisect" to rerun exactly those tests. I wanted to write a plugin for that for months (if not years) now, but never got around to it. So far I've also done what you described. Florian (the other one :P) -- https://www.qutebrowser.org | me at the-compiler.org (Mail/XMPP) GPG: 916E B0C8 FD55 A072 | https://the-compiler.org/pubkey.asc I love long mails! | https://email.is-not-s.ms/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: From florian.schulze at gmx.net Thu May 2 06:18:11 2019 From: florian.schulze at gmx.net (Florian Schulze) Date: Thu, 02 May 2019 12:18:11 +0200 Subject: [pytest-dev] Keeping failing test ids for git bisect In-Reply-To: <20190502092816.2udu4fkqveuccllj@hooch.localdomain> References: <20190502092816.2udu4fkqveuccllj@hooch.localdomain> Message-ID: <75E51413-978D-48D7-93B6-744E8E6A6EFC@gmx.net> On 2 May 2019, at 11:28, Florian Bruhin wrote: > Hey, > > On Thu, May 02, 2019 at 11:22:08AM +0200, Florian Schulze wrote: >> Is there a way to run a bunch of tests like with --lf but don't clear >> the cache when they pass? This would be mighty helpful for git >> bisect. >> For now I helped myself by copying the test ids, but that requires >> editing the list copied from the terminal before being able to paste >> them to the command line. > > I've needed something similar before (like when I want to run a set of > failing > tests, but maybe run some other set in between). > > What would be nice is something like a --save-collected and > --load-collected . Then you could do "--lf --save-collected > bisect" once, > and do "--load-collected bisect" to rerun exactly those tests. > > I wanted to write a plugin for that for months (if not years) now, but > never > got around to it. So far I've also done what you described. Any hints on which hooks would be most useful for gathering the failing tests (or maybe a hint for existing code to look at)? Then I might write that plugin :) Regards, Florian Schulze From nicoddemus at gmail.com Thu May 2 07:20:23 2019 From: nicoddemus at gmail.com (nicoddemus at gmail.com) Date: Thu, 2 May 2019 13:20:23 +0200 Subject: [pytest-dev] [core] Tidelift Funding In-Reply-To: References: Message-ID: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 > Only thought from my side ? please, just make sure there's "way back", in case reality will not match your expectations. Indeed that's a very important aspect, here's the section of the agreement[1] regarding that: - --- 6.2 How and when can this agreement be terminated? Either party may terminate this agreement (i) with 30 or more days notice, for any or no reason; or (ii) immediately, if the other party materially defaults in the performance of any of its obligations hereunder, and such default is not corrected within 10 business days of notice of the default. Material defaults may include non-completion of tasks set out in the Tidelift application, violations of the Lifter Code of Conduct, attempts to manipulate or game systems (including either those created by Tidelift or by host open source projects), or any other conduct that could damage the reputation or business of Tidelift or other Lifters. - --- I don't have much legalese experience, but this seems to be reasonable. [1]: https://tidelift.com/docs/lifting/agreement -----BEGIN PGP SIGNATURE----- Version: FlowCrypt 6.7.7 Gmail Encryption Comment: Seamlessly send and receive encrypted email wsFcBAEBCgAGBQJcytJzAAoJEAcNJkopMu2+GLAP/Rt4SKR9kStlM6v8LWGx BJssTmCT7k/0xqCfHBCjooe6btV+RyXG/1ZZPkKTaK2dEA2XyXRi7bG22utu lqXXtTZg0JHc7b+FXwH0ZySNklkQWwIph8I2nWoa209XJ77LVEqtRvmgW74I 5KeS2Yhr0Jo8CRyKJgdcX4eR5v7g1duyQUB1IYnu0lZXSzJTAWUH043ubjI/ G2XqyHC8S9GJqBvQrFv2ObzT5Y4GPiMDlTOhkbbnpFUQpZi8Zy+UfiHTGoi3 wBXWyuKbi2ABs8prEh9269AGMqoW+eXshto0E/arqC2zSb/btTef1fBjUunM Fu0cqOtsiaz/Q0OwwxLuiep1c5ikaJ4qfnmaizncoQhS/DdVsiqIZ7p6SiMA bSNH4jxPO4LwvE6YvYOjsLJrk/yjnfoC44wydF2Y2Qv6B6GHoyPhRdLOWYnj PtGk6VQEl88d9wXPfZWxjzW1lvCaGwWjrfjRYS7Yhlkdo52B73Gee1bhu6/H a/8sRAwpS386l6lwVpQW6FPrhbpm/XYDR5GqGW/rzATxky4GCzgjsVddKmqh xJHONQJbQxaaT43OurfY1ly8+XFUxarQ4u9kk9htW241dMzZeiiGOuprrBbE 1NsrQPzXie8tfp/X8++LlYOlvSG2u+8xUa7ochrvpvVNnBBa46QYARHX+Vnp 4ZUi =xHKg -----END PGP SIGNATURE----- From nicoddemus at gmail.com Thu May 2 07:24:16 2019 From: nicoddemus at gmail.com (nicoddemus at gmail.com) Date: Thu, 2 May 2019 13:24:16 +0200 Subject: [pytest-dev] Keeping failing test ids for git bisect In-Reply-To: <75E51413-978D-48D7-93B6-744E8E6A6EFC@gmx.net> References: <20190502092816.2udu4fkqveuccllj@hooch.localdomain> <75E51413-978D-48D7-93B6-744E8E6A6EFC@gmx.net> Message-ID: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hi Florians, > Any hints on which hooks would be most useful for gathering the failing tests (or maybe a hint for existing code to look at)? Then I might write that plugin :) I suggest to take a look at the implementation of the LFPlugin, which uses this hook to identify if a test passed/failed: https://github.com/pytest-dev/pytest/blob/f17b734989f07de2317bb60191bf51a47593b760/src/_pytest/cacheprovider.py#L173-L177 This might give you some ideas on how to write such a plugin. Cheers, -----BEGIN PGP SIGNATURE----- Version: FlowCrypt 6.7.7 Gmail Encryption Comment: Seamlessly send and receive encrypted email wsFcBAEBCgAGBQJcytNdAAoJEAcNJkopMu2+rxYP/R1ZOcJ16hC5Hz6YkawI Kv533DJCLWU3VLEDHrzjDp0G+Qx2UbXGiHeypCOH0ph8AE3a2AP4naUEgk7A J2IrIx3lVGuApcq+apf4GXYLPihB7qaNyjnOJT35wwbqoI37R7tWZrT76TRn 5/Y9N4tB+fM9XwpDZUay4VZA+YiNHzHgG/xZxuXUvNyXPDQm27e4q+TcL6gw l9/tm2Hcbfz78FMMMPwhZnph7yLHrcCfW4B874xz2qaQp5SyFbE8rJfrb6f8 r9LKDT/QaBQZqHEIoYIHpdMHzqB/e/gaz3KZLeyRAYbJQsJQClo2sQc6VE2c X5wh88LYTnPtQdRYLXmlElzrbJe77vQ4FrHJmdZGFm6UptPE3uP90LVY+a/6 x3XMciuu+zRFulCzZFKulI6IoS1ER39wSqe7iUe/13irJ1ZfhPcwzJA+fqxi 0SsABPwPQcdDQGf3NZUBv0efZJz/o+pCoSgg4Al7fa+uoykeY05I8LQUfcnW xSIA/XCnT6xAYKxQfw6LwLJuU+hcgHUeLqR16DcPgqGf8K707fhUrGQah4uU xFlRLFYvcQ1cXb7rQdE4RBPgynUdTr45AR0EoACG8LeiaVzNk9sV6r5xZU3m Ygf6e3hKrxv88+D6tn69+s75U7ETcjzwxW1xrizZuaPuC4QxdMrwzVc+ULDp hX/c =nD0t -----END PGP SIGNATURE----- -------------- next part -------------- A non-text attachment was scrubbed... Name: 0x8271958554DEDD51.asc Type: application/pgp-keys Size: 6208 bytes Desc: not available URL: From flub at devork.be Thu May 2 13:22:50 2019 From: flub at devork.be (Floris Bruynooghe) Date: Thu, 02 May 2019 19:22:50 +0200 Subject: [pytest-dev] [core] Tidelift Funding In-Reply-To: References: Message-ID: <87d0l0ixed.fsf@powell.devork.be> Hi Bruno, On Wed 01 May 2019 at 17:25 -0300, Bruno Oliveira wrote: > So my question is: how do the core maintainers feel about pytest joining > Tidelift? Thanks for the wait-and-see approach taken, I likewise have shifted my opinion on this from some scepticism to mostly positive. So if there's a few people interested in pytest joining tidelift I'd be happy to support this. > If we are to join, there's the question about how to split the funds over > the core maintainers. I propose we follow how other projects are handling > it: > > * The amount is split evenly between active maintainers. By "active > maintainer" here I mean that has been participating in discussions and/or > contributing PRs "lately". I think every core maintainer is reasonable > regarding being active or not, so I don't expect misunderstandings here. > > * If an inactive maintainer becomes active again, they will start to get > their share on the next payment (by the end of every month as per Tidelift > policy). Same if an active maintainer stops activity. > > With the above guidelines, I would say the current "active" core > maintainers are Daniel, Anthony and myself, with Ronny joining back soon. Why the rules about active? Seems complicated and more open to arguing. I liked the Pillow guidelines you linked: https://github.com/orgs/pytest-dev/teams/contributors can express interest and https://github.com/orgs/pytest-dev/teams/core decides on split (which I guess can be anything from 0% to 100%). With the same assumption that the core members are reasonable that should end up as roughly the same. Mind you in practice I have no issue with the above proposal of people right now, but would also not mind if e.g. hpk or ronny wanted to be part right now (I'll pass myself). Likewise there are probably cases where I wouldn't mind people not in core being paid for some time. But in general I'm +1, let's make it happen if there's anyone interested in getting paid. Cheers, Floris From flub at devork.be Thu May 2 13:41:48 2019 From: flub at devork.be (Floris Bruynooghe) Date: Thu, 02 May 2019 19:41:48 +0200 Subject: [pytest-dev] pytest slack reporting plugin proposal In-Reply-To: References: Message-ID: <87a7g4iwir.fsf@powell.devork.be> Hi Arseniy, Ronny, If you want to maintain your plugin under pytest-dev I think that should be fine as long as [0] is followed. While indeed this doesn't mean you'll magically have other maintainers it doesn't seem like that's what you're after. So as long as the requirements are met this is probably I'd think. Cheers, Floris [0] https://github.com/pytest-dev/pytest/blob/master/CONTRIBUTING.rst#submitting-plugins-to-pytest-dev On Fri 26 Apr 2019 at 11:05 +0300, Arseniy Antonov wrote: > I would say that I'm going to support it, but I think that this is not > enough to get accepted. > Actually, I think if this plugin will be accepted, it may put the light on > the report tools from the bit different side. > And I suppose that there will be such requests like, add the same for the > "Telegram/Discord", and if this will happen, I would like to support it, > and maybe rename pytest-slack to pytest-report-messengers. > > > ??, 25 ???. 2019 ?. ? 17:05, Ronny Pfannschmidt : > >> Hi Arseniy, >> >> thanks for your proposal, >> this is definitively useful for pytest users, which use slack. >> However pytest itself does not. >> >> If pytest-dev takes this on, there is a need of slack aware/using >> maintainers that move this along (else its just going to painfully and >> slowly degrade) >> I encourage Interested/Invested parties to reach out so we can understand >> the bus-effects we need to consider. >> I believe this is a nice and useful addition, but we need to ensure that >> long term maintenance under the pytest-dev umbrella is a reality. >> >> -- Ronny >> >> Am Mi., 24. Apr. 2019 um 12:00 Uhr schrieb Arseniy Antonov < >> arseny.antonov at gmail.com>: >> >>> Hello, >>> I've developed a plugin for sending pytest results to the slack. >>> I suppose it may be a useful tool for the pytest community, so I want to >>> contribute it to the pytest-dev. >>> Please review: >>> >>> https://github.com/ArseniyAntonov/pytest-slack >>> >>> -- >>> -------------------------- >>> Regards. >>> Arseny Antonov >>> _______________________________________________ >>> pytest-dev mailing list >>> pytest-dev at python.org >>> https://mail.python.org/mailman/listinfo/pytest-dev >>> >> >> >> -- >> >> Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn, >> Commercial register: Amtsgericht Muenchen, HRB 153243, >> Managing Directors: Charles Cachera, Michael Cunningham, Michael O'Neill, Eric Shander >> >> From arseny.antonov at gmail.com Thu May 2 14:26:47 2019 From: arseny.antonov at gmail.com (Arseniy Antonov) Date: Thu, 2 May 2019 21:26:47 +0300 Subject: [pytest-dev] pytest slack reporting plugin proposal In-Reply-To: <87a7g4iwir.fsf@powell.devork.be> References: <87a7g4iwir.fsf@powell.devork.be> Message-ID: Hi > If you want to maintain your plugin under pytest-dev I think that should > be fine as long as [0] is followed. That's exactly what I want. Please tell me what I should do next by the process. ??, 2 ??? 2019 ?. ? 20:44, Floris Bruynooghe : > Hi Arseniy, Ronny, > > If you want to maintain your plugin under pytest-dev I think that should > be fine as long as [0] is followed. While indeed this doesn't mean > you'll magically have other maintainers it doesn't seem like that's what > you're after. So as long as the requirements are met this is probably > I'd think. > > Cheers, > Floris > > [0] > https://github.com/pytest-dev/pytest/blob/master/CONTRIBUTING.rst#submitting-plugins-to-pytest-dev > > On Fri 26 Apr 2019 at 11:05 +0300, Arseniy Antonov wrote: > > > I would say that I'm going to support it, but I think that this is not > > enough to get accepted. > > Actually, I think if this plugin will be accepted, it may put the light > on > > the report tools from the bit different side. > > And I suppose that there will be such requests like, add the same for the > > "Telegram/Discord", and if this will happen, I would like to support it, > > and maybe rename pytest-slack to pytest-report-messengers. > > > > > > ??, 25 ???. 2019 ?. ? 17:05, Ronny Pfannschmidt : > > > >> Hi Arseniy, > >> > >> thanks for your proposal, > >> this is definitively useful for pytest users, which use slack. > >> However pytest itself does not. > >> > >> If pytest-dev takes this on, there is a need of slack aware/using > >> maintainers that move this along (else its just going to painfully and > >> slowly degrade) > >> I encourage Interested/Invested parties to reach out so we can > understand > >> the bus-effects we need to consider. > >> I believe this is a nice and useful addition, but we need to ensure that > >> long term maintenance under the pytest-dev umbrella is a reality. > >> > >> -- Ronny > >> > >> Am Mi., 24. Apr. 2019 um 12:00 Uhr schrieb Arseniy Antonov < > >> arseny.antonov at gmail.com>: > >> > >>> Hello, > >>> I've developed a plugin for sending pytest results to the slack. > >>> I suppose it may be a useful tool for the pytest community, so I want > to > >>> contribute it to the pytest-dev. > >>> Please review: > >>> > >>> https://github.com/ArseniyAntonov/pytest-slack > >>> > >>> -- > >>> -------------------------- > >>> Regards. > >>> Arseny Antonov > >>> _______________________________________________ > >>> pytest-dev mailing list > >>> pytest-dev at python.org > >>> https://mail.python.org/mailman/listinfo/pytest-dev > >>> > >> > >> > >> -- > >> > >> Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn, > >> Commercial register: Amtsgericht Muenchen, HRB 153243, > >> Managing Directors: Charles Cachera, Michael Cunningham, Michael > O'Neill, Eric Shander > >> > >> > -- -------------------------- Regards. Arseny Antonov -------------- next part -------------- An HTML attachment was scrubbed... URL: From nicoddemus at gmail.com Thu May 2 14:38:13 2019 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Thu, 2 May 2019 15:38:13 -0300 Subject: [pytest-dev] pytest slack reporting plugin proposal In-Reply-To: References: <87a7g4iwir.fsf@powell.devork.be> Message-ID: Hi everyone On Thu, May 2, 2019 at 3:27 PM Arseniy Antonov wrote: > > Please tell me what I should do next by the process. > Thanks Arseniy for the interest. The steps are written here: https://github.com/pytest-dev/pytest/blob/master/CONTRIBUTING.rst#submitting-plugins-to-pytest-dev Mainly, you should transfer ownership of the repository to a pytest-dev admin (it can be me). From there, we will move the repository under the pytest-dev organization and then add you back as maintainer/owner, then you are free to add more collaborators if needed. Also it would be nice to add a few pytest-dev people as maintainers in PyPI with release rights. Feel free to follow with any questions, or start the repository transfer if you are OK with the process. Cheers, Bruno > > ??, 2 ??? 2019 ?. ? 20:44, Floris Bruynooghe : > >> Hi Arseniy, Ronny, >> >> If you want to maintain your plugin under pytest-dev I think that should >> be fine as long as [0] is followed. While indeed this doesn't mean >> you'll magically have other maintainers it doesn't seem like that's what >> you're after. So as long as the requirements are met this is probably >> I'd think. >> >> Cheers, >> Floris >> >> [0] >> https://github.com/pytest-dev/pytest/blob/master/CONTRIBUTING.rst#submitting-plugins-to-pytest-dev >> >> On Fri 26 Apr 2019 at 11:05 +0300, Arseniy Antonov wrote: >> >> > I would say that I'm going to support it, but I think that this is not >> > enough to get accepted. >> > Actually, I think if this plugin will be accepted, it may put the light >> on >> > the report tools from the bit different side. >> > And I suppose that there will be such requests like, add the same for >> the >> > "Telegram/Discord", and if this will happen, I would like to support it, >> > and maybe rename pytest-slack to pytest-report-messengers. >> > >> > >> > ??, 25 ???. 2019 ?. ? 17:05, Ronny Pfannschmidt : >> > >> >> Hi Arseniy, >> >> >> >> thanks for your proposal, >> >> this is definitively useful for pytest users, which use slack. >> >> However pytest itself does not. >> >> >> >> If pytest-dev takes this on, there is a need of slack aware/using >> >> maintainers that move this along (else its just going to painfully and >> >> slowly degrade) >> >> I encourage Interested/Invested parties to reach out so we can >> understand >> >> the bus-effects we need to consider. >> >> I believe this is a nice and useful addition, but we need to ensure >> that >> >> long term maintenance under the pytest-dev umbrella is a reality. >> >> >> >> -- Ronny >> >> >> >> Am Mi., 24. Apr. 2019 um 12:00 Uhr schrieb Arseniy Antonov < >> >> arseny.antonov at gmail.com>: >> >> >> >>> Hello, >> >>> I've developed a plugin for sending pytest results to the slack. >> >>> I suppose it may be a useful tool for the pytest community, so I want >> to >> >>> contribute it to the pytest-dev. >> >>> Please review: >> >>> >> >>> https://github.com/ArseniyAntonov/pytest-slack >> >>> >> >>> -- >> >>> -------------------------- >> >>> Regards. >> >>> Arseny Antonov >> >>> _______________________________________________ >> >>> pytest-dev mailing list >> >>> pytest-dev at python.org >> >>> https://mail.python.org/mailman/listinfo/pytest-dev >> >>> >> >> >> >> >> >> -- >> >> >> >> Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn, >> >> Commercial register: Amtsgericht Muenchen, HRB 153243, >> >> Managing Directors: Charles Cachera, Michael Cunningham, Michael >> O'Neill, Eric Shander >> >> >> >> >> > > > -- > -------------------------- > Regards. > Arseny Antonov > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev > -------------- next part -------------- An HTML attachment was scrubbed... URL: From arseny.antonov at gmail.com Thu May 2 14:45:40 2019 From: arseny.antonov at gmail.com (Arseniy Antonov) Date: Thu, 2 May 2019 21:45:40 +0300 Subject: [pytest-dev] pytest slack reporting plugin proposal In-Reply-To: References: <87a7g4iwir.fsf@powell.devork.be> Message-ID: I've initialized transfer process to you (Bruno) And added you and Floris as a maintainer in PyPi. ??, 2 ??? 2019 ?. ? 21:38, Bruno Oliveira : > Hi everyone > > On Thu, May 2, 2019 at 3:27 PM Arseniy Antonov > wrote: > >> >> Please tell me what I should do next by the process. >> > > Thanks Arseniy for the interest. > > The steps are written here: > > > https://github.com/pytest-dev/pytest/blob/master/CONTRIBUTING.rst#submitting-plugins-to-pytest-dev > > > Mainly, you should transfer ownership of the repository to a pytest-dev > admin (it can be me). From there, we will move the repository under the > pytest-dev organization and then add you back as maintainer/owner, then you > are free to add more collaborators if needed. Also it would be nice to add > a few pytest-dev people as maintainers in PyPI with release rights. > > Feel free to follow with any questions, or start the repository transfer > if you are OK with the process. > > Cheers, > Bruno > > >> >> ??, 2 ??? 2019 ?. ? 20:44, Floris Bruynooghe : >> >>> Hi Arseniy, Ronny, >>> >>> If you want to maintain your plugin under pytest-dev I think that should >>> be fine as long as [0] is followed. While indeed this doesn't mean >>> you'll magically have other maintainers it doesn't seem like that's what >>> you're after. So as long as the requirements are met this is probably >>> I'd think. >>> >>> Cheers, >>> Floris >>> >>> [0] >>> https://github.com/pytest-dev/pytest/blob/master/CONTRIBUTING.rst#submitting-plugins-to-pytest-dev >>> >>> On Fri 26 Apr 2019 at 11:05 +0300, Arseniy Antonov wrote: >>> >>> > I would say that I'm going to support it, but I think that this is not >>> > enough to get accepted. >>> > Actually, I think if this plugin will be accepted, it may put the >>> light on >>> > the report tools from the bit different side. >>> > And I suppose that there will be such requests like, add the same for >>> the >>> > "Telegram/Discord", and if this will happen, I would like to support >>> it, >>> > and maybe rename pytest-slack to pytest-report-messengers. >>> > >>> > >>> > ??, 25 ???. 2019 ?. ? 17:05, Ronny Pfannschmidt : >>> > >>> >> Hi Arseniy, >>> >> >>> >> thanks for your proposal, >>> >> this is definitively useful for pytest users, which use slack. >>> >> However pytest itself does not. >>> >> >>> >> If pytest-dev takes this on, there is a need of slack aware/using >>> >> maintainers that move this along (else its just going to painfully and >>> >> slowly degrade) >>> >> I encourage Interested/Invested parties to reach out so we can >>> understand >>> >> the bus-effects we need to consider. >>> >> I believe this is a nice and useful addition, but we need to ensure >>> that >>> >> long term maintenance under the pytest-dev umbrella is a reality. >>> >> >>> >> -- Ronny >>> >> >>> >> Am Mi., 24. Apr. 2019 um 12:00 Uhr schrieb Arseniy Antonov < >>> >> arseny.antonov at gmail.com>: >>> >> >>> >>> Hello, >>> >>> I've developed a plugin for sending pytest results to the slack. >>> >>> I suppose it may be a useful tool for the pytest community, so I >>> want to >>> >>> contribute it to the pytest-dev. >>> >>> Please review: >>> >>> >>> >>> https://github.com/ArseniyAntonov/pytest-slack >>> >>> >>> >>> -- >>> >>> -------------------------- >>> >>> Regards. >>> >>> Arseny Antonov >>> >>> _______________________________________________ >>> >>> pytest-dev mailing list >>> >>> pytest-dev at python.org >>> >>> https://mail.python.org/mailman/listinfo/pytest-dev >>> >>> >>> >> >>> >> >>> >> -- >>> >> >>> >> Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn, >>> >> Commercial register: Amtsgericht Muenchen, HRB 153243, >>> >> Managing Directors: Charles Cachera, Michael Cunningham, Michael >>> O'Neill, Eric Shander >>> >> >>> >> >>> >> >> >> -- >> -------------------------- >> Regards. >> Arseny Antonov >> _______________________________________________ >> pytest-dev mailing list >> pytest-dev at python.org >> https://mail.python.org/mailman/listinfo/pytest-dev >> > -- -------------------------- Regards. Arseny Antonov -------------- next part -------------- An HTML attachment was scrubbed... URL: From nicoddemus at gmail.com Thu May 2 14:49:25 2019 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Thu, 2 May 2019 15:49:25 -0300 Subject: [pytest-dev] pytest slack reporting plugin proposal In-Reply-To: References: <87a7g4iwir.fsf@powell.devork.be> Message-ID: On Thu, May 2, 2019 at 3:45 PM Arseniy Antonov wrote: > I've initialized transfer process to you (Bruno) > And added you and Floris as a maintainer in PyPi. > Thanks Anseniy, I have completed the transfer, everything should be in place (let me know otherwise). The next step is probably to update links, badges, etc to the new URL. Welcome! :) Cheers > > ??, 2 ??? 2019 ?. ? 21:38, Bruno Oliveira : > >> Hi everyone >> >> On Thu, May 2, 2019 at 3:27 PM Arseniy Antonov >> wrote: >> >>> >>> Please tell me what I should do next by the process. >>> >> >> Thanks Arseniy for the interest. >> >> The steps are written here: >> >> >> https://github.com/pytest-dev/pytest/blob/master/CONTRIBUTING.rst#submitting-plugins-to-pytest-dev >> >> >> Mainly, you should transfer ownership of the repository to a pytest-dev >> admin (it can be me). From there, we will move the repository under the >> pytest-dev organization and then add you back as maintainer/owner, then you >> are free to add more collaborators if needed. Also it would be nice to add >> a few pytest-dev people as maintainers in PyPI with release rights. >> >> Feel free to follow with any questions, or start the repository transfer >> if you are OK with the process. >> >> Cheers, >> Bruno >> >> >>> >>> ??, 2 ??? 2019 ?. ? 20:44, Floris Bruynooghe : >>> >>>> Hi Arseniy, Ronny, >>>> >>>> If you want to maintain your plugin under pytest-dev I think that should >>>> be fine as long as [0] is followed. While indeed this doesn't mean >>>> you'll magically have other maintainers it doesn't seem like that's what >>>> you're after. So as long as the requirements are met this is probably >>>> I'd think. >>>> >>>> Cheers, >>>> Floris >>>> >>>> [0] >>>> https://github.com/pytest-dev/pytest/blob/master/CONTRIBUTING.rst#submitting-plugins-to-pytest-dev >>>> >>>> On Fri 26 Apr 2019 at 11:05 +0300, Arseniy Antonov wrote: >>>> >>>> > I would say that I'm going to support it, but I think that this is not >>>> > enough to get accepted. >>>> > Actually, I think if this plugin will be accepted, it may put the >>>> light on >>>> > the report tools from the bit different side. >>>> > And I suppose that there will be such requests like, add the same for >>>> the >>>> > "Telegram/Discord", and if this will happen, I would like to support >>>> it, >>>> > and maybe rename pytest-slack to pytest-report-messengers. >>>> > >>>> > >>>> > ??, 25 ???. 2019 ?. ? 17:05, Ronny Pfannschmidt >>> >: >>>> > >>>> >> Hi Arseniy, >>>> >> >>>> >> thanks for your proposal, >>>> >> this is definitively useful for pytest users, which use slack. >>>> >> However pytest itself does not. >>>> >> >>>> >> If pytest-dev takes this on, there is a need of slack aware/using >>>> >> maintainers that move this along (else its just going to painfully >>>> and >>>> >> slowly degrade) >>>> >> I encourage Interested/Invested parties to reach out so we can >>>> understand >>>> >> the bus-effects we need to consider. >>>> >> I believe this is a nice and useful addition, but we need to ensure >>>> that >>>> >> long term maintenance under the pytest-dev umbrella is a reality. >>>> >> >>>> >> -- Ronny >>>> >> >>>> >> Am Mi., 24. Apr. 2019 um 12:00 Uhr schrieb Arseniy Antonov < >>>> >> arseny.antonov at gmail.com>: >>>> >> >>>> >>> Hello, >>>> >>> I've developed a plugin for sending pytest results to the slack. >>>> >>> I suppose it may be a useful tool for the pytest community, so I >>>> want to >>>> >>> contribute it to the pytest-dev. >>>> >>> Please review: >>>> >>> >>>> >>> https://github.com/ArseniyAntonov/pytest-slack >>>> >>> >>>> >>> -- >>>> >>> -------------------------- >>>> >>> Regards. >>>> >>> Arseny Antonov >>>> >>> _______________________________________________ >>>> >>> pytest-dev mailing list >>>> >>> pytest-dev at python.org >>>> >>> https://mail.python.org/mailman/listinfo/pytest-dev >>>> >>> >>>> >> >>>> >> >>>> >> -- >>>> >> >>>> >> Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn, >>>> >> Commercial register: Amtsgericht Muenchen, HRB 153243, >>>> >> Managing Directors: Charles Cachera, Michael Cunningham, Michael >>>> O'Neill, Eric Shander >>>> >> >>>> >> >>>> >>> >>> >>> -- >>> -------------------------- >>> Regards. >>> Arseny Antonov >>> _______________________________________________ >>> pytest-dev mailing list >>> pytest-dev at python.org >>> https://mail.python.org/mailman/listinfo/pytest-dev >>> >> > > -- > -------------------------- > Regards. > Arseny Antonov > -------------- next part -------------- An HTML attachment was scrubbed... URL: From arseny.antonov at gmail.com Thu May 2 14:52:52 2019 From: arseny.antonov at gmail.com (Arseniy Antonov) Date: Thu, 2 May 2019 21:52:52 +0300 Subject: [pytest-dev] pytest slack reporting plugin proposal In-Reply-To: References: <87a7g4iwir.fsf@powell.devork.be> Message-ID: Thanks! Will do it in 1 day. Also, GitHub is pretty friendly and routes all requests after transferring to the new URL. ??, 2 ??? 2019 ?. ? 21:49, Bruno Oliveira : > > On Thu, May 2, 2019 at 3:45 PM Arseniy Antonov > wrote: > >> I've initialized transfer process to you (Bruno) >> And added you and Floris as a maintainer in PyPi. >> > > Thanks Anseniy, > > I have completed the transfer, everything should be in place (let me know > otherwise). > > The next step is probably to update links, badges, etc to the new URL. > > Welcome! :) > > Cheers > >> >> ??, 2 ??? 2019 ?. ? 21:38, Bruno Oliveira : >> >>> Hi everyone >>> >>> On Thu, May 2, 2019 at 3:27 PM Arseniy Antonov >>> wrote: >>> >>>> >>>> Please tell me what I should do next by the process. >>>> >>> >>> Thanks Arseniy for the interest. >>> >>> The steps are written here: >>> >>> >>> https://github.com/pytest-dev/pytest/blob/master/CONTRIBUTING.rst#submitting-plugins-to-pytest-dev >>> >>> >>> Mainly, you should transfer ownership of the repository to a pytest-dev >>> admin (it can be me). From there, we will move the repository under the >>> pytest-dev organization and then add you back as maintainer/owner, then you >>> are free to add more collaborators if needed. Also it would be nice to add >>> a few pytest-dev people as maintainers in PyPI with release rights. >>> >>> Feel free to follow with any questions, or start the repository transfer >>> if you are OK with the process. >>> >>> Cheers, >>> Bruno >>> >>> >>>> >>>> ??, 2 ??? 2019 ?. ? 20:44, Floris Bruynooghe : >>>> >>>>> Hi Arseniy, Ronny, >>>>> >>>>> If you want to maintain your plugin under pytest-dev I think that >>>>> should >>>>> be fine as long as [0] is followed. While indeed this doesn't mean >>>>> you'll magically have other maintainers it doesn't seem like that's >>>>> what >>>>> you're after. So as long as the requirements are met this is probably >>>>> I'd think. >>>>> >>>>> Cheers, >>>>> Floris >>>>> >>>>> [0] >>>>> https://github.com/pytest-dev/pytest/blob/master/CONTRIBUTING.rst#submitting-plugins-to-pytest-dev >>>>> >>>>> On Fri 26 Apr 2019 at 11:05 +0300, Arseniy Antonov wrote: >>>>> >>>>> > I would say that I'm going to support it, but I think that this is >>>>> not >>>>> > enough to get accepted. >>>>> > Actually, I think if this plugin will be accepted, it may put the >>>>> light on >>>>> > the report tools from the bit different side. >>>>> > And I suppose that there will be such requests like, add the same >>>>> for the >>>>> > "Telegram/Discord", and if this will happen, I would like to support >>>>> it, >>>>> > and maybe rename pytest-slack to pytest-report-messengers. >>>>> > >>>>> > >>>>> > ??, 25 ???. 2019 ?. ? 17:05, Ronny Pfannschmidt >>>> >: >>>>> > >>>>> >> Hi Arseniy, >>>>> >> >>>>> >> thanks for your proposal, >>>>> >> this is definitively useful for pytest users, which use slack. >>>>> >> However pytest itself does not. >>>>> >> >>>>> >> If pytest-dev takes this on, there is a need of slack aware/using >>>>> >> maintainers that move this along (else its just going to painfully >>>>> and >>>>> >> slowly degrade) >>>>> >> I encourage Interested/Invested parties to reach out so we can >>>>> understand >>>>> >> the bus-effects we need to consider. >>>>> >> I believe this is a nice and useful addition, but we need to ensure >>>>> that >>>>> >> long term maintenance under the pytest-dev umbrella is a reality. >>>>> >> >>>>> >> -- Ronny >>>>> >> >>>>> >> Am Mi., 24. Apr. 2019 um 12:00 Uhr schrieb Arseniy Antonov < >>>>> >> arseny.antonov at gmail.com>: >>>>> >> >>>>> >>> Hello, >>>>> >>> I've developed a plugin for sending pytest results to the slack. >>>>> >>> I suppose it may be a useful tool for the pytest community, so I >>>>> want to >>>>> >>> contribute it to the pytest-dev. >>>>> >>> Please review: >>>>> >>> >>>>> >>> https://github.com/ArseniyAntonov/pytest-slack >>>>> >>> >>>>> >>> -- >>>>> >>> -------------------------- >>>>> >>> Regards. >>>>> >>> Arseny Antonov >>>>> >>> _______________________________________________ >>>>> >>> pytest-dev mailing list >>>>> >>> pytest-dev at python.org >>>>> >>> https://mail.python.org/mailman/listinfo/pytest-dev >>>>> >>> >>>>> >> >>>>> >> >>>>> >> -- >>>>> >> >>>>> >> Red Hat GmbH, http://www.de.redhat.com/, Registered seat: >>>>> Grasbrunn, >>>>> >> Commercial register: Amtsgericht Muenchen, HRB 153243, >>>>> >> Managing Directors: Charles Cachera, Michael Cunningham, Michael >>>>> O'Neill, Eric Shander >>>>> >> >>>>> >> >>>>> >>>> >>>> >>>> -- >>>> -------------------------- >>>> Regards. >>>> Arseny Antonov >>>> _______________________________________________ >>>> pytest-dev mailing list >>>> pytest-dev at python.org >>>> https://mail.python.org/mailman/listinfo/pytest-dev >>>> >>> >> >> -- >> -------------------------- >> Regards. >> Arseny Antonov >> > -- -------------------------- Regards. Arseny Antonov -------------- next part -------------- An HTML attachment was scrubbed... URL: From flub at devork.be Thu May 2 17:17:07 2019 From: flub at devork.be (Floris Bruynooghe) Date: Thu, 02 May 2019 23:17:07 +0200 Subject: [pytest-dev] pytest slack reporting plugin proposal In-Reply-To: References: <87a7g4iwir.fsf@powell.devork.be> Message-ID: <877eb8imjw.fsf@powell.devork.be> Great, that all seems to have worked quickly. Thanks for improving the pytest ecosystem! On Thu 02 May 2019 at 21:52 +0300, Arseniy Antonov wrote: > Thanks! > > Will do it in 1 day. > Also, GitHub is pretty friendly and routes all requests after transferring > to the new URL. > > > > > ??, 2 ??? 2019 ?. ? 21:49, Bruno Oliveira : > >> >> On Thu, May 2, 2019 at 3:45 PM Arseniy Antonov >> wrote: >> >>> I've initialized transfer process to you (Bruno) >>> And added you and Floris as a maintainer in PyPi. >>> >> >> Thanks Anseniy, >> >> I have completed the transfer, everything should be in place (let me know >> otherwise). >> >> The next step is probably to update links, badges, etc to the new URL. >> >> Welcome! :) >> >> Cheers >> >>> >>> ??, 2 ??? 2019 ?. ? 21:38, Bruno Oliveira : >>> >>>> Hi everyone >>>> >>>> On Thu, May 2, 2019 at 3:27 PM Arseniy Antonov >>>> wrote: >>>> >>>>> >>>>> Please tell me what I should do next by the process. >>>>> >>>> >>>> Thanks Arseniy for the interest. >>>> >>>> The steps are written here: >>>> >>>> >>>> https://github.com/pytest-dev/pytest/blob/master/CONTRIBUTING.rst#submitting-plugins-to-pytest-dev >>>> >>>> >>>> Mainly, you should transfer ownership of the repository to a pytest-dev >>>> admin (it can be me). From there, we will move the repository under the >>>> pytest-dev organization and then add you back as maintainer/owner, then you >>>> are free to add more collaborators if needed. Also it would be nice to add >>>> a few pytest-dev people as maintainers in PyPI with release rights. >>>> >>>> Feel free to follow with any questions, or start the repository transfer >>>> if you are OK with the process. >>>> >>>> Cheers, >>>> Bruno >>>> >>>> >>>>> >>>>> ??, 2 ??? 2019 ?. ? 20:44, Floris Bruynooghe : >>>>> >>>>>> Hi Arseniy, Ronny, >>>>>> >>>>>> If you want to maintain your plugin under pytest-dev I think that >>>>>> should >>>>>> be fine as long as [0] is followed. While indeed this doesn't mean >>>>>> you'll magically have other maintainers it doesn't seem like that's >>>>>> what >>>>>> you're after. So as long as the requirements are met this is probably >>>>>> I'd think. >>>>>> >>>>>> Cheers, >>>>>> Floris >>>>>> >>>>>> [0] >>>>>> https://github.com/pytest-dev/pytest/blob/master/CONTRIBUTING.rst#submitting-plugins-to-pytest-dev >>>>>> >>>>>> On Fri 26 Apr 2019 at 11:05 +0300, Arseniy Antonov wrote: >>>>>> >>>>>> > I would say that I'm going to support it, but I think that this is >>>>>> not >>>>>> > enough to get accepted. >>>>>> > Actually, I think if this plugin will be accepted, it may put the >>>>>> light on >>>>>> > the report tools from the bit different side. >>>>>> > And I suppose that there will be such requests like, add the same >>>>>> for the >>>>>> > "Telegram/Discord", and if this will happen, I would like to support >>>>>> it, >>>>>> > and maybe rename pytest-slack to pytest-report-messengers. >>>>>> > >>>>>> > >>>>>> > ??, 25 ???. 2019 ?. ? 17:05, Ronny Pfannschmidt >>>>> >: >>>>>> > >>>>>> >> Hi Arseniy, >>>>>> >> >>>>>> >> thanks for your proposal, >>>>>> >> this is definitively useful for pytest users, which use slack. >>>>>> >> However pytest itself does not. >>>>>> >> >>>>>> >> If pytest-dev takes this on, there is a need of slack aware/using >>>>>> >> maintainers that move this along (else its just going to painfully >>>>>> and >>>>>> >> slowly degrade) >>>>>> >> I encourage Interested/Invested parties to reach out so we can >>>>>> understand >>>>>> >> the bus-effects we need to consider. >>>>>> >> I believe this is a nice and useful addition, but we need to ensure >>>>>> that >>>>>> >> long term maintenance under the pytest-dev umbrella is a reality. >>>>>> >> >>>>>> >> -- Ronny >>>>>> >> >>>>>> >> Am Mi., 24. Apr. 2019 um 12:00 Uhr schrieb Arseniy Antonov < >>>>>> >> arseny.antonov at gmail.com>: >>>>>> >> >>>>>> >>> Hello, >>>>>> >>> I've developed a plugin for sending pytest results to the slack. >>>>>> >>> I suppose it may be a useful tool for the pytest community, so I >>>>>> want to >>>>>> >>> contribute it to the pytest-dev. >>>>>> >>> Please review: >>>>>> >>> >>>>>> >>> https://github.com/ArseniyAntonov/pytest-slack >>>>>> >>> >>>>>> >>> -- >>>>>> >>> -------------------------- >>>>>> >>> Regards. >>>>>> >>> Arseny Antonov >>>>>> >>> _______________________________________________ >>>>>> >>> pytest-dev mailing list >>>>>> >>> pytest-dev at python.org >>>>>> >>> https://mail.python.org/mailman/listinfo/pytest-dev >>>>>> >>> >>>>>> >> >>>>>> >> >>>>>> >> -- >>>>>> >> >>>>>> >> Red Hat GmbH, http://www.de.redhat.com/, Registered seat: >>>>>> Grasbrunn, >>>>>> >> Commercial register: Amtsgericht Muenchen, HRB 153243, >>>>>> >> Managing Directors: Charles Cachera, Michael Cunningham, Michael >>>>>> O'Neill, Eric Shander >>>>>> >> >>>>>> >> >>>>>> >>>>> >>>>> >>>>> -- >>>>> -------------------------- >>>>> Regards. >>>>> Arseny Antonov >>>>> _______________________________________________ >>>>> pytest-dev mailing list >>>>> pytest-dev at python.org >>>>> https://mail.python.org/mailman/listinfo/pytest-dev >>>>> >>>> >>> >>> -- >>> -------------------------- >>> Regards. >>> Arseny Antonov >>> >> From nicoddemus at gmail.com Fri May 3 08:11:40 2019 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Fri, 3 May 2019 09:11:40 -0300 Subject: [pytest-dev] [core] Tidelift Funding In-Reply-To: <87d0l0ixed.fsf@powell.devork.be> References: <87d0l0ixed.fsf@powell.devork.be> Message-ID: Hi Floris, On Thu, May 2, 2019 at 2:25 PM Floris Bruynooghe wrote: > Why the rules about active? Seems complicated and more open to > arguing. I liked the Pillow guidelines you linked: > https://github.com/orgs/pytest-dev/teams/contributors can express > interest and https://github.com/orgs/pytest-dev/teams/core decides on > split (which I guess can be anything from 0% to 100%). With the same > assumption that the core members are reasonable that should end up as > roughly the same. > > Mind you in practice I have no issue with the above proposal of people > right now, but would also not mind if e.g. hpk or ronny wanted to be > part right now (I'll pass myself). Likewise there are probably cases > where I wouldn't mind people not in core being paid for some time. > I wrote those "rules" just to come up with a solid proposal in the e-mail, but I do like yours better. Letting developers opt-in to a share is fair and reasonable, certainly. I think we should even always split the funding evenly between those opting to receive it, to further avoid any arguing on that. But in general I'm +1, let's make it happen if there's anyone interested > in getting paid. > Great, let's see what others think. Cheers, Bruno. -------------- next part -------------- An HTML attachment was scrubbed... URL: From asottile+pytest at umich.edu Fri May 3 12:10:59 2019 From: asottile+pytest at umich.edu (Anthony Sottile) Date: Fri, 3 May 2019 09:10:59 -0700 Subject: [pytest-dev] [core] Tidelift Funding In-Reply-To: References: Message-ID: > Hi Floris, > > On Thu, May 2, 2019 at 2:25 PM Floris Bruynooghe wrote: > > > Why the rules about active? Seems complicated and more open to > > arguing. I liked the Pillow guidelines you linked: > > https://github.com/orgs/pytest-dev/teams/contributors can express > > interest and https://github.com/orgs/pytest-dev/teams/core decides on > > split (which I guess can be anything from 0% to 100%). With the same > > assumption that the core members are reasonable that should end up as > > roughly the same. > > > > Mind you in practice I have no issue with the above proposal of people > > right now, but would also not mind if e.g. hpk or ronny wanted to be > > part right now (I'll pass myself). Likewise there are probably cases > > where I wouldn't mind people not in core being paid for some time. > > > > I wrote those "rules" just to come up with a solid proposal in the e-mail, > but I do like yours better. Letting developers opt-in to a share is fair > and reasonable, certainly. > > I think we should even always split the funding evenly between those opting > to receive it, to further avoid any arguing on that. > > But in general I'm +1, let's make it happen if there's anyone interested > > in getting paid. > > > > Great, let's see what others think. > > Cheers, > Bruno. I think TideLift seems like a good step in the right direction -- also agree on the "active" bit being the most difficult to resolve here -- where possible let's adhere to the simplest-as-possible here -- I like the opt-in approach proposed above :thumbsup: Anthony From genml+pytest-dev at thequod.de Fri May 3 19:34:41 2019 From: genml+pytest-dev at thequod.de (Daniel Hahler) Date: Sat, 4 May 2019 01:34:41 +0200 Subject: [pytest-dev] Keeping failing test ids for git bisect In-Reply-To: <20190502092816.2udu4fkqveuccllj@hooch.localdomain> References: <20190502092816.2udu4fkqveuccllj@hooch.localdomain> Message-ID: On 02.05.19 11:28, Florian Bruhin wrote: >> Is there a way to run a bunch of tests like with --lf but don't clear >> the cache when they pass? > What would be nice is something like a --save-collected and > --load-collected . Then you could do "--lf --save-collected bisect" once, > and do "--load-collected bisect" to rerun exactly those tests. > > I wanted to write a plugin for that for months (if not years) now, but never > got around to it. So far I've also done what you described. See https://github.com/pytest-dev/pytest/issues/5073 for general improvements for the last-failed plugin, and https://github.com/pytest-dev/pytest/issues/1017 from 2016 for this specific issue. I think this should be addressed/fixed there, instead of creating a new plugin. As for workarounds, I've used to do `cp -a .pytest_cache/v/cache/lastfailed{,.stash}` (and the other way around) also. But a better workaround is using a wrapper that puts the cache in its own Git directory, allowing for `p-cache commit -a -m saved`, `p-cache checkout .` etc then. (it also clearly showed a problem with the --newest-first plugin (#5206)). ``` #!/bin/sh # Wrapper around git in .pytest_cache/v/cache. set -e # TODO: could use `m=((../)#.pytest_cache(N))` in Zsh for upward search. root=.pytest_cache/v/cache if ! [ -d "$root" ]; then error "Directory $root does not exist" fi cd "$root" if ! [ -e ".git" ]; then git init . git commit --allow-empty -m "init" git add --all . git commit -m "initial state" fi git "$@" ``` From florian.schulze at gmx.net Sat May 4 02:32:10 2019 From: florian.schulze at gmx.net (Florian Schulze) Date: Sat, 04 May 2019 08:32:10 +0200 Subject: [pytest-dev] Keeping failing test ids for git bisect In-Reply-To: References: <20190502092816.2udu4fkqveuccllj@hooch.localdomain> Message-ID: <4F9CB768-5EA8-4609-8DEC-7E88B12FCA27@gmx.net> On 4 May 2019, at 1:34, Daniel Hahler wrote: >> I wanted to write a plugin for that for months (if not years) now, >> but never >> got around to it. So far I've also done what you described. > > See https://github.com/pytest-dev/pytest/issues/5073 for general > improvements for the last-failed plugin, and > https://github.com/pytest-dev/pytest/issues/1017 from 2016 for this > specific issue. > > I think this should be addressed/fixed there, instead of creating a > new plugin. As can be seen from the attempts Ronny made, it's hard to get it right. That's why I think this should evolve in a plugin and can eventually be moved to core. The issues showed me several use cases I didn't think about and I think it's not trivial to find a good cli ui for all of them. Regards, Florian Schulze From opensource at ronnypfannschmidt.de Sun May 5 10:09:46 2019 From: opensource at ronnypfannschmidt.de (Ronny Pfannschmidt) Date: Sun, 5 May 2019 16:09:46 +0200 Subject: [pytest-dev] [core] Tidelift Funding In-Reply-To: References: <87d0l0ixed.fsf@powell.devork.be> Message-ID: Hi all, even tho its going to take a while before im going to be active again, i think its a good idea to have this as a opt-in. Currently a Fair Share Mechanism on a opt in basis seems fair, if we ever hit a situation where someone could have a reasonably set up part/full-time position primarily on pytest we should take a look at how division is fair in that case. so +1 -- Ronny Am 03.05.19 um 14:11 schrieb Bruno Oliveira: > Hi Floris, > > On Thu, May 2, 2019 at 2:25 PM Floris Bruynooghe > wrote: > > Why the rules about active?? Seems complicated and more open to > arguing.? I liked the Pillow guidelines you linked: > https://github.com/orgs/pytest-dev/teams/contributors can express > interest and https://github.com/orgs/pytest-dev/teams/core decides on > split (which I guess can be anything from 0% to 100%).? With the same > assumption that the core members are reasonable that should end up as > roughly the same. > > Mind you in practice I have no issue with the above proposal of people > right now, but would also not mind if e.g. hpk or ronny wanted to be > part right now (I'll pass myself).? Likewise there are probably cases > where I wouldn't mind people not in core being paid for some time. > > > I wrote those "rules" just to come up with a solid proposal in the > e-mail, but I do like yours better. Letting developers opt-in to a > share is fair and reasonable, certainly. > > I think we should even always split the funding evenly between those > opting to receive it, to further avoid any arguing on that. > > But in general I'm +1, let's make it happen if there's anyone > interested > in getting paid. > > > Great, let's see what others think. > > Cheers, > Bruno. > > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: From nicoddemus at gmail.com Mon May 6 10:03:30 2019 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Mon, 6 May 2019 11:03:30 -0300 Subject: [pytest-dev] [core] Tidelift Funding In-Reply-To: References: <87d0l0ixed.fsf@powell.devork.be> Message-ID: Hi Ronny, On Sun, May 5, 2019 at 11:09 AM Ronny Pfannschmidt < opensource at ronnypfannschmidt.de> wrote: > i think its a good idea to have this as a opt-in. > > Currently a Fair Share Mechanism on a opt in basis seems fair, > if we ever hit a situation where someone could have a reasonably set up > part/full-time position primarily on pytest we should take a look at how > division is fair in that case. > Agreed, thanks Ronny. If nobody objects, I plan to move this forward later this week. One question is how do we track which maintainers are opting to receive funding. I'm thinking of opening an issue which lists the contributors receiving the funding; maintainers are then free to post a comment indicating if they want to start/stop receiving funding, at which point we update the original post. Another option would be to use the Wiki, but we don't receive change notifications so there's a chance of we getting out of sync with the configuration on Tidelift. Suggestions? Another question is regarding admins of the Tidelift dashboard. I volunteer to do it, but would like more people to also be admins to reduce the bus factor, so other volunteers are appreciated as well. Cheers, Bruno. > -- Ronny > > > Am 03.05.19 um 14:11 schrieb Bruno Oliveira: > > Hi Floris, > > On Thu, May 2, 2019 at 2:25 PM Floris Bruynooghe wrote: > >> Why the rules about active? Seems complicated and more open to >> arguing. I liked the Pillow guidelines you linked: >> https://github.com/orgs/pytest-dev/teams/contributors can express >> interest and https://github.com/orgs/pytest-dev/teams/core decides on >> split (which I guess can be anything from 0% to 100%). With the same >> assumption that the core members are reasonable that should end up as >> roughly the same. >> >> Mind you in practice I have no issue with the above proposal of people >> right now, but would also not mind if e.g. hpk or ronny wanted to be >> part right now (I'll pass myself). Likewise there are probably cases >> where I wouldn't mind people not in core being paid for some time. >> > > I wrote those "rules" just to come up with a solid proposal in the e-mail, > but I do like yours better. Letting developers opt-in to a share is fair > and reasonable, certainly. > > I think we should even always split the funding evenly between those > opting to receive it, to further avoid any arguing on that. > > But in general I'm +1, let's make it happen if there's anyone interested >> in getting paid. >> > > Great, let's see what others think. > > Cheers, > Bruno. > > _______________________________________________ > pytest-dev mailing listpytest-dev at python.orghttps://mail.python.org/mailman/listinfo/pytest-dev > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From opensource at ronnypfannschmidt.de Mon May 6 17:58:50 2019 From: opensource at ronnypfannschmidt.de (Ronny Pfannschmidt) Date: Mon, 6 May 2019 23:58:50 +0200 Subject: [pytest-dev] [core] Tidelift Funding In-Reply-To: References: <87d0l0ixed.fsf@powell.devork.be> Message-ID: <735cb1d6-d4a6-e6ab-a780-2bdfa7ed39a0@ronnypfannschmidt.de> Am 06.05.19 um 16:03 schrieb Bruno Oliveira: > Hi Ronny, > > On Sun, May 5, 2019 at 11:09 AM Ronny Pfannschmidt > > wrote: > > i think its a good idea to have this as a opt-in. > > Currently a Fair Share Mechanism on a opt in basis seems fair, > if we ever hit a situation where someone could have a reasonably > set up part/full-time position primarily on pytest we should take > a look at how division is fair in that case. > > > Agreed, thanks Ronny. > > If nobody objects, I plan to move this forward later this week. > > One question is how do we track which maintainers are opting to > receive funding. > > I'm thinking of opening an issue which lists the contributors > receiving the funding; maintainers are then free to post a comment > indicating if they want to start/stop receiving funding, at which > point we update the original post. Another option would be to use the > Wiki, but we don't receive change notifications so there's a chance of > we getting out of sync with the configuration on Tidelift. Suggestions? > we should make a git repo where we track meta level documentation, that way we chould have a ci with credentials run the checks i wonder if tidelift hasn an api published for that > Another question is regarding admins of the Tidelift dashboard. I > volunteer to do it, but would like more people to also be admins to > reduce the bus factor, so other volunteers are appreciated as well. in about 2-3 Months i can Commit to such role as well. Cheers Ronny > > Cheers, > Bruno. > > -- Ronny > > > Am 03.05.19 um 14:11 schrieb Bruno Oliveira: >> Hi Floris, >> >> On Thu, May 2, 2019 at 2:25 PM Floris Bruynooghe > > wrote: >> >> Why the rules about active?? Seems complicated and more open to >> arguing.? I liked the Pillow guidelines you linked: >> https://github.com/orgs/pytest-dev/teams/contributors can express >> interest and https://github.com/orgs/pytest-dev/teams/core >> decides on >> split (which I guess can be anything from 0% to 100%).? With >> the same >> assumption that the core members are reasonable that should >> end up as >> roughly the same. >> >> Mind you in practice I have no issue with the above proposal >> of people >> right now, but would also not mind if e.g. hpk or ronny >> wanted to be >> part right now (I'll pass myself).? Likewise there are >> probably cases >> where I wouldn't mind people not in core being paid for some >> time. >> >> >> I wrote those "rules" just to come up with a solid proposal in >> the e-mail, but I do like yours better. Letting developers opt-in >> to a share is fair and reasonable, certainly. >> >> I think we should even always split the funding evenly between >> those opting to receive it, to further avoid any arguing on that. >> >> But in general I'm +1, let's make it happen if there's anyone >> interested >> in getting paid. >> >> >> Great, let's see what others think. >> >> Cheers, >> Bruno. >> >> _______________________________________________ >> pytest-dev mailing list >> pytest-dev at python.org >> https://mail.python.org/mailman/listinfo/pytest-dev > -------------- next part -------------- An HTML attachment was scrubbed... URL: From flub at devork.be Tue May 7 14:18:35 2019 From: flub at devork.be (Floris Bruynooghe) Date: Tue, 07 May 2019 20:18:35 +0200 Subject: [pytest-dev] [core] Tidelift Funding In-Reply-To: <735cb1d6-d4a6-e6ab-a780-2bdfa7ed39a0@ronnypfannschmidt.de> References: <87d0l0ixed.fsf@powell.devork.be> <735cb1d6-d4a6-e6ab-a780-2bdfa7ed39a0@ronnypfannschmidt.de> Message-ID: <87v9ym162s.fsf@powell.devork.be> On Mon 06 May 2019 at 23:58 +0200, Ronny Pfannschmidt wrote: > Am 06.05.19 um 16:03 schrieb Bruno Oliveira: >> Hi Ronny, >> >> On Sun, May 5, 2019 at 11:09 AM Ronny Pfannschmidt >> > > wrote: >> >> i think its a good idea to have this as a opt-in. >> >> Currently a Fair Share Mechanism on a opt in basis seems fair, >> if we ever hit a situation where someone could have a reasonably >> set up part/full-time position primarily on pytest we should take >> a look at how division is fair in that case. >> >> >> Agreed, thanks Ronny. >> >> If nobody objects, I plan to move this forward later this week. >> >> One question is how do we track which maintainers are opting to >> receive funding. > >> >> I'm thinking of opening an issue which lists the contributors >> receiving the funding; maintainers are then free to post a comment >> indicating if they want to start/stop receiving funding, at which >> point we update the original post. Another option would be to use the >> Wiki, but we don't receive change notifications so there's a chance of >> we getting out of sync with the configuration on Tidelift. Suggestions? >> > we should make a git repo where we track meta level documentation, > that way we chould have a ci with credentials run the checks +1 to tracking this in a text file in a vcs repo. > i wonder if tidelift hasn an api published for that > > >> Another question is regarding admins of the Tidelift dashboard. I >> volunteer to do it, but would like more people to also be admins to >> reduce the bus factor, so other volunteers are appreciated as well. > > in about 2-3 Months i can Commit to such role as well. If there's no need for the admins to also be paid I'm happy to help the bus factor there too. Cheers, Floris From nicoddemus at gmail.com Tue May 7 14:36:37 2019 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Tue, 7 May 2019 15:36:37 -0300 Subject: [pytest-dev] [core] Tidelift Funding In-Reply-To: <87v9ym162s.fsf@powell.devork.be> References: <87d0l0ixed.fsf@powell.devork.be> <735cb1d6-d4a6-e6ab-a780-2bdfa7ed39a0@ronnypfannschmidt.de> <87v9ym162s.fsf@powell.devork.be> Message-ID: On Tue, May 7, 2019 at 3:20 PM Floris Bruynooghe wrote: > On Mon 06 May 2019 at 23:58 +0200, Ronny Pfannschmidt wrote: > > > we should make a git repo where we track meta level documentation, > > that way we chould have a ci with credentials run the checks > > +1 to tracking this in a text file in a vcs repo. > Indeed, that's a good idea: we have a formal process already in place to add/remove lifters, PRs. :) Any objections to a `Tidelift.md` in pytest's own repository? A separate repository for now seems overkill. The file should also contain instructions about the steps required to start receiving funds. > i wonder if tidelift hasn an api published for that > > > > > >> Another question is regarding admins of the Tidelift dashboard. I > >> volunteer to do it, but would like more people to also be admins to > >> reduce the bus factor, so other volunteers are appreciated as well. > > > > in about 2-3 Months i can Commit to such role as well. > > If there's no need for the admins to also be paid I'm happy to help the > bus factor there too. > Sure, thanks Floris! Cheers, Bruno > > Cheers, > Floris > -------------- next part -------------- An HTML attachment was scrubbed... URL: From flub at devork.be Tue May 7 14:52:56 2019 From: flub at devork.be (Floris Bruynooghe) Date: Tue, 07 May 2019 20:52:56 +0200 Subject: [pytest-dev] [core] Tidelift Funding In-Reply-To: References: <87d0l0ixed.fsf@powell.devork.be> <735cb1d6-d4a6-e6ab-a780-2bdfa7ed39a0@ronnypfannschmidt.de> <87v9ym162s.fsf@powell.devork.be> Message-ID: <87sgtq14hj.fsf@powell.devork.be> On Tue 07 May 2019 at 15:36 -0300, Bruno Oliveira wrote: > On Tue, May 7, 2019 at 3:20 PM Floris Bruynooghe wrote: > >> On Mon 06 May 2019 at 23:58 +0200, Ronny Pfannschmidt wrote: >> >> > we should make a git repo where we track meta level documentation, >> > that way we chould have a ci with credentials run the checks >> >> +1 to tracking this in a text file in a vcs repo. >> > > Indeed, that's a good idea: we have a formal process already in place to > add/remove lifters, PRs. :) > > Any objections to a `Tidelift.md` in pytest's own repository? A separate > repository for now seems overkill. I'd bikeshed the choice of capitalisation but otherwise that seems fine to me. ;) It can be split off once there's too many meta things in the repo. > The file should also contain instructions about the steps required to start > receiving funds. Good idea, the more transparency the better. Cheers, Floris From genml+pytest-dev at thequod.de Wed May 8 04:53:29 2019 From: genml+pytest-dev at thequod.de (Daniel Hahler) Date: Wed, 8 May 2019 10:53:29 +0200 Subject: [pytest-dev] [core] Tidelift Funding In-Reply-To: References: <20190502074402.zetxdfwb3hozevgw@hooch.localdomain> Message-ID: <6b6e3851-eaac-2325-67a6-fb7735fdf403@thequod.de> On 02.05.19 11:05, Bruno Oliveira wrote: > > there were no obligations whatsoever after joining the platform other than > > "maintain the project", which they were already doing anyway. There's no > > obligation to market the platform in anyway as well (say, being forced to > > put their logo on the website). > > Their website says otherwise: > > https://tidelift.com/docs/lifting/marketing > > "At Tidelift, we're working with maintainers to jointly create a product. As > with any product offering, we need to tell people the product exists." > > "When you sign up to lift a package and get paid, we're asking for you to keep > a mention of the Tidelift Subscription at minimum on your project's main "home > page"?whether that's a dedicated website or simply a README on GitHub. We're > flexible about the exact wording and format, and happy to consult with you on > it." > > "But the main reason is that we do need to tell potential subscribers about the > product, so they can support you by buying it!" > > Hmm you are right, but I think it is more of a suggestion rather than an obligation. It reads more like a requirement. See https://tidelift.com/docs/lifting/maintenance: > One reason for this is that it proves you're a maintainer of the > project and that there's a consensus among comaintainers to > participate in Tidelift. But that would be fine I guess, and could have just the form of a badge in the list of badges we have already. >> https://tidelift.com/docs/lifting/tasks-overview > You are right. Fortunately those were very quick to do in my > experience with pytest-mock. I believe the same amount of work would > be required by pytest, even if it is a much larger project. The only more involving / recurring task appears to be pasting the release notes over into their dashboard for releases, which is not that hard - and they plan to automate this. I like their approach, and am in for also receiving funds. Cheers, Daniel. -- https://daniel.hahler.de/ From genml+pytest-dev at thequod.de Wed May 8 04:57:09 2019 From: genml+pytest-dev at thequod.de (Daniel Hahler) Date: Wed, 8 May 2019 10:57:09 +0200 Subject: [pytest-dev] [core] Tidelift Funding In-Reply-To: <87sgtq14hj.fsf@powell.devork.be> References: <87d0l0ixed.fsf@powell.devork.be> <735cb1d6-d4a6-e6ab-a780-2bdfa7ed39a0@ronnypfannschmidt.de> <87v9ym162s.fsf@powell.devork.be> <87sgtq14hj.fsf@powell.devork.be> Message-ID: <243b4499-38b9-75af-3c5c-58dc4ef06b65@thequod.de> On 07.05.19 20:52, Floris Bruynooghe wrote: >>>> we should make a git repo where we track meta level documentation, >>>> that way we chould have a ci with credentials run the checks >>> >>> +1 to tracking this in a text file in a vcs repo. >>> >> >> Indeed, that's a good idea: we have a formal process already in place to >> add/remove lifters, PRs. :) >> >> Any objections to a `Tidelift.md` in pytest's own repository? A separate >> repository for now seems overkill. > > I'd bikeshed the choice of capitalisation but otherwise that seems fine > to me. ;) > It can be split off once there's too many meta things in the repo. > >> The file should also contain instructions about the steps required to start >> receiving funds. I think a new repository like pytest-meta, or pytest-org makes sense - it is easy to setup in general, and keeps away noise from the main repo. We could create some issue in the main repo to link to it for transparency. But maybe just having an issue for it in the (main) repo is enough already: you get notifications, it can be edited etc. Cheers, Daniel. From nicoddemus at gmail.com Wed May 8 07:05:25 2019 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Wed, 8 May 2019 08:05:25 -0300 Subject: [pytest-dev] [core] Tidelift Funding In-Reply-To: <243b4499-38b9-75af-3c5c-58dc4ef06b65@thequod.de> References: <87d0l0ixed.fsf@powell.devork.be> <735cb1d6-d4a6-e6ab-a780-2bdfa7ed39a0@ronnypfannschmidt.de> <87v9ym162s.fsf@powell.devork.be> <87sgtq14hj.fsf@powell.devork.be> <243b4499-38b9-75af-3c5c-58dc4ef06b65@thequod.de> Message-ID: Hey Daniel, On Wed, May 8, 2019 at 5:57 AM Daniel Hahler wrote: > > I think a new repository like pytest-meta, or pytest-org makes sense - it > is > easy to setup in general, and keeps away noise from the main repo. > > We could create some issue in the main repo to link to it for transparency. > > But maybe just having an issue for it in the (main) repo is enough already: > you get notifications, it can be edited etc. > I think the plan for now is to just have a TIDELIFT.rst (wink Floris) on the main repository with instructions, and the maintainers interested in receiving funds. To update the document we use standard PRs. I believe this will fit for now, but if we find it lacking we can easily move to a separate repository for sure. About automation, they have a simple API for posting new CHANGELOGs: https://tidelift.com/docs/api, so that can be definitely automated. Cheers, Bruno. -------------- next part -------------- An HTML attachment was scrubbed... URL: From nicoddemus at gmail.com Wed May 8 17:18:05 2019 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Wed, 8 May 2019 18:18:05 -0300 Subject: [pytest-dev] pytest 4.4.2 Message-ID: pytest 4.4.2 has just been released to PyPI. This is a bug-fix release, being a drop-in replacement. To upgrade:: pip install --upgrade pytest The full changelog is available at https://docs.pytest.org/en/latest/changelog.html. Thanks to all who contributed to this release, among them: * Allan Lewis * Anthony Sottile * Bruno Oliveira * DamianSkrzypczak * Daniel Hahler * Don Kirkby * Douglas Thor * Hugo * Ilya Konstantinov * Jon Dufresne * Matt Cooper * Nikolay Kondratyev * Ond?ej S?kup * Peter Schutt * Romain Chossart * Sitaktif Happy testing, The pytest Development Team -------------- next part -------------- An HTML attachment was scrubbed... URL: From nicoddemus at gmail.com Thu May 9 18:19:59 2019 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Thu, 9 May 2019 19:19:59 -0300 Subject: [pytest-dev] [core] Tidelift Funding In-Reply-To: References: <87d0l0ixed.fsf@powell.devork.be> <735cb1d6-d4a6-e6ab-a780-2bdfa7ed39a0@ronnypfannschmidt.de> <87v9ym162s.fsf@powell.devork.be> <87sgtq14hj.fsf@powell.devork.be> <243b4499-38b9-75af-3c5c-58dc4ef06b65@thequod.de> Message-ID: Hi everyone, I've registered pytest with Tidelift, so it is now officially part of the platform: https://tidelift.com/subscription/pkg/pypi-pytest I've opened a PR documenting what we've discussed here: https://github.com/pytest-dev/pytest/pull/5240 Any suggestions are very welcome! Cheers, On Wed, May 8, 2019 at 8:05 AM Bruno Oliveira wrote: > Hey Daniel, > > On Wed, May 8, 2019 at 5:57 AM Daniel Hahler > wrote: > >> >> I think a new repository like pytest-meta, or pytest-org makes sense - it >> is >> easy to setup in general, and keeps away noise from the main repo. >> >> We could create some issue in the main repo to link to it for >> transparency. >> >> But maybe just having an issue for it in the (main) repo is enough >> already: >> you get notifications, it can be edited etc. >> > > I think the plan for now is to just have a TIDELIFT.rst (wink Floris) on > the main repository with instructions, and the maintainers interested in > receiving funds. To update the document we use standard PRs. I believe this > will fit for now, but if we find it lacking we can easily move to a > separate repository for sure. > > About automation, they have a simple API for posting new CHANGELOGs: > https://tidelift.com/docs/api, so that can be definitely automated. > > Cheers, > Bruno. > -------------- next part -------------- An HTML attachment was scrubbed... URL: From nicoddemus at gmail.com Sat May 11 20:41:41 2019 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Sat, 11 May 2019 21:41:41 -0300 Subject: [pytest-dev] pytest 4.5 Message-ID: The pytest team is proud to announce the 4.5.0 release! pytest is a mature Python testing tool with more than a 2000 tests against itself, passing on many different interpreters and platforms. This release contains a number of bugs fixes and improvements, so users are encouraged to take a look at the CHANGELOG: https://docs.pytest.org/en/latest/changelog.html For complete documentation, please visit: https://docs.pytest.org/en/latest/ As usual, you can upgrade from pypi via: pip install -U pytest Thanks to all who contributed to this release, among them: * Anthony Sottile * Bruno Oliveira * Daniel Hahler * Floris Bruynooghe * Pulkit Goyal * Samuel Searles-Bryant * Zac Hatfield-Dodds Happy testing, The Pytest Development Team -------------- next part -------------- An HTML attachment was scrubbed... URL: From 03sjbrown at gmail.com Sun May 12 19:44:01 2019 From: 03sjbrown at gmail.com (Shawn Brown) Date: Sun, 12 May 2019 19:44:01 -0400 Subject: [pytest-dev] Using pytest_assertrepr_compare() for marked tests only? Message-ID: I'm playing with the idea of returning a custom explanation for tests with a particular marker but returning Pytest's standard explanation for tests without the marker. I was hoping to do something like this... # content of conftest.py def pytest_assertrepr_compare(config, op, left, right): if : return ['My custom explanation!'] # content of test_mystuff.py import pytest def test_mystuff1(): assert 100 == 105 @pytest.mark.mymark def test_mystuff2(): assert 100 == 105 # Desired Output __________ test_mystuff1 __________ def test_mystuff1(): > assert 100 == 105 E assert 100 == 105 E -100 E +105 test_mystuff.py:4: AssertionError __________ test_mystuff2 __________ @pytest.mark.mymark def test_mystuff2(): > assert 100 == 105 E assert My custom explanation! test_mystuff.py:8: AssertionError I've looked through the plugin API but I don't see a straightforward way of doing this. I was hoping I could get a reference to the current test through the config (even if it was a convoluted reference) but I don't know if this is possible. Digging deeper, I see some undesirable approaches I could probably use to accomplish this (e.g., monkey-patch util._reprcompare or possibly maintain a plugin-level global that points to the current test) but nothing that seems to work with the grain of the plugin API. So I have a few related questions I'm hoping someone can help me with: Q: Is there a way to reference the current test from within pytest_assertrepr_compare()? Q: If not, is there a decent way to implement something like this that isn't too hacky? -------------- next part -------------- An HTML attachment was scrubbed... URL: From me at the-compiler.org Mon May 13 05:06:16 2019 From: me at the-compiler.org (Florian Bruhin) Date: Mon, 13 May 2019 11:06:16 +0200 Subject: [pytest-dev] Using pytest_assertrepr_compare() for marked tests only? In-Reply-To: References: Message-ID: <20190513090616.r4tl7igdtwbjp6ct@hooch.localdomain> On Sun, May 12, 2019 at 07:44:01PM -0400, Shawn Brown wrote: > So I have a few related questions I'm hoping someone can help me with: > > Q: Is there a way to reference the current test from within > pytest_assertrepr_compare()? > > Q: If not, is there a decent way to implement something like this that > isn't too hacky? In your own code, you probably can't do so easily. However, pytest itself does have access to the item when calling pytest_assertrepr_compare - so you might want to consider submitting a contribution to pytest to pass the item to the hook as well! :) Florian -- https://www.qutebrowser.org | me at the-compiler.org (Mail/XMPP) GPG: 916E B0C8 FD55 A072 | https://the-compiler.org/pubkey.asc I love long mails! | https://email.is-not-s.ms/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: From flub at devork.be Mon May 13 15:59:00 2019 From: flub at devork.be (Floris Bruynooghe) Date: Mon, 13 May 2019 21:59:00 +0200 Subject: [pytest-dev] Using pytest_assertrepr_compare() for marked tests only? In-Reply-To: References: Message-ID: <87ef5215yz.fsf@powell.devork.be> Hi Shawn, On Sun 12 May 2019 at 19:44 -0400, Shawn Brown wrote: > I'm playing with the idea of returning a custom explanation for tests with > a particular marker but returning Pytest's standard explanation for tests > without the marker. Interesting, would you mind describing your usecase a bit more why this makes sense? Not because I want to stop such an feature but really just curious what information you want that you don't have in the type. > I've looked through the plugin API but I don't see a straightforward way of > doing this. I was hoping I could get a reference to the current test > through the config (even if it was a convoluted reference) but I don't know > if this is possible. Digging deeper, I see some undesirable approaches I > could probably use to accomplish this (e.g., monkey-patch util._reprcompare > or possibly maintain a plugin-level global that points to the current test) > but nothing that seems to work with the grain of the plugin API. > > So I have a few related questions I'm hoping someone can help me with: > > Q: Is there a way to reference the current test from within > pytest_assertrepr_compare()? > > Q: If not, is there a decent way to implement something like this that > isn't too hacky? As Florian said, currently we didn't think of exposing the Item to this hook, but it sounds reasonable to have. Such a change would be backwards compatible so would be a great feature for you to contribute? IIRC the mechanism of how the hook is provided should allow to add the item to the call. If you're up to creating the feature and would like some guidance I'd be happy to help, perhaps create an issue on github to discuss further details (and follow up on this thread with a link). Kind Regards, Floris From 03sjbrown at gmail.com Thu May 16 12:03:36 2019 From: 03sjbrown at gmail.com (Shawn Brown) Date: Thu, 16 May 2019 12:03:36 -0400 Subject: [pytest-dev] Using pytest_assertrepr_compare() for marked tests only? In-Reply-To: <87ef5215yz.fsf@powell.devork.be> References: <87ef5215yz.fsf@powell.devork.be> Message-ID: Floris and Florian, Thanks for the feedback. As I mentioned, this is something I was playing with as an experiment. My specific use case would not be satisfied with this change but I thought I'd ask if this were possible since it was an idea I stumbled across while investigating my usecase. I will, however, detail my usecase just so you know what I'm working on. I've been developing a package that repurposes software testing practices for data validation (https://datatest.rtfd.io/). A simple example using the datatest's validate() function: from datatest import validate def test_somedata(): data = {'A', 'B', 'C', 'D'} requirement = {'A', 'B'} validate(data, requirement) The test above will fail with the following exception: ValidationError: does not satisfy set membership (2 differences): [ Extra('C'), Extra('D'), ] The ValidationError is a subclass of AssertionError. It contains one item for each element in `data` that fails to satisfy the `requirement`. I was playing around with the idea of a marker to implement something like the following (see below) but still generate the ValidationError output via pytest's plugin system: import pytest @pytest.mark.validate def test_somedata(): data = {'A', 'B', 'C', 'D'} requirement = {'A', 'B'} assert data == requirement The idea is to use an `assert` statement but still get the ValidationError output (although there are many cases where using "==" is semantically wrong so the validate() function wouldn't go away in all cases). While I could emulate this type of output with pytest_assertrepr_compare(), I need to do more than emulate the error. Here's where things get more involved: The datatest package also implements a system of acceptances that operate on the items contained within the ValidationError. If a user decides that the "Extra" items are acceptable, they can use the accepted() context manager: from datatest import validate, accepted, Extra def test_somedata(): data = {'A', 'B', 'C', 'D'} requirement = {'A', 'B'} with accepted(Extra): validate(data, requirement) In this case, the accepted() context manager accepts all of the items in the error (which suppresses the error entirely). But if it contained other items that were not accepted, then an error would be re-raised with the remainder of the items. Below, I've added comments showing why the assertrepr comparison can't work with the context manager: import pytest from datatest import validate, accepted, Extra @pytest.mark.validate def test_somedata(): data = {'A', 'B', 'C', 'D'} requirement = {'A', 'B'} with accepted(Extra): # <- Never receives an inspectible error! assert data == requirement # <- Raises an assertion that can not be inspected or changed! To implement my dream "validate marker", I would need to manipulate the assertion inside the scope of the context manager--which is what the validate() function does. But doing this is far from what pytest_assertrepr_compare() has access to. One solution I could see is an entirely new hook: def pytest_do_assertion(item, op, left, right=None): """ perform comparison Returns an AssertionError or None """ But from what I can see, implementing a hook like `pytest_do_assertion` could require unreasonably invasive changes to pytest. That said, I would be very interested if something like `pytest_do_assertion()` were possible to add but I understand if it's not. Also, the hook name is just a throwaway idea, it's probably not appropriate. -Shawn -------------- next part -------------- An HTML attachment was scrubbed... URL: From kdelee at redhat.com Thu May 16 17:28:25 2019 From: kdelee at redhat.com (Elijah DeLee) Date: Thu, 16 May 2019 17:28:25 -0400 Subject: [pytest-dev] Other plugin breaking usage of pytest-cache Message-ID: Reference issue: https://github.com/ansible/pytest-mp/issues/18 tl;dr Using the pytest-mp plugin breaks the collection/recording of failed tests in the lastfailed cache. I'm having trouble knowing where to start looking. Can anyone give me a clue at what point the tests get recorded into the cache? Thanks! Elijah DeLee ------------------ Quality Engineer Red Hat -------------- next part -------------- An HTML attachment was scrubbed... URL: From nicoddemus at gmail.com Thu May 16 17:39:56 2019 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Thu, 16 May 2019 18:39:56 -0300 Subject: [pytest-dev] Other plugin breaking usage of pytest-cache In-Reply-To: References: Message-ID: Hi Elijah, On Thu, May 16, 2019 at 6:29 PM Elijah DeLee wrote: > Reference issue: https://github.com/ansible/pytest-mp/issues/18 > > > I'm having trouble knowing where to start looking. Can anyone give me a > clue at what point the tests get recorded into the cache? > The last-failed support is done inside cacheprovider in an implementation of the pytest_runtest_logreport[1] hook. The last-failed support works with pytest-xdist, but because there's special pytest-xdist handling in the pytest_sessionfinish hook[2]; the "hasattr(config, 'slaveinput')" is an implementation detail that LFPlugin is using to avoid having the workers also trying to write to the cache. If the problem is indeed that the workers of the pytest-mp plugin are trying to write to the cache at the same time, you can check if that's the case by inserting a "slaveinput" attribute into the config object in the workers, and see if that fixes it. [1]: https://github.com/pytest-dev/pytest/blob/master/src/_pytest/cacheprovider.py#L193 [2]: https://github.com/pytest-dev/pytest/blob/master/src/_pytest/cacheprovider.py#L261 Cheers, Bruno -------------- next part -------------- An HTML attachment was scrubbed... URL: From kdelee at redhat.com Fri May 17 11:08:23 2019 From: kdelee at redhat.com (Elijah DeLee) Date: Fri, 17 May 2019 11:08:23 -0400 Subject: [pytest-dev] Other plugin breaking usage of pytest-cache In-Reply-To: References: Message-ID: Great, thanks for the leads! I will let you know if I make progress On Thu, May 16, 2019 at 5:40 PM Bruno Oliveira wrote: > Hi Elijah, > > > On Thu, May 16, 2019 at 6:29 PM Elijah DeLee wrote: > >> Reference issue: https://github.com/ansible/pytest-mp/issues/18 >> >> >> I'm having trouble knowing where to start looking. Can anyone give me a >> clue at what point the tests get recorded into the cache? >> > > The last-failed support is done inside cacheprovider in an implementation > of the pytest_runtest_logreport[1] hook. > > The last-failed support works with pytest-xdist, but because there's > special pytest-xdist handling in the pytest_sessionfinish hook[2]; the > "hasattr(config, 'slaveinput')" > is an implementation detail that LFPlugin is using to avoid having the > workers also trying to write to the cache. > > If the problem is indeed that the workers of the pytest-mp plugin are > trying to write to the cache at the same time, you can check if that's the > case by inserting a > "slaveinput" attribute into the config object in the workers, and see if > that fixes it. > > [1]: > https://github.com/pytest-dev/pytest/blob/master/src/_pytest/cacheprovider.py#L193 > [2]: > https://github.com/pytest-dev/pytest/blob/master/src/_pytest/cacheprovider.py#L261 > > Cheers, > Bruno > -- Elijah DeLee ------------------ Quality Engineer -------------- next part -------------- An HTML attachment was scrubbed... URL: From brianna.laugher at gmail.com Wed May 22 20:48:14 2019 From: brianna.laugher at gmail.com (Brianna Laugher) Date: Thu, 23 May 2019 10:48:14 +1000 Subject: [pytest-dev] [core] Tidelift Funding In-Reply-To: References: <87d0l0ixed.fsf@powell.devork.be> <735cb1d6-d4a6-e6ab-a780-2bdfa7ed39a0@ronnypfannschmidt.de> <87v9ym162s.fsf@powell.devork.be> <87sgtq14hj.fsf@powell.devork.be> <243b4499-38b9-75af-3c5c-58dc4ef06b65@thequod.de> Message-ID: Hi, It looks like there are a few more repos that could be claimed as well: https://tidelift.com/lifter/search/pypi/pytest-xdist https://tidelift.com/lifter/search/pypi/pytest-cov https://tidelift.com/lifter/search/pypi/pluggy https://tidelift.com/lifter/search/pypi/py etc. cheers Brianna On Fri, 10 May 2019 at 08:20, Bruno Oliveira wrote: > Hi everyone, > > I've registered pytest with Tidelift, so it is now officially part of the > platform: https://tidelift.com/subscription/pkg/pypi-pytest > > I've opened a PR documenting what we've discussed here: > > https://github.com/pytest-dev/pytest/pull/5240 > > Any suggestions are very welcome! > > Cheers, > > On Wed, May 8, 2019 at 8:05 AM Bruno Oliveira > wrote: > >> Hey Daniel, >> >> On Wed, May 8, 2019 at 5:57 AM Daniel Hahler >> wrote: >> >>> >>> I think a new repository like pytest-meta, or pytest-org makes sense - >>> it is >>> easy to setup in general, and keeps away noise from the main repo. >>> >>> We could create some issue in the main repo to link to it for >>> transparency. >>> >>> But maybe just having an issue for it in the (main) repo is enough >>> already: >>> you get notifications, it can be edited etc. >>> >> >> I think the plan for now is to just have a TIDELIFT.rst (wink Floris) on >> the main repository with instructions, and the maintainers interested in >> receiving funds. To update the document we use standard PRs. I believe this >> will fit for now, but if we find it lacking we can easily move to a >> separate repository for sure. >> >> About automation, they have a simple API for posting new CHANGELOGs: >> https://tidelift.com/docs/api, so that can be definitely automated. >> >> Cheers, >> Bruno. >> > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev > -- They've just been waiting in a mountain for the right moment: http://modernthings.org/ -------------- next part -------------- An HTML attachment was scrubbed... URL: