From mail at florian-schulze.net Thu Jun 1 04:43:17 2017 From: mail at florian-schulze.net (Florian Schulze) Date: Thu, 01 Jun 2017 10:43:17 +0200 Subject: [pytest-dev] pytest.org redirect request (#2453) In-Reply-To: References: Message-ID: <89E40D3A-B8B9-48B3-B678-179AF818EDFE@florian-schulze.net> Fixed Regards, Florian Schulze On 31 May 2017, at 17:51, Bruno Oliveira wrote: > Hi everyone, > > An issue has been raised in the bug tracker asking to redirect > docs.pytest.org/latest/* to docs.pytest.org/en/latest/*: > > https://github.com/pytest-dev/pytest/issues/2453 > > Whoever has powers to that change the redirect rules could take a look > please? Thanks! > > Cheers, > Bruno. > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: From opensource at ronnypfannschmidt.de Mon Jun 5 05:10:00 2017 From: opensource at ronnypfannschmidt.de (RonnyPfannschmidt) Date: Mon, 5 Jun 2017 11:10:00 +0200 Subject: [pytest-dev] proposal: experiment with going for setup.cfg metadata for pylib/pytest/pytest-* Message-ID: Hi everyone, since a while now setuptools has supported putting most of the metadata into setup.cfg see https://setuptools.readthedocs.io/en/latest/setuptools.html#configuring-setup-using-setup-cfg-files for demonstrative purposes i experimented with it in https://github.com/pytest-dev/apipkg/pull/2 in terms of maintenance i def prefer the modern format as its more static however it does introduce a requirement on a reasonably recent setuptools (30.3.0) so it may create trouble for from source installs on enterprise distros, however wheel based installs are not affected -- Ronny From me at the-compiler.org Mon Jun 5 06:45:51 2017 From: me at the-compiler.org (Florian Bruhin) Date: Mon, 5 Jun 2017 12:45:51 +0200 Subject: [pytest-dev] proposal: experiment with going for setup.cfg metadata for pylib/pytest/pytest-* In-Reply-To: References: Message-ID: <20170605104551.55kiyirqmlxce7kw@hooch.localdomain> Hi, On Mon, Jun 05, 2017 at 11:10:00AM +0200, RonnyPfannschmidt wrote: > for demonstrative purposes i experimented with it in > https://github.com/pytest-dev/apipkg/pull/2 It already seems to break things in various ways on Travis, for starters. > in terms of maintenance i def prefer the modern format as its more static > however it does introduce a requirement on a reasonably recent > setuptools (30.3.0) So the only benefit for all the breakage is "it looks a bit nicer", basically? > so it may create trouble for from source installs on enterprise distros, > however wheel based installs are not affected Not worth the benefit, IMHO. Not at all. Florian -- https://www.qutebrowser.org | me at the-compiler.org (Mail/XMPP) GPG: 916E B0C8 FD55 A072 | https://the-compiler.org/pubkey.asc I love long mails! | https://email.is-not-s.ms/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: From nicoddemus at gmail.com Mon Jun 5 08:32:08 2017 From: nicoddemus at gmail.com (nicoddemus at gmail.com) Date: Mon, 5 Jun 2017 05:32:08 -0700 Subject: [pytest-dev] proposal: experiment with going for setup.cfg metadata for pylib/pytest/pytest-* In-Reply-To: <20170605104551.55kiyirqmlxce7kw@hooch.localdomain> References: <20170605104551.55kiyirqmlxce7kw@hooch.localdomain> Message-ID: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 In general I'm all up for improving things internally, even if it is just to make it "prettier". But in this case Florian raises some valid points, namely what specific benfits does this brings to us maintainers and users, and how much pain we can unleash for users trying to do a source install on their systems? If we don't have very good tangible benefits to introduce this, I would rather wait some more time for the setup.cfg support to stabilize before introducing it into pytest. Cheers, Bruno -----BEGIN PGP SIGNATURE----- Version: CryptUp 4.1.1 Gmail Encryption https://cryptup.org Comment: Seamlessly send, receive and search encrypted email wsFcBAEBCAAQBQJZNU97CRCCcZWFVN7dUQAA7VYP+wX7bayAXhxcRO4j6/E3 34mLE8GtOq/paGLhMf8Qc3fEBtG/vs5c81yZnNIxaG0mGcWwQ3HCZe2PAjKa BWE7g9yJKKPL96QjVs95M+T0If5nZde7AricLaD2x2aM5OI50qQpfSknSbIk 6+qb34YtWXmpcL5MEqrja9spJ2ln9Uvmph/tiKWkW8NRqk+y4ur62AzR+1O8 q+kiMNzP12h2cG9lA5wj71lMigzX2anX7gZydnXJwxCmvy2ElyY/Y6pC7ytD dLkgPt3DRZZ8/VbG8erW9NI4YMNH8rXDHR8qmIfG+PnocF7TqkiJXWhewJ+b k+p6qUPfdSmqOkNr9/cesohTrmibfONDDZFtRbzJh2VmKHEf+7TgKVDN2O5j r9SbSevoI+xklO880/iPtbtVTGwE4Ocl39SL3Bcec3XLx8bep1SIDA8aqPCb yP5ZZ0Rsj7u2xROnH2jj3INqo5ztu2RD37QdLcMXfVmLjf7CjAX7j2fKij0u EypwpmsBj2vuM6AYRyVuMkd48wriyoJ6xFmnxM9qysgpm3dJ0TVIr65v1Q5L WBQLEv2YF2nCL00858eBoASgyh3BHKgSf5Snx4vcC3ZHYyGs3mbhwa3pbLRb QRlqWFNlIJYvF3oJICp7JEaPpM0dMcuK3on8CrrLP4e379IQBFO+M4aFEWTC wKDn =uTrA -----END PGP SIGNATURE----- From nicoddemus at gmail.com Fri Jun 9 07:19:09 2017 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Fri, 09 Jun 2017 11:19:09 +0000 Subject: [pytest-dev] pytest 3.1.2 Message-ID: pytest 3.1.2 has just been released to PyPI. This is a bug-fix release, being a drop-in replacement. To upgrade:: pip install --upgrade pytest The full changelog is available at http://doc.pytest.org/en/latest/changelog.html. Thanks to all who contributed to this release, among them: * Andreas Pelme * ApaDoctor * Bruno Oliveira * Florian Bruhin * Ronny Pfannschmidt * Segev Finer Happy testing, The pytest Development Team -------------- next part -------------- An HTML attachment was scrubbed... URL: From raphael at hackebrot.de Thu Jun 15 15:58:25 2017 From: raphael at hackebrot.de (Raphael Pierzina) Date: Thu, 15 Jun 2017 21:58:25 +0200 Subject: [pytest-dev] Sponsored pytest stickers Message-ID: <8C6A6118-E041-4550-BFE8-4EECFE49C4A1@hackebrot.de> Hi pytest friends, I am planning to order a batch of pytest stickers for PyData Berlin and EuroPython. The folks over at Sticker Mule would be happy to sponsor this on condition that we link to their website in our project README. What?s your opinion on this? Would you be happy if I add a new section labelled ?Sponsors? and thank them for giving us free stickers? Any objections? Looking forward to your feedback. Thanks, Raphael From flub at devork.be Fri Jun 16 16:05:11 2017 From: flub at devork.be (Floris Bruynooghe) Date: Fri, 16 Jun 2017 22:05:11 +0200 Subject: [pytest-dev] Sponsored pytest stickers In-Reply-To: <8C6A6118-E041-4550-BFE8-4EECFE49C4A1@hackebrot.de> References: <8C6A6118-E041-4550-BFE8-4EECFE49C4A1@hackebrot.de> Message-ID: <87d1a3em14.fsf@powell.devork.be> Hi, Raphael Pierzina writes: > I am planning to order a batch of pytest stickers for PyData Berlin > and EuroPython. The folks over at Sticker Mule would be happy to > sponsor this on condition that we link to their website in our project > README. What?s your opinion on this? Would you be happy if I add a new > section labelled ?Sponsors? and thank them for giving us free > stickers? Any objections? In principle we have credited sponsors before: http://blog.pytest.org/2016/pytest-development-sprint/ Now the README is probably much more prominent then a blog post while I imagine stickers are worth a lot less then $300 so the location is maybe a bit unfair to our previous sponsors? I'd certainly have no objection to a blog post saying some of us are attending EuroPython and that we're getting stickers sponsored by Sticker Mule though. For actually adding to the README I'm a bit more cautious. Just my 2c though, curious what other people think. Cheers, Floris From holger at merlinux.eu Mon Jun 19 02:35:54 2017 From: holger at merlinux.eu (holger krekel) Date: Mon, 19 Jun 2017 08:35:54 +0200 Subject: [pytest-dev] Sponsored pytest stickers In-Reply-To: <87d1a3em14.fsf@powell.devork.be> References: <8C6A6118-E041-4550-BFE8-4EECFE49C4A1@hackebrot.de> <87d1a3em14.fsf@powell.devork.be> Message-ID: <20170619063554.GB25604@beto> Hi Floris, On Fri, Jun 16, 2017 at 22:05 +0200, Floris Bruynooghe wrote: > > Hi, > > Raphael Pierzina writes: > > I am planning to order a batch of pytest stickers for PyData Berlin > > and EuroPython. The folks over at Sticker Mule would be happy to > > sponsor this on condition that we link to their website in our project > > README. What?s your opinion on this? Would you be happy if I add a new > > section labelled ?Sponsors? and thank them for giving us free > > stickers? Any objections? > > In principle we have credited sponsors before: > http://blog.pytest.org/2016/pytest-development-sprint/ > > Now the README is probably much more prominent then a blog post while I > imagine stickers are worth a lot less then $300 so the location is maybe > a bit unfair to our previous sponsors? I'd certainly have no objection > to a blog post saying some of us are attending EuroPython and that we're > getting stickers sponsored by Sticker Mule though. For actually adding > to the README I'm a bit more cautious. > > Just my 2c though, curious what other people think. i tend to agree -- adding to project readme is quite permanent for a one time $300 payment. also we have ~4K EUR left from last year's crowd funding so we can use that for stickers. Raphael, to get the stickers issue resolved right now for the upcoming confs, how about you get in contact with me to arrange for invoices for stickers to be paid? If btw a pytest core dev needs travel reimbursements for confs i suggest to also pay this from the crowd funds. holger From me at the-compiler.org Mon Jun 19 06:04:59 2017 From: me at the-compiler.org (Florian Bruhin) Date: Mon, 19 Jun 2017 12:04:59 +0200 Subject: [pytest-dev] Sponsored pytest stickers In-Reply-To: <20170619063554.GB25604@beto> References: <8C6A6118-E041-4550-BFE8-4EECFE49C4A1@hackebrot.de> <87d1a3em14.fsf@powell.devork.be> <20170619063554.GB25604@beto> Message-ID: <20170619100459.nl4u5tfb2hgu5b2t@hooch.localdomain> On Mon, Jun 19, 2017 at 08:35:54AM +0200, holger krekel wrote: > Hi Floris, > > On Fri, Jun 16, 2017 at 22:05 +0200, Floris Bruynooghe wrote: > > > > Hi, > > > > Raphael Pierzina writes: > > > I am planning to order a batch of pytest stickers for PyData Berlin > > > and EuroPython. The folks over at Sticker Mule would be happy to > > > sponsor this on condition that we link to their website in our project > > > README. What?s your opinion on this? Would you be happy if I add a new > > > section labelled ?Sponsors? and thank them for giving us free > > > stickers? Any objections? > > > > In principle we have credited sponsors before: > > http://blog.pytest.org/2016/pytest-development-sprint/ > > > > Now the README is probably much more prominent then a blog post while I > > imagine stickers are worth a lot less then $300 so the location is maybe > > a bit unfair to our previous sponsors? I'd certainly have no objection > > to a blog post saying some of us are attending EuroPython and that we're > > getting stickers sponsored by Sticker Mule though. For actually adding > > to the README I'm a bit more cautious. > > > > Just my 2c though, curious what other people think. > > i tend to agree -- adding to project readme is quite permanent for a one time > $300 payment. also we have ~4K EUR left from last year's crowd funding > so we can use that for stickers. Raphael, to get the stickers issue resolved > right now for the upcoming confs, how about you get in contact with me to > arrange for invoices for stickers to be paid? If btw a pytest core dev needs travel > reimbursements for confs i suggest to also pay this from the crowd funds. I'm with Floris and Holger here. Also note that $300 is about 1800 custom cut 5x5cm stickers, so realistically it'd probably be even less. Florian -- https://www.qutebrowser.org | me at the-compiler.org (Mail/XMPP) GPG: 916E B0C8 FD55 A072 | https://the-compiler.org/pubkey.asc I love long mails! | https://email.is-not-s.ms/ From rajib.jolite at gmail.com Tue Jun 20 06:15:50 2017 From: rajib.jolite at gmail.com (Rajib Mitra) Date: Tue, 20 Jun 2017 15:45:50 +0530 Subject: [pytest-dev] want to work in #2206 Message-ID: Dear Members, I would like to work in #2206 , rough performance analysis of the current internals, hope I can contribute , let me know if its fine. Regards, Rajib -------------- next part -------------- An HTML attachment was scrubbed... URL: From nicoddemus at gmail.com Tue Jun 20 10:24:58 2017 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Tue, 20 Jun 2017 14:24:58 +0000 Subject: [pytest-dev] want to work in #2206 In-Reply-To: References: Message-ID: Hi Rajib, Sure, thanks for your interest in tackling this! Ronny asked to be contacted about this in #2206; since he is the OP of that issue I suspect he has some general idea of which areas to focus on. Cheers, Bruno. On Tue, Jun 20, 2017 at 7:16 AM Rajib Mitra wrote: > Dear Members, > > I would like to work in #2206 , rough performance analysis of the current > internals, hope I can contribute , let me know if its fine. > > > Regards, > Rajib > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev > -------------- next part -------------- An HTML attachment was scrubbed... URL: From opensource at ronnypfannschmidt.de Wed Jun 21 08:17:09 2017 From: opensource at ronnypfannschmidt.de (RonnyPfannschmidt) Date: Wed, 21 Jun 2017 14:17:09 +0200 Subject: [pytest-dev] want to work in #2206 In-Reply-To: References: Message-ID: <95ece5a4-a63b-b3c5-c19f-011ff1278b47@ronnypfannschmidt.de> Hi Rajib, Bruni i currently did not focus on details, i just added it as a reminder, after i'm recovered from my stomach infect we can take a look. -- Ronny Am 20.06.2017 um 16:24 schrieb Bruno Oliveira: > Hi Rajib, > > Sure, thanks for your interest in tackling this! > > Ronny asked to be contacted about this in #2206; since he is the OP of > that issue I suspect he has some general idea of which areas to focus on. > > Cheers, > Bruno. > > On Tue, Jun 20, 2017 at 7:16 AM Rajib Mitra > wrote: > > Dear Members, > > I would like to work in #2206 , rough performance analysis of the > current internals, hope I can contribute , let me know if its fine. > > > Regards, > Rajib > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev > > > > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: From rajib.jolite at gmail.com Wed Jun 21 08:32:06 2017 From: rajib.jolite at gmail.com (Rajib Mitra) Date: Wed, 21 Jun 2017 18:02:06 +0530 Subject: [pytest-dev] want to work in #2206 In-Reply-To: <95ece5a4-a63b-b3c5-c19f-011ff1278b47@ronnypfannschmidt.de> References: <95ece5a4-a63b-b3c5-c19f-011ff1278b47@ronnypfannschmidt.de> Message-ID: Hey Ronny, Get well soon ! I will be available for this issue. Best Regards, Rajib On Wed, Jun 21, 2017 at 5:47 PM, RonnyPfannschmidt < opensource at ronnypfannschmidt.de> wrote: > Hi Rajib, Bruni > > i currently did not focus on details, > i just added it as a reminder, > after i'm recovered from my stomach infect we can take a look. > > -- Ronny > > Am 20.06.2017 um 16:24 schrieb Bruno Oliveira: > > Hi Rajib, > > Sure, thanks for your interest in tackling this! > > Ronny asked to be contacted about this in #2206; since he is the OP of > that issue I suspect he has some general idea of which areas to focus on. > > Cheers, > Bruno. > > On Tue, Jun 20, 2017 at 7:16 AM Rajib Mitra > wrote: > >> Dear Members, >> >> I would like to work in #2206 , rough performance analysis of the current >> internals, hope I can contribute , let me know if its fine. >> >> >> Regards, >> Rajib >> _______________________________________________ >> pytest-dev mailing list >> pytest-dev at python.org >> https://mail.python.org/mailman/listinfo/pytest-dev >> > > > _______________________________________________ > pytest-dev mailing listpytest-dev at python.orghttps://mail.python.org/mailman/listinfo/pytest-dev > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From nicoddemus at gmail.com Fri Jun 23 22:08:44 2017 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Sat, 24 Jun 2017 02:08:44 +0000 Subject: [pytest-dev] [proposal] introducing attrs to the codebase In-Reply-To: References: <20161206084337.218b6fec@ronny-ownpc> <1F38F4F9-FCC7-4D4E-82BC-6C3E70F92049@hackebrot.de> Message-ID: Guys, Just to share a thought that occurred to me while revisiting this: `attrs` probably generates new style classes, and as we learned by now even changing some old style classes to new style breaks the API. https://github.com/pytest-dev/pytest/issues/2398 We will probably need to do this movement in pytest 4.0 only. Another nice thing `attrs` would add is that it has an automatic "to_json" method, which would make work to serialize/unserialize objects (like pytest-xdist does today with the report objects for example) redundant. Cheers, On Tue, Dec 6, 2016 at 10:19 AM Florian Schulze wrote: > Hi! > > The v16 is because it uses time based version numbering. > > Regards, > Florian Schulze > > On 6 Dec 2016, at 12:52, Floris Bruynooghe wrote: > > Hi, > > Personally I also don't mind the dependency. Though I know in the past > we've had a policy of keeping dependencies to a minimum as well as > licenses. Attrs uses MIT as well so that should not be a problem. > > One thing which does stand out is that attrs is at v16, suggesting they > break their API a lot. Since you work with it already I guess you have an > idea on whether they've stabilised by now or the changes are not so bad? > > > As an aside, if we're happy to introduce more libraries then maybe we > should also consider the standard six package instead of doing our own > stuff, mostly because I'd make it easier for new contributors. > > Regards, > Floris > > On 6 Dec 2016 11:16, "Bruno Oliveira" wrote: > > Oh good point Raphael. > > Here's the link for the discussion about pip dropping Python 2.6: > https://github.com/pypa/pip/issues/3955 > > Cheers, > Bruno > > On Tue, Dec 6, 2016 at 8:57 AM Raphael Pierzina > wrote: > >> Hey there, >> >> I don?t mind adding a dependency as long as there is a need for it. +1 >> >> The problem I see with ?attrs? as it stands today, is that it does not >> support Python 2.6 whereas pytest does. So we probably want to get >> https://github.com/pytest-dev/pytest/issues/1273 in before adding >> ?attrs? as a dependency. I?m not up-to-date with how things are in pip as >> to dropping Python 2.6 compatibility. I can?t seem to find a ticket on the >> pip issue tracker. >> >> Best, >> Raphael >> >> On 06 Dec 2016, at 09:52, Bruno Oliveira wrote: >> >> Hi Ronny, >> >> Could you list the classes which you think would be changed to use >> 'attrs'? I'm not against adding another dependency if it can help us >> maintain the codebase. Also, introducing a new dependency should be done in >> `3.1.0`, not in a patch release. >> >> Cheers, >> Bruno. >> >> On Tue, Dec 6, 2016 at 5:44 AM Ronny Pfannschmidt < >> opensource at ronnypfannschmidt.de> wrote: >> >> Hi all, >> >> i'd like to introduce https://pypi.python.org/pypi/attrs as a >> dependency, >> >> its a fairly usefull library that takes away quite some boilerplate and >> common error cause while automatically adding repr, comparators and >> similar small details to python classes. >> >> I have used it in a number of personal projects, and dont want to miss >> it by now. >> >> -- Ronny >> _______________________________________________ >> pytest-dev mailing list >> pytest-dev at python.org >> https://mail.python.org/mailman/listinfo/pytest-dev >> >> _______________________________________________ >> pytest-dev mailing list >> pytest-dev at python.org >> https://mail.python.org/mailman/listinfo/pytest-dev >> >> >> > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev > > > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev > -------------- next part -------------- An HTML attachment was scrubbed... URL: From opensource at ronnypfannschmidt.de Sat Jun 24 01:53:15 2017 From: opensource at ronnypfannschmidt.de (RonnyPfannschmidt) Date: Sat, 24 Jun 2017 07:53:15 +0200 Subject: [pytest-dev] [proposal] introducing attrs to the codebase In-Reply-To: References: <20161206084337.218b6fec@ronny-ownpc> <1F38F4F9-FCC7-4D4E-82BC-6C3E70F92049@hackebrot.de> Message-ID: Hi Bruno, that doesn't prevent using it in new apis, i will use it in the new mark api. the aftermath of introducing FunctionDefinition may also be a good chance to just go ahead with a 4.0 and do the switch to consistently new-style classes as well as removing some of the cruft. -- Ronny Am 24.06.2017 um 04:08 schrieb Bruno Oliveira: > Guys, > > Just to share a thought that occurred to me while revisiting this: > `attrs` probably generates new style classes, and as we learned by now > even changing some old style classes to new style breaks the API. > > https://github.com/pytest-dev/pytest/issues/2398 > > We will probably need to do this movement in pytest 4.0 only. > > Another nice thing `attrs` would add is that it has an automatic > "to_json" method, which would make work to serialize/unserialize > objects (like pytest-xdist does today with the report objects for > example) redundant. > > Cheers, > > > > On Tue, Dec 6, 2016 at 10:19 AM Florian Schulze > > wrote: > > Hi! > > The v16 is because it uses time based version numbering. > > Regards, > Florian Schulze > > > On 6 Dec 2016, at 12:52, Floris Bruynooghe wrote: > > Hi, > > Personally I also don't mind the dependency. Though I know in > the past we've had a policy of keeping dependencies to a > minimum as well as licenses. Attrs uses MIT as well so that > should not be a problem. > > One thing which does stand out is that attrs is at v16, > suggesting they break their API a lot. Since you work with it > already I guess you have an idea on whether they've stabilised > by now or the changes are not so bad? > > > As an aside, if we're happy to introduce more libraries then > maybe we should also consider the standard six package instead > of doing our own stuff, mostly because I'd make it easier for > new contributors. > > Regards, > Floris > > On 6 Dec 2016 11:16, "Bruno Oliveira" > wrote: > > Oh good point Raphael. > > Here's the link for the discussion about pip dropping > Python 2.6: https://github.com/pypa/pip/issues/3955 > > Cheers, > Bruno > > On Tue, Dec 6, 2016 at 8:57 AM Raphael Pierzina > > wrote: > > Hey there, > > I don?t mind adding a dependency as long as there is a > need for it. +1 > > The problem I see with ?attrs? as it stands today, is > that it does not support Python 2.6 whereas pytest > does. So we probably want to > get https://github.com/pytest-dev/pytest/issues/1273 in > before adding ?attrs? as a dependency. I?m not > up-to-date with how things are in pip as to dropping > Python 2.6 compatibility. I can?t seem to find a > ticket on the pip issue tracker. > > Best, > Raphael > >> On 06 Dec 2016, at 09:52, Bruno Oliveira >> > >> wrote: >> >> Hi Ronny, >> >> Could you list the classes which you think would be >> changed to use 'attrs'? I'm not against adding >> another dependency if it can help us maintain the >> codebase. Also, introducing a new dependency should >> be done in `3.1.0`, not in a patch release. >> >> Cheers, >> Bruno. >> >> On Tue, Dec 6, 2016 at 5:44 AM Ronny Pfannschmidt >> > > wrote: >> >> Hi all, >> >> i'd like to introduce >> https://pypi.python.org/pypi/attrs as a >> dependency, >> >> its a fairly usefull library that takes away >> quite some boilerplate and >> common error cause while automatically adding >> repr, comparators and >> similar small details to python classes. >> >> I have used it in a number of personal projects, >> and dont want to miss >> it by now. >> >> -- Ronny >> _______________________________________________ >> pytest-dev mailing list >> pytest-dev at python.org >> https://mail.python.org/mailman/listinfo/pytest-dev >> >> _______________________________________________ >> pytest-dev mailing list >> pytest-dev at python.org >> https://mail.python.org/mailman/listinfo/pytest-dev > > > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev > > > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev > > > > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: From opensource at ronnypfannschmidt.de Sat Jun 24 09:39:57 2017 From: opensource at ronnypfannschmidt.de (RonnyPfannschmidt) Date: Sat, 24 Jun 2017 15:39:57 +0200 Subject: [pytest-dev] deprecating/removing py.path.local.write due to https://github.com/pytest-dev/py/issues/107 Message-ID: Hi everyone, after investigating the issue i pretty much had to deduce that a horrible mistake happened while doing the python3 port, and the write method was a complete and broken mess ever since working only by accident on ascii inputs any sane fix needs a break in api and so i propose deprecating/removing it as both write_text and write_bytes exist and always do the correct thing and the magic mess method could really use a removal i strictly oppose fixing it with even more hacks ^^ -- Ronny From florian.schulze at gmx.net Sat Jun 24 10:50:41 2017 From: florian.schulze at gmx.net (Florian Schulze) Date: Sat, 24 Jun 2017 16:50:41 +0200 Subject: [pytest-dev] deprecating/removing py.path.local.write due to https://github.com/pytest-dev/py/issues/107 In-Reply-To: References: Message-ID: <17ACC20B-852A-4A6E-B528-4F0293630C33@gmx.net> Could this issue be related, or even be the same? https://github.com/tox-dev/tox/issues/426 Regards, Florian Schulze On 24 Jun 2017, at 15:39, RonnyPfannschmidt wrote: > Hi everyone, > > after investigating the issue i pretty much had to deduce that a > horrible mistake happened while doing the python3 port, and the write > method was a complete and broken mess ever since working only by > accident on ascii inputs > > any sane fix needs a break in api and so i propose deprecating/removing > it as both write_text and write_bytes exist and always do the correct > thing and the magic mess method could really use a removal > > i strictly oppose fixing it with even more hacks ^^ > > -- Ronny > > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev From nicoddemus at gmail.com Sat Jun 24 10:51:50 2017 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Sat, 24 Jun 2017 14:51:50 +0000 Subject: [pytest-dev] deprecating/removing py.path.local.write due to https://github.com/pytest-dev/py/issues/107 In-Reply-To: References: Message-ID: Hi Ronny, Not sure about removing as it will break things that are working even if by accident. I don't see any problem about deprecating it and warning about not using it in new code. Cheers On Sat, Jun 24, 2017 at 10:39 AM RonnyPfannschmidt < opensource at ronnypfannschmidt.de> wrote: > Hi everyone, > > after investigating the issue i pretty much had to deduce that a > horrible mistake happened while doing the python3 port, and the write > method was a complete and broken mess ever since working only by > accident on ascii inputs > > any sane fix needs a break in api and so i propose deprecating/removing > it as both write_text and write_bytes exist and always do the correct > thing and the magic mess method could really use a removal > > i strictly oppose fixing it with even more hacks ^^ > > -- Ronny > > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev > -------------- next part -------------- An HTML attachment was scrubbed... URL: From opensource at ronnypfannschmidt.de Sat Jun 24 11:18:39 2017 From: opensource at ronnypfannschmidt.de (RonnyPfannschmidt) Date: Sat, 24 Jun 2017 17:18:39 +0200 Subject: [pytest-dev] deprecating/removing py.path.local.write due to https://github.com/pytest-dev/py/issues/107 In-Reply-To: <17ACC20B-852A-4A6E-B528-4F0293630C33@gmx.net> References: <17ACC20B-852A-4A6E-B528-4F0293630C33@gmx.net> Message-ID: <04094f74-209a-b3e5-5afc-3799d7066541@ronnypfannschmidt.de> nope, terminalwriter is a different ruin Am 24.06.2017 um 16:50 schrieb Florian Schulze: > Could this issue be related, or even be the same? > https://github.com/tox-dev/tox/issues/426 > > Regards, > Florian Schulze > > > On 24 Jun 2017, at 15:39, RonnyPfannschmidt wrote: > >> Hi everyone, >> >> after investigating the issue i pretty much had to deduce that a >> horrible mistake happened while doing the python3 port, and the write >> method was a complete and broken mess ever since working only by >> accident on ascii inputs >> >> any sane fix needs a break in api and so i propose deprecating/removing >> it as both write_text and write_bytes exist and always do the correct >> thing and the magic mess method could really use a removal >> >> i strictly oppose fixing it with even more hacks ^^ >> >> -- Ronny >> >> _______________________________________________ >> pytest-dev mailing list >> pytest-dev at python.org >> https://mail.python.org/mailman/listinfo/pytest-dev From holger at merlinux.eu Sat Jun 24 13:31:52 2017 From: holger at merlinux.eu (holger krekel) Date: Sat, 24 Jun 2017 19:31:52 +0200 Subject: [pytest-dev] deprecating/removing py.path.local.write due to https://github.com/pytest-dev/py/issues/107 In-Reply-To: References: Message-ID: <20170624173152.GT3686@beto> Hi Bruno, Ronny, On Sat, Jun 24, 2017 at 14:51 +0000, Bruno Oliveira wrote: > Hi Ronny, > > Not sure about removing as it will break things that are working even if by > accident. I don't see any problem about deprecating it and warning about > not using it in new code. ... maybe simply documenting the new methods (write_bytes/write_text i guess) and not mentioning the old methods anymore but not removing/changing them. That has happened several times and i think it's a good approach. I suspect there is quite some code (in tests and outside of tests) that implicitely uses path.local.write so removing it would break a lot of things that currently work even with a messy api. holgr > Cheers > > On Sat, Jun 24, 2017 at 10:39 AM RonnyPfannschmidt < > opensource at ronnypfannschmidt.de> wrote: > > > Hi everyone, > > > > after investigating the issue i pretty much had to deduce that a > > horrible mistake happened while doing the python3 port, and the write > > method was a complete and broken mess ever since working only by > > accident on ascii inputs > > > > any sane fix needs a break in api and so i propose deprecating/removing > > it as both write_text and write_bytes exist and always do the correct > > thing and the magic mess method could really use a removal > > > > i strictly oppose fixing it with even more hacks ^^ > > > > -- Ronny > > > > _______________________________________________ > > pytest-dev mailing list > > pytest-dev at python.org > > https://mail.python.org/mailman/listinfo/pytest-dev > > > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev From nicoddemus at gmail.com Sat Jun 24 14:09:08 2017 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Sat, 24 Jun 2017 18:09:08 +0000 Subject: [pytest-dev] deprecating/removing py.path.local.write due to https://github.com/pytest-dev/py/issues/107 In-Reply-To: <20170624173152.GT3686@beto> References: <20170624173152.GT3686@beto> Message-ID: On Sat, Jun 24, 2017 at 2:31 PM holger krekel wrote: > ... maybe simply documenting the new methods (write_bytes/write_text i > guess) > and not mentioning the old methods anymore but not removing/changing them. > That has happened several times and i think it's a good approach. > I agree, but it might be better to document the `write` method clearly as deprecated/broken and point to `write_bytes` and `write_text` so people looking it up online can see it in the docs. Cheers, Bruno. -------------- next part -------------- An HTML attachment was scrubbed... URL: From opensource at ronnypfannschmidt.de Sat Jun 24 14:26:30 2017 From: opensource at ronnypfannschmidt.de (RonnyPfannschmidt) Date: Sat, 24 Jun 2017 20:26:30 +0200 Subject: [pytest-dev] removing py.path.svn* - since its unmaintained and broken since years Message-ID: hi all, i'd like to remove that code - its broken since years and im not aware of anyone wanting to fix/maintain it as it is now a deadweight i'd like to see it removed -- Ronny From nicoddemus at gmail.com Sat Jun 24 14:27:45 2017 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Sat, 24 Jun 2017 18:27:45 +0000 Subject: [pytest-dev] removing py.path.svn* - since its unmaintained and broken since years In-Reply-To: References: Message-ID: Is it giving maintenance problems? On Sat, Jun 24, 2017 at 3:26 PM RonnyPfannschmidt < opensource at ronnypfannschmidt.de> wrote: > hi all, > > i'd like to remove that code - its broken since years and im not aware > of anyone wanting to fix/maintain it > as it is now a deadweight i'd like to see it removed > > > -- Ronny > > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev > -------------- next part -------------- An HTML attachment was scrubbed... URL: From opensource at ronnypfannschmidt.de Sat Jun 24 15:35:24 2017 From: opensource at ronnypfannschmidt.de (RonnyPfannschmidt) Date: Sat, 24 Jun 2017 21:35:24 +0200 Subject: [pytest-dev] removing py.path.svn* - since its unmaintained and broken since years In-Reply-To: References: Message-ID: <35306252-c9f1-0601-a54c-d94f50b5231c@ronnypfannschmidt.de> its dead code nobody wants to fix, as such its about the same as a unpaid debt incurring interests Am 24.06.2017 um 20:27 schrieb Bruno Oliveira: > Is it giving maintenance problems? > > On Sat, Jun 24, 2017 at 3:26 PM RonnyPfannschmidt > > wrote: > > hi all, > > i'd like to remove that code - its broken since years and im not aware > of anyone wanting to fix/maintain it > as it is now a deadweight i'd like to see it removed > > > -- Ronny > > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev > From nicoddemus at gmail.com Sat Jun 24 15:38:00 2017 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Sat, 24 Jun 2017 19:38:00 +0000 Subject: [pytest-dev] removing py.path.svn* - since its unmaintained and broken since years In-Reply-To: <35306252-c9f1-0601-a54c-d94f50b5231c@ronnypfannschmidt.de> References: <35306252-c9f1-0601-a54c-d94f50b5231c@ronnypfannschmidt.de> Message-ID: Giving that, we could just announce that it is unsupported, leave all tests out (or mark them as xfail). I agree that there's no point having it around if it is giving us headaches, but no point also on removing them if it is working out for some people. On Sat, Jun 24, 2017 at 4:35 PM RonnyPfannschmidt < opensource at ronnypfannschmidt.de> wrote: > its dead code nobody wants to fix, as such its about the same as a > unpaid debt incurring interests > > Am 24.06.2017 um 20:27 schrieb Bruno Oliveira: > > Is it giving maintenance problems? > > > > On Sat, Jun 24, 2017 at 3:26 PM RonnyPfannschmidt > > > > wrote: > > > > hi all, > > > > i'd like to remove that code - its broken since years and im not > aware > > of anyone wanting to fix/maintain it > > as it is now a deadweight i'd like to see it removed > > > > > > -- Ronny > > > > _______________________________________________ > > pytest-dev mailing list > > pytest-dev at python.org > > https://mail.python.org/mailman/listinfo/pytest-dev > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From opensource at ronnypfannschmidt.de Sat Jun 24 15:44:43 2017 From: opensource at ronnypfannschmidt.de (RonnyPfannschmidt) Date: Sat, 24 Jun 2017 21:44:43 +0200 Subject: [pytest-dev] removing py.path.svn* - since its unmaintained and broken since years In-Reply-To: References: <35306252-c9f1-0601-a54c-d94f50b5231c@ronnypfannschmidt.de> Message-ID: <5b72768e-062a-9b0f-6e8e-aa5d237cef8d@ronnypfannschmidt.de> its not working since years, that's why i'd like to remove it Am 24.06.2017 um 21:38 schrieb Bruno Oliveira: > Giving that, we could just announce that it is unsupported, leave all > tests out (or mark them as xfail). > > I agree that there's no point having it around if it is giving us > headaches, but no point also on removing them if it is working out for > some people. > > On Sat, Jun 24, 2017 at 4:35 PM RonnyPfannschmidt > > wrote: > > its dead code nobody wants to fix, as such its about the same as a > unpaid debt incurring interests > > Am 24.06.2017 um 20:27 schrieb Bruno Oliveira: > > Is it giving maintenance problems? > > > > On Sat, Jun 24, 2017 at 3:26 PM RonnyPfannschmidt > > > > >> wrote: > > > > hi all, > > > > i'd like to remove that code - its broken since years and im > not aware > > of anyone wanting to fix/maintain it > > as it is now a deadweight i'd like to see it removed > > > > > > -- Ronny > > > > _______________________________________________ > > pytest-dev mailing list > > pytest-dev at python.org > > > > https://mail.python.org/mailman/listinfo/pytest-dev > > > From nicoddemus at gmail.com Sat Jun 24 16:20:32 2017 From: nicoddemus at gmail.com (Bruno Oliveira) Date: Sat, 24 Jun 2017 20:20:32 +0000 Subject: [pytest-dev] removing py.path.svn* - since its unmaintained and broken since years In-Reply-To: <5b72768e-062a-9b0f-6e8e-aa5d237cef8d@ronnypfannschmidt.de> References: <35306252-c9f1-0601-a54c-d94f50b5231c@ronnypfannschmidt.de> <5b72768e-062a-9b0f-6e8e-aa5d237cef8d@ronnypfannschmidt.de> Message-ID: Oh right, I think the tests have been skipped for some time now right? In that case I guess removing the functionality and test cases might make some sense. On Sat, Jun 24, 2017 at 4:44 PM RonnyPfannschmidt < opensource at ronnypfannschmidt.de> wrote: > its not working since years, that's why i'd like to remove it > > Am 24.06.2017 um 21:38 schrieb Bruno Oliveira: > > Giving that, we could just announce that it is unsupported, leave all > > tests out (or mark them as xfail). > > > > I agree that there's no point having it around if it is giving us > > headaches, but no point also on removing them if it is working out for > > some people. > > > > On Sat, Jun 24, 2017 at 4:35 PM RonnyPfannschmidt > > > > wrote: > > > > its dead code nobody wants to fix, as such its about the same as a > > unpaid debt incurring interests > > > > Am 24.06.2017 um 20:27 schrieb Bruno Oliveira: > > > Is it giving maintenance problems? > > > > > > On Sat, Jun 24, 2017 at 3:26 PM RonnyPfannschmidt > > > > > > > > >> wrote: > > > > > > hi all, > > > > > > i'd like to remove that code - its broken since years and im > > not aware > > > of anyone wanting to fix/maintain it > > > as it is now a deadweight i'd like to see it removed > > > > > > > > > -- Ronny > > > > > > _______________________________________________ > > > pytest-dev mailing list > > > pytest-dev at python.org > > > > > > https://mail.python.org/mailman/listinfo/pytest-dev > > > > > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From holger at merlinux.eu Sun Jun 25 03:29:58 2017 From: holger at merlinux.eu (holger krekel) Date: Sun, 25 Jun 2017 09:29:58 +0200 Subject: [pytest-dev] removing py.path.svn* - since its unmaintained and broken since years In-Reply-To: References: <35306252-c9f1-0601-a54c-d94f50b5231c@ronnypfannschmidt.de> <5b72768e-062a-9b0f-6e8e-aa5d237cef8d@ronnypfannschmidt.de> Message-ID: <20170625072958.GU3686@beto> On Sat, Jun 24, 2017 at 20:20 +0000, Bruno Oliveira wrote: > Oh right, I think the tests have been skipped for some time now right? > > In that case I guess removing the functionality and test cases might make > some sense. all testing/path/test_svn*.py files pass for me (you need to install the "svn" command line version). It's actually kind of astonishing that it is working for years without much breakage ... Ronny, i guess you'd like to have a nicer leaner less messy base than what "py" provides for pytest -- and i kind of agree and think it'd be good to continue moving code out of py and directly into pytest. path.local() is probably one of the bigger ones now that py.code's functionality is part of pytest. So all in all i suggest to consider leaving "py" mostly alone and move towards removing the dependency alltogether. holger > On Sat, Jun 24, 2017 at 4:44 PM RonnyPfannschmidt < > opensource at ronnypfannschmidt.de> wrote: > > > its not working since years, that's why i'd like to remove it > > > > Am 24.06.2017 um 21:38 schrieb Bruno Oliveira: > > > Giving that, we could just announce that it is unsupported, leave all > > > tests out (or mark them as xfail). > > > > > > I agree that there's no point having it around if it is giving us > > > headaches, but no point also on removing them if it is working out for > > > some people. > > > > > > On Sat, Jun 24, 2017 at 4:35 PM RonnyPfannschmidt > > > > > > wrote: > > > > > > its dead code nobody wants to fix, as such its about the same as a > > > unpaid debt incurring interests > > > > > > Am 24.06.2017 um 20:27 schrieb Bruno Oliveira: > > > > Is it giving maintenance problems? > > > > > > > > On Sat, Jun 24, 2017 at 3:26 PM RonnyPfannschmidt > > > > > > > > > > > > >> wrote: > > > > > > > > hi all, > > > > > > > > i'd like to remove that code - its broken since years and im > > > not aware > > > > of anyone wanting to fix/maintain it > > > > as it is now a deadweight i'd like to see it removed > > > > > > > > > > > > -- Ronny > > > > > > > > _______________________________________________ > > > > pytest-dev mailing list > > > > pytest-dev at python.org > > > > > > > > https://mail.python.org/mailman/listinfo/pytest-dev > > > > > > > > > > _______________________________________________ > pytest-dev mailing list > pytest-dev at python.org > https://mail.python.org/mailman/listinfo/pytest-dev From flub at devork.be Sun Jun 25 05:04:32 2017 From: flub at devork.be (Floris Bruynooghe) Date: Sun, 25 Jun 2017 11:04:32 +0200 Subject: [pytest-dev] deprecating/removing py.path.local.write due to https://github.com/pytest-dev/py/issues/107 In-Reply-To: References: <20170624173152.GT3686@beto> Message-ID: On 24 June 2017 at 20:09, Bruno Oliveira wrote: > > > On Sat, Jun 24, 2017 at 2:31 PM holger krekel wrote: >> >> ... maybe simply documenting the new methods (write_bytes/write_text i >> guess) >> and not mentioning the old methods anymore but not removing/changing them. >> That has happened several times and i think it's a good approach. > > > I agree, but it might be better to document the `write` method clearly as > deprecated/broken and point to `write_bytes` and `write_text` so people > looking it up online can see it in the docs. +1