[py-svn] r60141 - in py/trunk/py: code code/testing test

[pedronis at codespeak.net]

Author: pedronis
Date: Tue Nov 25 19:34:47 2008
New Revision: 60141

Modified:
   py/trunk/py/code/code.py
   py/trunk/py/code/source.py
   py/trunk/py/code/testing/test_excinfo.py
   py/trunk/py/code/testing/test_source.py
   py/trunk/py/code/traceback2.py
   py/trunk/py/test/pycollect.py
Log:
refactor things such that all fallbacks to inspect.get/findsource happen in helpers in source.py



Modified: py/trunk/py/code/code.py
==============================================================================
--- py/trunk/py/code/code.py	(original)
+++ py/trunk/py/code/code.py	Tue Nov 25 19:34:47 2008
@@ -1,4 +1,5 @@
 import py
+from py.__.code import source
 
 class Code(object):
     """ wrapper around Python code objects """
@@ -75,14 +76,8 @@
     def fullsource(self):
         """ return a py.code.Source object for the full source file of the code
         """
-        fn = self.raw.co_filename
-        try:
-            return fn.__source__
-        except AttributeError:
-            path = self.path
-            if not isinstance(path, py.path.local):
-                return None
-            return py.code.Source(self.path.read(mode="rU"))
+        full, _ = source.findsource(self.raw)
+        return full
     fullsource = property(fullsource, None, None,
                           "full source containing this code object")
     

Modified: py/trunk/py/code/source.py
==============================================================================
--- py/trunk/py/code/source.py	(original)
+++ py/trunk/py/code/source.py	Tue Nov 25 19:34:47 2008
@@ -223,6 +223,28 @@
 class MyStr(str):
     """ custom string which allows to add attributes. """
 
+def findsource(obj):
+    if hasattr(obj, 'func_code'):
+        obj = obj.func_code
+    elif hasattr(obj, 'f_code'):
+        obj = obj.f_code
+    try:
+        fullsource = obj.co_filename.__source__
+    except AttributeError:
+        try:
+            sourcelines, lineno = py.std.inspect.findsource(obj)
+        except (KeyboardInterrupt, SystemExit):
+            raise
+        except:
+            return None, None
+        source = Source()
+        source.lines = map(str.rstrip, sourcelines)
+        return source, lineno
+    else:
+        lineno = obj.co_firstlineno - 1        
+        return fullsource, lineno
+
+
 def getsource(obj, **kwargs):
     if hasattr(obj, 'func_code'):
         obj = obj.func_code
@@ -240,7 +262,7 @@
     else:
         lineno = obj.co_firstlineno - 1
         end = fullsource.getblockend(lineno)
-        return fullsource[lineno:end+1]
+        return Source(fullsource[lineno:end+1], deident=True)
 
 
 def deindent(lines, offset=None):

Modified: py/trunk/py/code/testing/test_excinfo.py
==============================================================================
--- py/trunk/py/code/testing/test_excinfo.py	(original)
+++ py/trunk/py/code/testing/test_excinfo.py	Tue Nov 25 19:34:47 2008
@@ -329,7 +329,7 @@
             firstlineno = 5
 
             def fullsource(self):
-                raise fail
+                return None
             fullsource = property(fullsource)
 
         class FakeFrame(object):

Modified: py/trunk/py/code/testing/test_source.py
==============================================================================
--- py/trunk/py/code/testing/test_source.py	(original)
+++ py/trunk/py/code/testing/test_source.py	Tue Nov 25 19:34:47 2008
@@ -314,3 +314,43 @@
     path.write(source)
     s2 = py.code.Source(tmpdir.join("a.py").pyimport().A)
     assert str(source).strip() == str(s2).strip()
+
+if True:
+    def x():
+        pass
+
+def test_getsource_fallback():
+    from py.__.code.source import getsource
+    expected = """def x():
+    pass"""
+    src = getsource(x)
+    assert src == expected
+
+def test_getsource___source__():
+    from py.__.code.source import getsource
+    x = py.code.compile("""if 1:
+    def x():
+        pass
+""")
+
+    expected = """def x():
+    pass"""
+    src = getsource(x)
+    assert src == expected
+
+def test_findsource_fallback():
+    from py.__.code.source import findsource
+    src, lineno = findsource(x)
+    assert 'test_findsource_simple' in str(src)
+    assert src[lineno] == '    def x():'
+
+def test_findsource___source__():
+    from py.__.code.source import findsource
+    x = py.code.compile("""if 1:
+    def x():
+        pass
+""")
+        
+    src, lineno = findsource(x)
+    assert 'if 1:' in str(src)
+    assert src[lineno] == '    def x():'

Modified: py/trunk/py/code/traceback2.py
==============================================================================
--- py/trunk/py/code/traceback2.py	(original)
+++ py/trunk/py/code/traceback2.py	Tue Nov 25 19:34:47 2008
@@ -51,19 +51,9 @@
 
     def getsource(self): 
         """ return failing source code. """
-        try:
-            source = self.frame.code.fullsource
-        except (IOError, py.error.ENOENT):
-            return None
+        source = self.frame.code.fullsource
         if source is None:
-            try:
-                sourcelines, lineno = py.std.inspect.findsource(self.frame.code.raw)
-            except (KeyboardInterrupt, SystemExit):
-                raise
-            except:
-                return None
-            source = py.code.Source()
-            source.lines = map(str.rstrip, sourcelines)
+            return None
         start = self.getfirstlinesource()
         end = self.lineno
         try:

Modified: py/trunk/py/test/pycollect.py
==============================================================================
--- py/trunk/py/test/pycollect.py	(original)
+++ py/trunk/py/test/pycollect.py	Tue Nov 25 19:34:47 2008
@@ -18,6 +18,7 @@
 """ 
 import py
 from py.__.test.collect import configproperty, warnoldcollect
+from py.__.code.source import findsource
 
 class PyobjMixin(object):
     def obj(): 
@@ -68,7 +69,7 @@
             fspath = fn and py.path.local(fn) or None
             if fspath:
                 try:
-                    lines, lineno = py.std.inspect.findsource(self.obj)
+                    _, lineno = findsource(self.obj)
                 except IOError:
                     lineno = None
             else: