[PyPy-issue] [issue639] ASTBuilder's handling of lineno & col_offset is not compliant with CPython 2.7

Armin Rigo pypy-dev-issue at codespeak.net
Thu Feb 24 16:28:06 CET 2011


Armin Rigo <armin.rigo at gmail.com> added the comment:

Looks good, checked in now.  Note that we don't usually *add* many tests to a
CPython test file; the directory 'modified-2.7.2' is meant to fix or generalize
existing tests.  Instead, we put new tests somewhere in pypy/*, but using a
different style -- which I see can be the problem in this case, as you really
just want to add more tests in the same style.  Well, it's fine I suppose, as
long as the tests also pass on CPython 2.7.

Down from 10 to 9 failures in test_ast.py :-/

_______________________________________________________
PyPy development tracker <pypy-dev-issue at codespeak.net>
<https://codespeak.net/issue/pypy-dev/issue639>
_______________________________________________________



More information about the Pypy-issue mailing list