[pypy-dev] set with instances very slow from 1.8 to 1.9

David Edelsohn dje.gcc at gmail.com
Tue Jun 19 19:47:52 CEST 2012


On Tue, Jun 19, 2012 at 12:33 PM, Lukas Diekmann
<Lukas.Diekmann at uni-duesseldorf.de> wrote:
> Hi,
>
> you are right. Union between two sets of objects are slower, since we
> introduced mechanics to make set operations with primitive types (e.g. ints)
> faster.
> The problem was that a fastpath was removed in that process. I readded it.
> Union/Update with sets of objects should be fast again in the future.
>
> Thank you for figuring that out. Your program was very helpful.
>
> Commit: https://bitbucket.org/pypy/pypy/changeset/452bb2805140

Lukas,

Should the restored code include a comment about why the fast path is
useful for non-primitive types? Or a new test to ensure the optimal IR
is generated?

- David


More information about the pypy-dev mailing list