[pypy-dev] PyPy Assembler SQRT Patch

[Alex Gaynor]

On Tue, May 3, 2011 at 10:30 AM, Armin Rigo <arigo at tunes.org> wrote:

> Hi,
>
> On Tue, May 3, 2011 at 1:20 PM, Maciej Fijalkowski <fijall at gmail.com>
> wrote:
> > Sorry it took so long to review, long weekend and whatnot. The test
> > for x86 backend actually fails for -1.0 on 64bit. Can you
> > reproduce/deny?
>
> I fixed it, it was really a bug about FINISH(ConstFloat(...)).  But
> the patch, at least as applied now, does not have the intended effect;
> SQRTSD is never generated because ll_math_sqrt() is called with a
> residual call.  Joe, can you fix it?  I can try to if you don't have
> the time.
>
>
> A bientôt,
>
> Armin.
> _______________________________________________
> pypy-dev at codespeak.net
> http://codespeak.net/mailman/listinfo/pypy-dev
>

Another thing is it would be useful to test that the SQRTSD is generated, I
don't know a good way to do that though.

Alex

-- 
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/pypy-dev/attachments/20110503/a767bf13/attachment.html>