[pypy-dev] [COMMENT] Pull request #8 for pypy/pypy: added numpy.sort, tests, and docstring for numpy.array.sort

[Laura Creighton]

I'd like it if the comments on pull requests came with the name
of the person making the request, in this case yasirs.  Is this
something we can do on our end, (I don't think so) or something
we need to ask Bitbucket to change?

Laura

In a message of Sun, 28 Aug 2011 06:32:52 -0000, Bitbucket writes:
>New comment on pull request:
>
>https://bitbucket.org/pypy/pypy/pull-request/8/added-numpysort-tests-and-
>do=
>cstring-for#comment-35
>
>Alex Gaynor (alex_gaynor) said:
>
>Sorry, here are the issues I saw:
>
>* It would need to be rewritten after the merge of the dtypes branch (whi
>ch=
> rewrites most of everything :P)
>* It doesn't work with any of the virtual arrays (I'm surprised it even t
>ra=
>nslates)
>* It looks like a pretty simple quicksort, which means it can have perfor
>ma=
>nce issues (I'd like to try using the TimSort we already have)
>* There are stylistic issues, semicolons, and excessive parens mostly.
>
>--
>This is a pull request comment notification from bitbucket.org.
>You are receiving this either because you are participating
>in a pull request, or you are following it.