[pypy-commit] pypy default: Remove @xfail on these two Windows tests. One of them passes right now (and so

arigo pypy.commits at gmail.com
Tue Jun 18 04:56:10 EDT 2019


Author: Armin Rigo <arigo at tunes.org>
Branch: 
Changeset: r96817:6d85d83cc17b
Date: 2019-06-18 10:55 +0200
http://bitbucket.org/pypy/pypy/changeset/6d85d83cc17b/

Log:	Remove @xfail on these two Windows tests. One of them passes right
	now (and so it ends up as a failure). I don't see a reason for the
	other to be @xfail except because PyPy is buggy, and in this case
	it's better to see this (real) failure.

diff --git a/lib-python/2.7/ctypes/test/test_loading.py b/lib-python/2.7/ctypes/test/test_loading.py
--- a/lib-python/2.7/ctypes/test/test_loading.py
+++ b/lib-python/2.7/ctypes/test/test_loading.py
@@ -2,7 +2,7 @@
 import sys, unittest
 import os
 from ctypes.util import find_library
-from ctypes.test import is_resource_enabled, xfail
+from ctypes.test import is_resource_enabled
 
 libc_name = None
 if os.name == "nt":
@@ -80,7 +80,6 @@
 
         self.assertRaises(AttributeError, dll.__getitem__, 1234)
 
-    @xfail
     @unittest.skipUnless(os.name == "nt", 'Windows-specific test')
     def test_1703286_A(self):
         from _ctypes import LoadLibrary, FreeLibrary
@@ -92,7 +91,6 @@
         handle = LoadLibrary("advapi32")
         FreeLibrary(handle)
 
-    @xfail
     @unittest.skipUnless(os.name == "nt", 'Windows-specific test')
     def test_1703286_B(self):
         # Since on winXP 64-bit advapi32 loads like described


More information about the pypy-commit mailing list