[pypy-commit] pypy default: skip test that crashes on old zlib version

mattip pypy.commits at gmail.com
Mon Feb 11 12:21:12 EST 2019


Author: Matti Picus <matti.picus at gmail.com>
Branch: 
Changeset: r95943:c080e584813c
Date: 2019-02-11 14:02 +0200
http://bitbucket.org/pypy/pypy/changeset/c080e584813c/

Log:	skip test that crashes on old zlib version

diff --git a/pypy/module/zlib/test/test_zlib.py b/pypy/module/zlib/test/test_zlib.py
--- a/pypy/module/zlib/test/test_zlib.py
+++ b/pypy/module/zlib/test/test_zlib.py
@@ -3,17 +3,18 @@
 """
 
 import sys
+import py
 try:
     import zlib
 except ImportError:
-    import py; py.test.skip("no zlib module on this host Python")
+    py.test.skip("no zlib module on this host Python")
 
 from pypy.interpreter.gateway import interp2app
 try:
     from pypy.module.zlib import interp_zlib
     from rpython.rlib import rzlib
 except ImportError:
-    import py; py.test.skip("no zlib C library on this machine")
+    py.test.skip("no zlib C library on this machine")
 
 def test_unsigned_to_signed_32bit():
     assert interp_zlib.unsigned_to_signed_32bit(123) == 123
@@ -344,6 +345,7 @@
 
         assert (d1 + from_copy) == (d1 + from_compressor)
 
+    @py.test.mark.skipif(rzlib.ZLIB_VERSION == '1.2.8', reason='does not error check')
     def test_cannot_copy_compressor_with_stream_in_inconsistent_state(self):
         if self.runappdirect: skip("can't run with -A")
         compressor = self.zlib.compressobj()


More information about the pypy-commit mailing list