[pypy-commit] pypy default: Document the problem (thanks njs)

arigo pypy.commits at gmail.com
Thu Jan 26 03:52:49 EST 2017


Author: Armin Rigo <arigo at tunes.org>
Branch: 
Changeset: r89779:1042ceb32763
Date: 2017-01-26 09:51 +0100
http://bitbucket.org/pypy/pypy/changeset/1042ceb32763/

Log:	Document the problem (thanks njs)

diff --git a/rpython/rlib/rsiphash.py b/rpython/rlib/rsiphash.py
--- a/rpython/rlib/rsiphash.py
+++ b/rpython/rlib/rsiphash.py
@@ -21,6 +21,9 @@
 # that as easily because many details may rely on getting the same hash
 # value before and after translation.  We can, however, pick a random
 # seed once per translation, which should already be quite good.
+#
+# XXX no, it is not: e.g. all Ubuntu installations of the same Ubuntu
+# would get the same seed.  That's not good enough.
 
 @not_rpython
 def select_random_seed():


More information about the pypy-commit mailing list