[pypy-commit] pypy py3.5: Using check_impl_detail() like this is not following the spirit of

[arigo]

Author: Armin Rigo <arigo at tunes.org>
Branch: py3.5
Changeset: r88495:818fb73d805d
Date: 2016-11-20 16:54 +0100
http://bitbucket.org/pypy/pypy/changeset/818fb73d805d/

Log:	Using check_impl_detail() like this is not following the spirit of
	check_impl_detail(), which should be: "if false, avoid checking some
	detail", not "if false, check that the value is really different".

	Removed anyway, as it seems pypy gives the same answer as cpython
	nowadays.

diff --git a/lib-python/3/test/test_index.py b/lib-python/3/test/test_index.py
--- a/lib-python/3/test/test_index.py
+++ b/lib-python/3/test/test_index.py
@@ -66,10 +66,7 @@
         direct_index = my_int.__index__()
         operator_index = operator.index(my_int)
         self.assertEqual(direct_index, 8)
-        if support.check_impl_detail():
-            self.assertEqual(operator_index, 7)
-        else:
-            self.assertEqual(operator_index, 8)
+        self.assertEqual(operator_index, 7)
         # Both results should be of exact type int.
         self.assertIs(type(direct_index), int)
         #self.assertIs(type(operator_index), int)
@@ -90,10 +87,7 @@
 
         bad_int = BadInt2()
         n = operator.index(bad_int)
-        if support.check_impl_detail():
-            self.assertEqual(n, 0)
-        else:
-            self.assertEqual(n, 1)
+        self.assertEqual(n, 0)
 
 
 class SeqTestCase: