[pypy-commit] pypy default: Make it clearer if dlopenflags tests ran.

[habnabit]

Author: Aaron Gallagher <habnabit at google.com>
Branch: 
Changeset: r85087:10f76560e949
Date: 2016-06-08 16:26 -0700
http://bitbucket.org/pypy/pypy/changeset/10f76560e949/

Log:	Make it clearer if dlopenflags tests ran.

	Instead of silently ignoring the test, skip it.

diff --git a/pypy/module/sys/test/test_sysmodule.py b/pypy/module/sys/test/test_sysmodule.py
--- a/pypy/module/sys/test/test_sysmodule.py
+++ b/pypy/module/sys/test/test_sysmodule.py
@@ -445,14 +445,16 @@
 
     def test_dlopenflags(self):
         import sys
-        if hasattr(sys, "setdlopenflags"):
-            assert hasattr(sys, "getdlopenflags")
-            raises(TypeError, sys.getdlopenflags, 42)
-            oldflags = sys.getdlopenflags()
-            raises(TypeError, sys.setdlopenflags)
-            sys.setdlopenflags(oldflags+1)
-            assert sys.getdlopenflags() == oldflags+1
-            sys.setdlopenflags(oldflags)
+        if not hasattr(sys, "setdlopenflags"):
+            skip('dlopen flags are not available.')
+
+        assert hasattr(sys, "getdlopenflags")
+        raises(TypeError, sys.getdlopenflags, 42)
+        oldflags = sys.getdlopenflags()
+        raises(TypeError, sys.setdlopenflags)
+        sys.setdlopenflags(oldflags+1)
+        assert sys.getdlopenflags() == oldflags+1
+        sys.setdlopenflags(oldflags)
 
     def test_refcount(self):
         import sys
@@ -610,7 +612,7 @@
 class AppTestSysSettracePortedFromCpython(object):
     def test_sys_settrace(self):
         import sys
-        
+
         class Tracer:
             def __init__(self):
                 self.events = []