[pypy-commit] pypy default: Skip PTY tests that hang forever on kFreeBSD

stefanor pypy.commits at gmail.com
Mon Apr 4 19:46:22 EDT 2016


Author: Stefano Rivera <stefano at rivera.za.net>
Branch: 
Changeset: r83514:9059c53718bb
Date: 2016-04-04 16:40 -0700
http://bitbucket.org/pypy/pypy/changeset/9059c53718bb/

Log:	Skip PTY tests that hang forever on kFreeBSD

	I don't know if this is expected behaviour. These all look skipped
	on darwin, which is presumably similar to FreeBSD, here.

	https://bugs.debian.org/742965 also seems relevant

diff --git a/pypy/module/_file/test/test_file.py b/pypy/module/_file/test/test_file.py
--- a/pypy/module/_file/test/test_file.py
+++ b/pypy/module/_file/test/test_file.py
@@ -285,6 +285,8 @@
             from posix import openpty, fdopen, write, close
         except ImportError:
             skip('no openpty on this platform')
+        if 'gnukfreebsd' in sys.platform:
+            skip('close() hangs forever on kFreeBSD')
         read_fd, write_fd = openpty()
         write(write_fd, 'Abc\n')
         close(write_fd)
diff --git a/pypy/module/test_lib_pypy/pyrepl/test_bugs.py b/pypy/module/test_lib_pypy/pyrepl/test_bugs.py
--- a/pypy/module/test_lib_pypy/pyrepl/test_bugs.py
+++ b/pypy/module/test_lib_pypy/pyrepl/test_bugs.py
@@ -46,7 +46,8 @@
     read_spec(spec, HistoricalTestReader)
 
 
- at pytest.mark.skipif("os.name != 'posix' or 'darwin' in sys.platform")
+ at pytest.mark.skipif("os.name != 'posix' or 'darwin' in sys.platform or "
+                    "'kfreebsd' in sys.platform")
 def test_signal_failure(monkeypatch):
     import os
     import pty
diff --git a/pypy/module/test_lib_pypy/pyrepl/test_readline.py b/pypy/module/test_lib_pypy/pyrepl/test_readline.py
--- a/pypy/module/test_lib_pypy/pyrepl/test_readline.py
+++ b/pypy/module/test_lib_pypy/pyrepl/test_readline.py
@@ -1,7 +1,8 @@
 import pytest
 
 
- at pytest.mark.skipif("os.name != 'posix' or 'darwin' in sys.platform")
+ at pytest.mark.skipif("os.name != 'posix' or 'darwin' in sys.platform or "
+                    "'kfreebsd' in sys.platform")
 def test_raw_input():
     import os
     import pty


More information about the pypy-commit mailing list