[pypy-commit] pypy cpyext-gc-support: Comments

[arigo]

Author: Armin Rigo <arigo at tunes.org>
Branch: cpyext-gc-support
Changeset: r80212:905a7c2186e0
Date: 2015-10-14 18:40 +0200
http://bitbucket.org/pypy/pypy/changeset/905a7c2186e0/

Log:	Comments

diff --git a/pypy/doc/discussion/rawrefcount.rst b/pypy/doc/discussion/rawrefcount.rst
--- a/pypy/doc/discussion/rawrefcount.rst
+++ b/pypy/doc/discussion/rawrefcount.rst
@@ -107,7 +107,6 @@
 
 A few special types need to be reflected both as PyPy objects and
 PyObjects.  For now we assume that these are large and mostly
-immutable, like <type> objects.  They should be linked in the O list,
-and we'll ignore the issues of deallocation ordering for them.  (Also,
-W_TypeObject can have a back-reference field like
-W_CPyExtPlaceHolderObject.)
+immutable, like <type> objects.  They should be linked in some mixture
+of the P list and the O list.  Likely, the P list with an extra flag
+that says "_Py_Dealloc must be invoked".
diff --git a/pypy/module/cpyext/import_.py b/pypy/module/cpyext/import_.py
--- a/pypy/module/cpyext/import_.py
+++ b/pypy/module/cpyext/import_.py
@@ -74,6 +74,7 @@
     w_mod = check_sys_modules_w(space, modulename)
     if not w_mod or space.is_w(w_mod, space.w_None):
         w_mod = Module(space, space.wrap(modulename))
+        XXX - "insert it into sys.modules!"
     return borrow_from(None, w_mod)
 
 @cpython_api([], PyObject)