[pypy-commit] pypy stmgc-c8: fix horrible performance

Raemi noreply at buildbot.pypy.org
Fri Nov 27 06:32:39 EST 2015


Author: Remi Meier <remi.meier at gmail.com>
Branch: stmgc-c8
Changeset: r80996:44379f7fa2ab
Date: 2015-11-27 12:21 +0100
http://bitbucket.org/pypy/pypy/changeset/44379f7fa2ab/

Log:	fix horrible performance

diff --git a/rpython/translator/stm/inevitable.py b/rpython/translator/stm/inevitable.py
--- a/rpython/translator/stm/inevitable.py
+++ b/rpython/translator/stm/inevitable.py
@@ -206,8 +206,10 @@
             else:
                 assert op not in self.turn_inevitable_ops
             #
-            if self.break_analyzer.analyze(op):
-                # possible TX break in op
+            # check breaking ops here to be safe (e.g. if there
+            # was an op that turns inevitable, but also breaks)
+            if inevitable and self.break_analyzer.analyze(op):
+                # only check if inev, otherwise performance is horrible
                 inevitable = False
         #
         return inevitable


More information about the pypy-commit mailing list