[pypy-commit] pypy py3k: Fix a test, like in 2.7 branch

amauryfa noreply at buildbot.pypy.org
Sat Feb 14 12:53:02 CET 2015


Author: Amaury Forgeot d'Arc <amauryfa at gmail.com>
Branch: py3k
Changeset: r75865:dbd11cc004f0
Date: 2015-02-11 01:13 +0100
http://bitbucket.org/pypy/pypy/changeset/dbd11cc004f0/

Log:	Fix a test, like in 2.7 branch

diff --git a/lib-python/3/test/test_collections.py b/lib-python/3/test/test_collections.py
--- a/lib-python/3/test/test_collections.py
+++ b/lib-python/3/test/test_collections.py
@@ -635,7 +635,12 @@
             def __repr__(self):
                 return "MySet(%s)" % repr(list(self))
         s = MySet([5,43,2,1])
-        self.assertEqual(s.pop(), 1)
+        # changed from CPython: it was "s.pop() == 1" but I see
+        # nothing that guarantees a particular order here.  In the
+        # 'all_ordered_dicts' branch of PyPy (or with OrderedDict
+        # instead of sets), it consistently returns 5, but this test
+        # should not rely on this or any other order.
+        self.assert_(s.pop() in [5,43,2,1])
 
     def test_issue8750(self):
         empty = WithSet()


More information about the pypy-commit mailing list