[pypy-commit] pypy vmprof2: move those ops to no-side-effect (why they had side effects in the first place?)

fijal noreply at buildbot.pypy.org
Fri Apr 24 15:04:04 CEST 2015


Author: Maciej Fijalkowski <fijall at gmail.com>
Branch: vmprof2
Changeset: r76920:329a83be5923
Date: 2015-04-24 15:04 +0200
http://bitbucket.org/pypy/pypy/changeset/329a83be5923/

Log:	move those ops to no-side-effect (why they had side effects in the
	first place?)

diff --git a/rpython/jit/metainterp/resoperation.py b/rpython/jit/metainterp/resoperation.py
--- a/rpython/jit/metainterp/resoperation.py
+++ b/rpython/jit/metainterp/resoperation.py
@@ -503,6 +503,10 @@
     'MARK_OPAQUE_PTR/1b',
     # this one has no *visible* side effect, since the virtualizable
     # must be forced, however we need to execute it anyway
+    'DEBUG_MERGE_POINT/*',      # debugging only
+    'ENTER_PORTAL_FRAME/2',     # debugging only
+    'LEAVE_PORTAL_FRAME/1',     # debugging only
+    'JIT_DEBUG/*',              # debugging only
     '_NOSIDEEFFECT_LAST', # ----- end of no_side_effect operations -----
 
     'INCREMENT_DEBUG_COUNTER/1',
@@ -521,10 +525,6 @@
     'UNICODESETITEM/3',
     'COND_CALL_GC_WB/1d',       # [objptr] (for the write barrier)
     'COND_CALL_GC_WB_ARRAY/2d', # [objptr, arrayindex] (write barr. for array)
-    'DEBUG_MERGE_POINT/*',      # debugging only
-    'ENTER_PORTAL_FRAME/2',     # debugging only
-    'LEAVE_PORTAL_FRAME/1',     # debugging only
-    'JIT_DEBUG/*',              # debugging only
     'VIRTUAL_REF_FINISH/2',   # removed before it's passed to the backend
     'COPYSTRCONTENT/5',       # src, dst, srcstart, dststart, length
     'COPYUNICODECONTENT/5',


More information about the pypy-commit mailing list