[pypy-commit] pypy default: add a remark about SoftFloatCallBuilder

arigo noreply at buildbot.pypy.org
Mon Sep 1 17:20:00 CEST 2014


Author: Armin Rigo <arigo at tunes.org>
Branch: 
Changeset: r73272:f27cde19678a
Date: 2014-09-01 17:19 +0200
http://bitbucket.org/pypy/pypy/changeset/f27cde19678a/

Log:	add a remark about SoftFloatCallBuilder

diff --git a/rpython/jit/backend/arm/callbuilder.py b/rpython/jit/backend/arm/callbuilder.py
--- a/rpython/jit/backend/arm/callbuilder.py
+++ b/rpython/jit/backend/arm/callbuilder.py
@@ -173,6 +173,13 @@
 
 
 class SoftFloatCallBuilder(ARMCallbuilder):
+    # XXX Maybe we could kill this class and unify the remaining two
+    # XXX classes, by carefully checking if all methods here are doing
+    # XXX the exact same thing as the methods from HardFloatCallBuilder,
+    # XXX but simply forcing all BoxFloat arguments to be longlongs
+    # XXX (i.e. ignoring 'f' in favour of 'L'), and the same with
+    # XXX single-float arguments (ignoring 'S' in favour of 'i');
+    # XXX and the same for the return value.
 
     def get_result_locs(self):
         if self.resloc is None:


More information about the pypy-commit mailing list