[pypy-commit] pypy release-2.3.x: Revert partially d95d0c9bb988, because it was bogus. My fault for

arigo noreply at buildbot.pypy.org
Wed May 7 18:31:46 CEST 2014


Author: Armin Rigo <arigo at tunes.org>
Branch: release-2.3.x
Changeset: r71391:8eb9af65507b
Date: 2014-05-07 15:36 +0200
http://bitbucket.org/pypy/pypy/changeset/8eb9af65507b/

Log:	Revert partially d95d0c9bb988, because it was bogus. My fault for
	doing a quick fix without writing tests: now I don't have any more a
	translation where this fix helped.

diff --git a/rpython/translator/c/gcc/trackgcroot.py b/rpython/translator/c/gcc/trackgcroot.py
--- a/rpython/translator/c/gcc/trackgcroot.py
+++ b/rpython/translator/c/gcc/trackgcroot.py
@@ -296,10 +296,11 @@
 
         # trim: instructions with no framesize are removed from self.insns,
         # and from the 'previous_insns' lists
-        assert hasattr(self.insns[0], 'framesize')
-        old = self.insns[1:]
-        del self.insns[1:]
-        for insn in old:
+        if 0:    # <- XXX disabled because it seems bogus, investigate more
+          assert hasattr(self.insns[0], 'framesize')
+          old = self.insns[1:]
+          del self.insns[1:]
+          for insn in old:
             if hasattr(insn, 'framesize'):
                 self.insns.append(insn)
                 insn.previous_insns = [previnsn for previnsn in insn.previous_insns


More information about the pypy-commit mailing list