[pypy-commit] pypy default: variable declaration must precede usage in c

mattip noreply at buildbot.pypy.org
Sun Mar 30 23:25:49 CEST 2014


Author: Matti Picus <matti.picus at gmail.com>
Branch: 
Changeset: r70339:c4a26971721e
Date: 2014-03-31 00:18 +0300
http://bitbucket.org/pypy/pypy/changeset/c4a26971721e/

Log:	variable declaration must precede usage in c

diff --git a/pypy/module/cpyext/test/test_pyerrors.py b/pypy/module/cpyext/test/test_pyerrors.py
--- a/pypy/module/cpyext/test/test_pyerrors.py
+++ b/pypy/module/cpyext/test/test_pyerrors.py
@@ -238,8 +238,8 @@
         module = self.import_extension('foo', [
                 ("set_from_errno", "METH_NOARGS",
                  '''
+                 PyObject *filenameObject = PyString_FromString("/path/to/file");
                  errno = EBADF;
-                 PyObject *filenameObject = PyString_FromString("/path/to/file");
                  PyErr_SetFromErrnoWithFilenameObject(PyExc_OSError, filenameObject);
                  Py_DECREF(filenameObject);
                  return NULL;
@@ -257,8 +257,8 @@
         module = self.import_extension('foo', [
                 ("set_from_errno", "METH_NOARGS",
                  '''
+                 PyObject *intObject = PyInt_FromLong(3);
                  errno = EBADF;
-                 PyObject *intObject = PyInt_FromLong(3);
                  PyErr_SetFromErrnoWithFilenameObject(PyExc_OSError, intObject);
                  Py_DECREF(intObject);
                  return NULL;
@@ -276,8 +276,8 @@
         module = self.import_extension('foo', [
                 ("set_from_errno", "METH_NOARGS",
                  '''
+                 PyObject *lst = Py_BuildValue("[iis]", 1, 2, "three");
                  errno = EBADF;
-                 PyObject *lst = Py_BuildValue("[iis]", 1, 2, "three");
                  PyErr_SetFromErrnoWithFilenameObject(PyExc_OSError, lst);
                  Py_DECREF(lst);
                  return NULL;
@@ -295,8 +295,8 @@
         module = self.import_extension('foo', [
                 ("set_from_errno", "METH_NOARGS",
                  '''
+                 PyObject *tuple = Py_BuildValue("(iis)", 1, 2, "three");
                  errno = EBADF;
-                 PyObject *tuple = Py_BuildValue("(iis)", 1, 2, "three");
                  PyErr_SetFromErrnoWithFilenameObject(PyExc_OSError, tuple);
                  Py_DECREF(tuple);
                  return NULL;
@@ -314,8 +314,8 @@
         module = self.import_extension('foo', [
                 ("set_from_errno", "METH_NOARGS",
                  '''
+                 PyObject *none = Py_BuildValue("");
                  errno = EBADF;
-                 PyObject *none = Py_BuildValue("");
                  PyErr_SetFromErrnoWithFilenameObject(PyExc_OSError, none);
                  Py_DECREF(none);
                  return NULL;


More information about the pypy-commit mailing list