[pypy-commit] pypy stmgc-c4: updated comment

Raemi noreply at buildbot.pypy.org
Wed Jan 15 14:33:08 CET 2014


Author: Remi Meier <remi.meier at gmail.com>
Branch: stmgc-c4
Changeset: r68682:f8476923f8b9
Date: 2014-01-15 14:32 +0100
http://bitbucket.org/pypy/pypy/changeset/f8476923f8b9/

Log:	updated comment

diff --git a/rpython/jit/metainterp/optimizeopt/stm.py b/rpython/jit/metainterp/optimizeopt/stm.py
--- a/rpython/jit/metainterp/optimizeopt/stm.py
+++ b/rpython/jit/metainterp/optimizeopt/stm.py
@@ -5,8 +5,16 @@
 
 class OptSTM(Optimization):
     """
-    For now only changes some guarded transaction breaks
-    to unconditional ones.
+    This step removes a lot of uncecessary transaction_breaks (TBs)
+    emitted by pyjitpl from traces. We only want to keep these
+    unconditional TBs after external calls (identified by GUARD_NOT_FORCED)
+    because they are likely to return as inevitable transactions which
+    we want to break ASAP.
+    Guarded TBs are left in place, as they represent app-level loops
+    and are likely points to break between atomic transactions.
+
+    The cached_ops is here to remove the virtualizable-forcing added
+    by pyjitpl before unconditional TBs. See tests.
     """
     def __init__(self):
         self.remove_next_gnf = False # guard_not_forced


More information about the pypy-commit mailing list