[pypy-commit] pypy remove-tuple-smm: Remove some misleading comments.

Manuel Jacob noreply at buildbot.pypy.org
Wed May 22 18:12:37 CEST 2013


Author: Manuel Jacob
Branch: remove-tuple-smm
Changeset: r64458:42b01e72477d
Date: 2013-05-22 18:01 +0200
http://bitbucket.org/pypy/pypy/changeset/42b01e72477d/

Log:	Remove some misleading comments.

diff --git a/pypy/objspace/std/specialisedtupleobject.py b/pypy/objspace/std/specialisedtupleobject.py
--- a/pypy/objspace/std/specialisedtupleobject.py
+++ b/pypy/objspace/std/specialisedtupleobject.py
@@ -52,7 +52,6 @@
         getitems_copy = func_with_new_name(tolist, 'getitems_copy')
 
         def descr_hash(self, space):
-            # XXX duplicate logic from tupleobject.py
             mult = 1000003
             x = 0x345678
             z = nValues
diff --git a/pypy/objspace/std/tupleobject.py b/pypy/objspace/std/tupleobject.py
--- a/pypy/objspace/std/tupleobject.py
+++ b/pypy/objspace/std/tupleobject.py
@@ -74,8 +74,6 @@
 
     def descr_repr(self, space):
         items = self.tolist()
-        # XXX this is quite innefficient, still better than calling
-        #     it via applevel
         if len(items) == 1:
             return space.wrap("(" + space.str_w(space.repr(items[0])) + ",)")
         tmp = ", ".join([space.str_w(space.repr(item)) for item in items])
@@ -248,7 +246,6 @@
 
     @jit.look_inside_iff(lambda self, _1: _unroll_condition(self))
     def descr_hash(self, space):
-        # this is the CPython 2.4 algorithm (changed from 2.3)
         mult = 1000003
         x = 0x345678
         z = len(self.wrappeditems)


More information about the pypy-commit mailing list