[pypy-commit] pypy py3k-memoryview: Python 3.2 supports tolist() only on byte memoryviews.

Manuel Jacob noreply at buildbot.pypy.org
Wed Mar 6 11:59:07 CET 2013


Author: Manuel Jacob
Branch: py3k-memoryview
Changeset: r62129:b1c812a69e23
Date: 2013-03-06 11:54 +0100
http://bitbucket.org/pypy/pypy/changeset/b1c812a69e23/

Log:	Python 3.2 supports tolist() only on byte memoryviews.

diff --git a/pypy/module/__builtin__/interp_memoryview.py b/pypy/module/__builtin__/interp_memoryview.py
--- a/pypy/module/__builtin__/interp_memoryview.py
+++ b/pypy/module/__builtin__/interp_memoryview.py
@@ -78,9 +78,12 @@
     def descr_tolist(self, space):
         self._check_released(space)
         buf = self.buf
+        if buf.format != 'B':
+            raise OperationError(space.w_NotImplementedError, space.wrap(
+                "tolist() only supports byte views"))
         result = []
         for i in range(buf.getlength()):
-            result.append(space.wrap(ord(buf.getitem(i))))
+            result.append(space.wrap(ord(buf.getitem(i)[0])))
         return space.newlist(result)
 
     def descr_getitem(self, space, w_index):


More information about the pypy-commit mailing list