[pypy-commit] buildbot buildbot-0.8.7: raise a validation error instead of crashing if the username is missing

[bivab]

Author: David Schneider <david.schneider at picle.org>
Branch: buildbot-0.8.7
Changeset: r805:b48b1aac38d1
Date: 2013-04-26 21:04 +0200
http://bitbucket.org/pypy/buildbot/changeset/b48b1aac38d1/

Log:	raise a validation error instead of crashing if the username is
	missing

diff --git a/bot2/pypybuildbot/master.py b/bot2/pypybuildbot/master.py
--- a/bot2/pypybuildbot/master.py
+++ b/bot2/pypybuildbot/master.py
@@ -2,6 +2,7 @@
 import os
 from buildbot.scheduler import Nightly
 from buildbot.schedulers.forcesched import ForceScheduler
+from buildbot.schedulers.forcesched import ValidationError
 from buildbot.buildslave import BuildSlave
 from buildbot.status.html import WebStatus
 #from buildbot import manhole
@@ -10,10 +11,10 @@
 from pypybuildbot.util import we_are_debugging
 
 # Forbid "force build" with empty user name
-
 class CustomForceScheduler(ForceScheduler):
     def force(self, owner, builder_name, **kwargs):
-        assert owner, "Please write your name in the corresponding field."
+        if not owner:
+            raise ValidationError, "Please write your name in the corresponding field."
         return ForceScheduler.force(self, owner, builder_name, **kwargs)