[pypy-commit] [pypy/pypy] add ndmin param to numpy.array (pull request #63)

Maciej Fijalkowski pullrequests-noreply at bitbucket.org
Tue Mar 20 08:09:14 CET 2012


New comment on pull request:

https://bitbucket.org/pypy/pypy/pull-request/63/add-ndmin-param-to-numpyarray#comment-4086

Maciej Fijalkowski (fijal) said:

list multiplication is fine, also test_ztranslation (mostly) checks if this is correct rpython. the None or a wrapped-none is only necessary if you call array from somewhere else in the interp-level (since then there is no automagic wrapping).

Can you please merge in default and resolve the (mostly trivial, but not quite) conflict first though?

Cheers,
fijal

--
This is a pull request comment notification from bitbucket.org.
You are receiving this either because you are participating
in a pull request, or you are following it.


More information about the pypy-commit mailing list