[pypy-commit] lang-js default: removed _get_property_* from W_Root

stepahn noreply at buildbot.pypy.org
Fri Dec 28 11:32:43 CET 2012


Author: Stephan <stephan at stzal.com>
Branch: 
Changeset: r145:545845c049dc
Date: 2011-11-02 12:32 +0100
http://bitbucket.org/pypy/lang-js/changeset/545845c049dc/

Log:	removed _get_property_* from W_Root

diff --git a/js/jsobj.py b/js/jsobj.py
--- a/js/jsobj.py
+++ b/js/jsobj.py
@@ -41,8 +41,6 @@
 
     def tolist(self):
         raise JsTypeError('arrayArgs is not an Array or Arguments object')
-    #def GetValue(self):
-    #    return self
 
     def ToBoolean(self):
         raise NotImplementedError(self.__class__)
@@ -99,15 +97,6 @@
     def Delete(self, name):
         return False
 
-    def _get_property_keys(self):
-        raise NotImplementedError(self.__class__)
-
-    def _get_property_flags(self, prop):
-        raise NotImplementedError(self.__class__)
-
-    def _get_property_value(self, prop):
-        raise NotImplementedError(self.__class__)
-
 class W_Undefined(W_Root):
     def __str__(self):
         return "w_undefined"
diff --git a/js/opcodes.py b/js/opcodes.py
--- a/js/opcodes.py
+++ b/js/opcodes.py
@@ -600,6 +600,7 @@
     def eval(self, ctx):
         obj = ctx.pop().ToObject(ctx)
         props = []
+        assert isinstance(obj, W_PrimitiveObject)
 
         for prop in obj._get_property_keys():
             if not obj._get_property_flags(prop) & jsobj.DONT_ENUM:


More information about the pypy-commit mailing list