[pypy-commit] pypy default: Bah? The warning given by GCC is relevant: this code was broken at

arigo noreply at buildbot.pypy.org
Mon Dec 3 16:53:18 CET 2012


Author: Armin Rigo <arigo at tunes.org>
Branch: 
Changeset: r59293:4a88e8c50f95
Date: 2012-12-03 07:53 -0800
http://bitbucket.org/pypy/pypy/changeset/4a88e8c50f95/

Log:	Bah? The warning given by GCC is relevant: this code was broken at
	least on 64-bit big-endian machines.

diff --git a/pypy/translator/c/src/dtoa.c b/pypy/translator/c/src/dtoa.c
--- a/pypy/translator/c/src/dtoa.c
+++ b/pypy/translator/c/src/dtoa.c
@@ -2329,7 +2329,7 @@
 
 static char *
 __Py_dg_dtoa(double dd, int mode, int ndigits,
-            int *decpt, int *sign, char **rve)
+            Signed *decpt, Signed *sign, char **rve)
 {
     /*  Arguments ndigits, decpt, sign are similar to those
         of ecvt and fcvt; trailing zeros are suppressed from
@@ -2952,7 +2952,7 @@
 }
 
 char * _PyPy_dg_dtoa(double dd, int mode, int ndigits,
-                   int *decpt, int *sign, char **rve)
+                   Signed *decpt, Signed *sign, char **rve)
 {
     char* result;
     _PyPy_SET_53BIT_PRECISION_HEADER;
diff --git a/pypy/translator/c/src/dtoa.h b/pypy/translator/c/src/dtoa.h
--- a/pypy/translator/c/src/dtoa.h
+++ b/pypy/translator/c/src/dtoa.h
@@ -2,6 +2,6 @@
 
 double _PyPy_dg_strtod(const char *str, char **ptr);
 char * _PyPy_dg_dtoa(double d, int mode, int ndigits,
-		     int *decpt, int *sign, char **rve);
+		     Signed *decpt, Signed *sign, char **rve);
 void _PyPy_dg_freedtoa(char *s);
 


More information about the pypy-commit mailing list