[pypy-commit] pypy default: Remove rope support from std objspace

alex_gaynor noreply at buildbot.pypy.org
Sat Dec 1 18:54:00 CET 2012


Author: Alex Gaynor <alex.gaynor at gmail.com>
Branch: 
Changeset: r59164:73f11934a6d5
Date: 2012-12-01 09:53 -0800
http://bitbucket.org/pypy/pypy/changeset/73f11934a6d5/

Log:	Remove rope support from std objspace

diff too long, truncating to 2000 out of 2679 lines

diff --git a/pypy/config/pypyoption.py b/pypy/config/pypyoption.py
--- a/pypy/config/pypyoption.py
+++ b/pypy/config/pypyoption.py
@@ -254,18 +254,6 @@
                    "use specialised tuples",
                    default=False),
 
-        BoolOption("withrope", "use ropes as the string implementation",
-                   default=False,
-                   requires=[("objspace.std.withstrslice", False),
-                             ("objspace.std.withstrjoin", False),
-                             ("objspace.std.withstrbuf", False)],
-                   suggests=[("objspace.std.withprebuiltchar", True),
-                             ("objspace.std.sharesmallstr", True)]),
-
-        BoolOption("withropeunicode", "use ropes for the unicode implementation",
-                   default=False,
-                   requires=[("objspace.std.withrope", True)]),
-
         BoolOption("withcelldict",
                    "use dictionaries that are optimized for being used as module dicts",
                    default=False,
@@ -394,7 +382,6 @@
         config.objspace.std.suggest(withstrjoin=True)
         if not IS_64_BITS:
             config.objspace.std.suggest(withsmalllong=True)
-        # xxx other options? ropes maybe?
 
     # some optimizations have different effects depending on the typesystem
     if type_system == 'ootype':
diff --git a/pypy/doc/config/objspace.std.withrope.txt b/pypy/doc/config/objspace.std.withrope.txt
deleted file mode 100644
--- a/pypy/doc/config/objspace.std.withrope.txt
+++ /dev/null
@@ -1,7 +0,0 @@
-Enable ropes to be the default string implementation.
-
-See the section in `Standard Interpreter Optimizations`_ for more details.
-
-.. _`Standard Interpreter Optimizations`: ../interpreter-optimizations.html#ropes
-
-
diff --git a/pypy/doc/config/objspace.std.withropeunicode.txt b/pypy/doc/config/objspace.std.withropeunicode.txt
deleted file mode 100644
--- a/pypy/doc/config/objspace.std.withropeunicode.txt
+++ /dev/null
@@ -1,7 +0,0 @@
-Use ropes to implement unicode strings (and also normal strings).
-
-See the section in `Standard Interpreter Optimizations`_ for more details.
-
-.. _`Standard Interpreter Optimizations`: ../interpreter-optimizations.html#ropes
-
-
diff --git a/pypy/doc/interpreter-optimizations.rst b/pypy/doc/interpreter-optimizations.rst
--- a/pypy/doc/interpreter-optimizations.rst
+++ b/pypy/doc/interpreter-optimizations.rst
@@ -64,35 +64,6 @@
 
 You can enable this feature with the :config:`objspace.std.withstrslice` option.
 
-Ropes
-+++++
-
-Ropes are a general flexible string implementation, following the paper `"Ropes:
-An alternative to Strings."`_ by Boehm, Atkinson and Plass. Strings are
-represented as balanced concatenation trees, which makes slicing and
-concatenation of huge strings efficient.
-
-Using ropes is usually not a huge benefit for normal Python programs that use
-the typical pattern of appending substrings to a list and doing a
-``"".join(l)`` at the end. If ropes are used, there is no need to do that.
-A somewhat silly example of things you can do with them is this::
-
-    $ bin/py.py --objspace-std-withrope
-    faking <type 'module'>
-    PyPy 1.5.0-alpha0 in StdObjSpace on top of Python 2.7.1+ (startuptime: 11.38 secs)
-    >>>> import sys
-    >>>> sys.maxint
-    2147483647
-    >>>> s = "a" * sys.maxint
-    >>>> s[10:20]
-    'aaaaaaaaaa'
-
-
-You can enable this feature with the :config:`objspace.std.withrope` option.
-
-.. _`"Ropes: An alternative to Strings."`: http://citeseer.ist.psu.edu/viewdoc/download?doi=10.1.1.14.9450&rep=rep1&type=pdf
-
-
 Integer Optimizations
 ---------------------
 
diff --git a/pypy/module/marshal/test/test_marshal.py b/pypy/module/marshal/test/test_marshal.py
--- a/pypy/module/marshal/test/test_marshal.py
+++ b/pypy/module/marshal/test/test_marshal.py
@@ -181,9 +181,6 @@
         assert r"'\x01'" in exc.value.message
 
 
-class AppTestRope(AppTestMarshal):
-    spaceconfig = {"objspace.std.withrope": True}
-
 class AppTestSmallLong(AppTestMarshal):
     spaceconfig = {"objspace.std.withsmalllong": True}
 
diff --git a/pypy/objspace/std/floattype.py b/pypy/objspace/std/floattype.py
--- a/pypy/objspace/std/floattype.py
+++ b/pypy/objspace/std/floattype.py
@@ -44,10 +44,7 @@
             raise OperationError(space.w_ValueError,
                                  space.wrap(e.msg))
     elif space.isinstance_w(w_value, space.w_unicode):
-        if space.config.objspace.std.withropeunicode:
-            from pypy.objspace.std.ropeunicodeobject import unicode_to_decimal_w
-        else:
-            from unicodeobject import unicode_to_decimal_w
+        from unicodeobject import unicode_to_decimal_w
         strvalue = unicode_to_decimal_w(space, w_value)
         try:
             value = string_to_float(strvalue)
diff --git a/pypy/objspace/std/inttype.py b/pypy/objspace/std/inttype.py
--- a/pypy/objspace/std/inttype.py
+++ b/pypy/objspace/std/inttype.py
@@ -105,10 +105,7 @@
             value, w_longval = string_to_int_or_long(space, space.str_w(w_value))
             ok = True
         elif space.isinstance_w(w_value, space.w_unicode):
-            if space.config.objspace.std.withropeunicode:
-                from pypy.objspace.std.ropeunicodeobject import unicode_to_decimal_w
-            else:
-                from pypy.objspace.std.unicodeobject import unicode_to_decimal_w
+            from pypy.objspace.std.unicodeobject import unicode_to_decimal_w
             string = unicode_to_decimal_w(space, w_value)
             value, w_longval = string_to_int_or_long(space, string)
             ok = True
@@ -140,7 +137,7 @@
             try:
                 value = space.int_w(w_obj)
             except OperationError, e:
-                if e.match(space,space.w_TypeError):
+                if e.match(space, space.w_TypeError):
                     raise OperationError(space.w_ValueError,
                         space.wrap("value can't be converted to int"))
                 raise e
@@ -148,10 +145,7 @@
         base = space.int_w(w_base)
 
         if space.isinstance_w(w_value, space.w_unicode):
-            if space.config.objspace.std.withropeunicode:
-                from pypy.objspace.std.ropeunicodeobject import unicode_to_decimal_w
-            else:
-                from pypy.objspace.std.unicodeobject import unicode_to_decimal_w
+            from pypy.objspace.std.unicodeobject import unicode_to_decimal_w
             s = unicode_to_decimal_w(space, w_value)
         else:
             try:
diff --git a/pypy/objspace/std/longtype.py b/pypy/objspace/std/longtype.py
--- a/pypy/objspace/std/longtype.py
+++ b/pypy/objspace/std/longtype.py
@@ -29,10 +29,7 @@
         elif space.isinstance_w(w_value, space.w_str):
             return string_to_w_long(space, w_longtype, space.str_w(w_value))
         elif space.isinstance_w(w_value, space.w_unicode):
-            if space.config.objspace.std.withropeunicode:
-                from pypy.objspace.std.ropeunicodeobject import unicode_to_decimal_w
-            else:
-                from pypy.objspace.std.unicodeobject import unicode_to_decimal_w
+            from pypy.objspace.std.unicodeobject import unicode_to_decimal_w
             return string_to_w_long(space, w_longtype,
                                     unicode_to_decimal_w(space, w_value))
         else:
@@ -54,10 +51,7 @@
         base = space.int_w(w_base)
 
         if space.isinstance_w(w_value, space.w_unicode):
-            if space.config.objspace.std.withropeunicode:
-                from pypy.objspace.std.ropeunicodeobject import unicode_to_decimal_w
-            else:
-                from pypy.objspace.std.unicodeobject import unicode_to_decimal_w
+            from pypy.objspace.std.unicodeobject import unicode_to_decimal_w
             s = unicode_to_decimal_w(space, w_value)
         else:
             try:
diff --git a/pypy/objspace/std/marshal_impl.py b/pypy/objspace/std/marshal_impl.py
--- a/pypy/objspace/std/marshal_impl.py
+++ b/pypy/objspace/std/marshal_impl.py
@@ -26,7 +26,6 @@
 from pypy.objspace.std.listobject    import W_ListObject
 from pypy.objspace.std.dictmultiobject    import W_DictMultiObject
 from pypy.objspace.std.stringobject  import W_StringObject
-from pypy.objspace.std.ropeobject    import W_RopeObject
 from pypy.objspace.std.typeobject    import W_TypeObject
 from pypy.objspace.std.longobject    import W_LongObject, newlong
 from pypy.objspace.std.noneobject    import W_NoneObject
@@ -269,8 +268,6 @@
     else:
         m.atom_str(TYPE_STRING, s)
 
-marshal_w__Rope = marshal_w__String
-
 def unmarshal_String(space, u, tc):
     return space.wrap(u.get_str())
 register(TYPE_STRING, unmarshal_String)
diff --git a/pypy/objspace/std/model.py b/pypy/objspace/std/model.py
--- a/pypy/objspace/std/model.py
+++ b/pypy/objspace/std/model.py
@@ -22,10 +22,6 @@
     "withstrslice"   : ["strsliceobject.W_StringSliceObject"],
     "withstrjoin"    : ["strjoinobject.W_StringJoinObject"],
     "withstrbuf"     : ["strbufobject.W_StringBufferObject"],
-    "withrope"       : ["ropeobject.W_RopeObject",
-                        "ropeobject.W_RopeIterObject"],
-    "withropeunicode": ["ropeunicodeobject.W_RopeUnicodeObject",
-                        "ropeunicodeobject.W_RopeUnicodeIterObject"],
     "withtproxy" : ["proxyobject.W_TransparentList",
                     "proxyobject.W_TransparentDict"],
 }
@@ -151,9 +147,6 @@
                     else:
                         self.imported_but_not_registered[implcls] = True
 
-        if config.objspace.std.withrope:
-            del self.typeorder[stringobject.W_StringObject]
-
         # check if we missed implementations
         for implcls in _registered_implementations:
             if hasattr(implcls, 'register'):
@@ -225,22 +218,9 @@
         self.typeorder[setobject.W_FrozensetObject] += [
             (setobject.W_BaseSetObject, None)
             ]
-        if not config.objspace.std.withrope:
-            self.typeorder[stringobject.W_StringObject] += [
-             (unicodeobject.W_UnicodeObject, unicodeobject.delegate_String2Unicode),
-                ]
-        else:
-            from pypy.objspace.std import ropeobject
-            if config.objspace.std.withropeunicode:
-                from pypy.objspace.std import ropeunicodeobject
-                self.typeorder[ropeobject.W_RopeObject] += [
-                 (ropeunicodeobject.W_RopeUnicodeObject,
-                     ropeunicodeobject.delegate_Rope2RopeUnicode),
-                 ]
-            else:
-                self.typeorder[ropeobject.W_RopeObject] += [
-                 (unicodeobject.W_UnicodeObject, unicodeobject.delegate_String2Unicode),
-                    ]
+        self.typeorder[stringobject.W_StringObject] += [
+            (unicodeobject.W_UnicodeObject, unicodeobject.delegate_String2Unicode),
+            ]
         if config.objspace.std.withstrslice:
             from pypy.objspace.std import strsliceobject
             self.typeorder[strsliceobject.W_StringSliceObject] += [
diff --git a/pypy/objspace/std/objspace.py b/pypy/objspace/std/objspace.py
--- a/pypy/objspace/std/objspace.py
+++ b/pypy/objspace/std/objspace.py
@@ -23,7 +23,6 @@
 from pypy.objspace.std.longobject import W_LongObject, newlong
 from pypy.objspace.std.noneobject import W_NoneObject
 from pypy.objspace.std.objectobject import W_ObjectObject
-from pypy.objspace.std.ropeobject import W_RopeObject
 from pypy.objspace.std.iterobject import W_SeqIterObject
 from pypy.objspace.std.setobject import W_SetObject, W_FrozensetObject
 from pypy.objspace.std.sliceobject import W_SliceObject
@@ -48,12 +47,8 @@
         self.model = model.StdTypeModel(self.config)
 
         self.FrameClass = frame.build_frame(self)
+        self.StringObjectCls = W_StringObject
 
-        if self.config.objspace.std.withrope:
-            self.StringObjectCls = W_RopeObject
-        else:
-            self.StringObjectCls = W_StringObject
-            
         self.UnicodeObjectCls = W_UnicodeObject
 
         self._install_multimethods()
diff --git a/pypy/objspace/std/ropeobject.py b/pypy/objspace/std/ropeobject.py
deleted file mode 100644
--- a/pypy/objspace/std/ropeobject.py
+++ /dev/null
@@ -1,909 +0,0 @@
-from pypy.objspace.std.model import registerimplementation, W_Object
-from pypy.objspace.std.register_all import register_all
-from pypy.objspace.std.multimethod import FailedToImplement
-from pypy.interpreter.error import OperationError, operationerrfmt
-from pypy.interpreter import gateway
-from pypy.rlib.objectmodel import we_are_translated
-from pypy.objspace.std.inttype import wrapint
-from pypy.objspace.std.sliceobject import W_SliceObject, normalize_simple_slice
-from pypy.objspace.std import stringobject, slicetype, iterobject
-from pypy.objspace.std.listobject import W_ListObject
-from pypy.objspace.std.noneobject import W_NoneObject
-from pypy.objspace.std.tupleobject import W_TupleObject
-from pypy.rlib.rarithmetic import ovfcheck
-from pypy.objspace.std.stringtype import wrapchar
-
-from pypy.rlib import rope
-from pypy.objspace.std.stringobject import (
-    mod__String_ANY as mod__Rope_ANY,
-    str_format__String as str_format__Rope,
-    _upper, _lower, DEFAULT_NOOP_TABLE)
-
-class W_RopeObject(stringobject.W_AbstractStringObject):
-    from pypy.objspace.std.stringtype import str_typedef as typedef
-    _immutable_fields_ = ['_node']
-
-    def __init__(w_self, node):
-        if not we_are_translated():
-            assert node.is_bytestring()
-        w_self._node = node
-
-    def __repr__(w_self):
-        """ representation for debugging purposes """
-        return "%s(%r)" % (w_self.__class__.__name__, w_self._node)
-
-    def unwrap(w_self, space):
-        return w_self._node.flatten_string()
-    str_w = unwrap
-
-    def create_if_subclassed(w_self):
-        if type(w_self) is W_RopeObject:
-            return w_self
-        return W_RopeObject(w_self._node)
-
-W_RopeObject.EMPTY = W_RopeObject(rope.LiteralStringNode.EMPTY)
-W_RopeObject.PREBUILT = [W_RopeObject(rope.LiteralStringNode.PREBUILT[i])
-                             for i in range(256)]
-del i
-
-
-def rope_w(space, w_str):
-    if isinstance(w_str, W_RopeObject):
-        return w_str._node
-    return rope.LiteralStringNode(space.str_w(w_str))
-
-registerimplementation(W_RopeObject)
-
-class W_RopeIterObject(iterobject.W_AbstractIterObject):
-    from pypy.objspace.std.itertype import iter_typedef as typedef
-
-    def __init__(w_self, w_rope, index=0):
-        w_self.node = node = w_rope._node
-        w_self.item_iter = rope.ItemIterator(node)
-        w_self.index = index
-
-registerimplementation(W_RopeIterObject)
-
-def _is_generic(space, w_self, fun):
-    l = w_self._node.length()
-    if l == 0:
-        return space.w_False
-    iter = rope.ItemIterator(w_self._node)
-    for i in range(l):
-        if not fun(iter.nextchar()):
-            return space.w_False
-    return space.w_True
-_is_generic._annspecialcase_ = "specialize:arg(2)"
-
-_isspace = lambda c: c.isspace()
-_isdigit = lambda c: c.isdigit()
-_isalpha = lambda c: c.isalpha()
-_isalnum = lambda c: c.isalnum()
-
-def str_isspace__Rope(space, w_self):
-    return _is_generic(space, w_self, _isspace)
-
-def str_isdigit__Rope(space, w_self):
-    return _is_generic(space, w_self, _isdigit)
-
-def str_isalpha__Rope(space, w_self):
-    return _is_generic(space, w_self, _isalpha)
-
-def str_isalnum__Rope(space, w_self):
-    return _is_generic(space, w_self, _isalnum)
-
-def str_isupper__Rope(space, w_self):
-    """Return True if all cased characters in S are uppercase and there is
-at least one cased character in S, False otherwise."""
-    l = w_self._node.length()
-
-    if l == 0:
-        return space.w_False
-    cased = False
-    iter = rope.ItemIterator(w_self._node)
-    for idx in range(l):
-        c = iter.nextchar()
-        if c.islower():
-            return space.w_False
-        elif not cased and c.isupper():
-            cased = True
-    return space.newbool(cased)
-
-def str_islower__Rope(space, w_self):
-    """Return True if all cased characters in S are lowercase and there is
-at least one cased character in S, False otherwise."""
-    l = w_self._node.length()
-
-    if l == 0:
-        return space.w_False
-    cased = False
-    iter = rope.ItemIterator(w_self._node)
-    for idx in range(l):
-        c = iter.nextchar()
-        if c.isupper():
-            return space.w_False
-        elif not cased and c.islower():
-            cased = True
-    return space.newbool(cased)
-
-def str_istitle__Rope(space, w_self):
-    """Return True if S is a titlecased string and there is at least one
-character in S, i.e. uppercase characters may only follow uncased
-characters and lowercase characters only cased ones. Return False
-otherwise."""
-    cased = False
-    previous_is_cased = False
-
-    iter = rope.ItemIterator(w_self._node)
-    for pos in range(0, w_self._node.length()):
-        ch = iter.nextchar()
-        if ch.isupper():
-            if previous_is_cased:
-                return space.w_False
-            previous_is_cased = True
-            cased = True
-        elif ch.islower():
-            if not previous_is_cased:
-                return space.w_False
-            cased = True
-        else:
-            previous_is_cased = False
-
-    return space.newbool(cased)
-
-def _local_transform(node, transform):
-    l = node.length()
-    res = [' '] * l
-    iter = rope.ItemIterator(node)
-    for i in range(l):
-        ch = iter.nextchar()
-        res[i] = transform(ch)
-
-    return W_RopeObject(rope.rope_from_charlist(res))
-_local_transform._annspecialcase_ = "specialize:arg(1)"
-
-def str_upper__Rope(space, w_self):
-    return _local_transform(w_self._node, _upper)
-
-def str_lower__Rope(space, w_self):
-    return _local_transform(w_self._node, _lower)
-
-def _swapcase(ch):
-    if ch.isupper():
-        o = ord(ch) + 32
-        return chr(o)
-    elif ch.islower():
-        o = ord(ch) - 32
-        return chr(o)
-    else:
-        return ch
-
-def str_swapcase__Rope(space, w_self):
-    return _local_transform(w_self._node, _swapcase)
-
-
-def str_capitalize__Rope(space, w_self):
-    node = w_self._node
-    length = node.length()
-    buffer = [' '] * length
-    if length > 0:
-        iter = rope.ItemIterator(node)
-        ch = iter.nextchar()
-        if ch.islower():
-            o = ord(ch) - 32
-            buffer[0] = chr(o)
-        else:
-            buffer[0] = ch
-
-        for i in range(1, length):
-            ch = iter.nextchar()
-            if ch.isupper():
-                o = ord(ch) + 32
-                buffer[i] = chr(o)
-            else:
-                buffer[i] = ch
-    else:
-        return W_RopeObject.EMPTY
-
-    return W_RopeObject(rope.rope_from_charlist(buffer))
-
-
-def str_title__Rope(space, w_self):
-    node = w_self._node
-    length = node.length()
-    buffer = [' '] * length
-    prev_letter = ' '
-
-    iter = rope.ItemIterator(node)
-    for pos in range(0, length):
-        ch = iter.nextchar()
-        if not prev_letter.isalpha():
-            buffer[pos] = _upper(ch)
-        else:
-            buffer[pos] = _lower(ch)
-
-        prev_letter = buffer[pos]
-
-    return W_RopeObject(rope.rope_from_charlist(buffer))
-
-def str_split__Rope_None_ANY(space, w_self, w_none, w_maxsplit=-1):
-    selfnode = w_self._node
-    maxsplit = space.int_w(w_maxsplit)
-    res_w = [W_RopeObject(node)
-                for node in rope.split_chars(selfnode, maxsplit)]
-    return space.newlist(res_w)
-
-def str_split__Rope_Rope_ANY(space, w_self, w_by, w_maxsplit=-1):
-    maxsplit = space.int_w(w_maxsplit)
-    selfnode = w_self._node
-    bynode = w_by._node
-    bylen = bynode.length()
-    if bylen == 0:
-        raise OperationError(space.w_ValueError, space.wrap("empty separator"))
-    res_w = [W_RopeObject(node)
-                for node in rope.split(selfnode, bynode, maxsplit)]
-    return space.newlist(res_w)
-
-
-def str_rsplit__Rope_None_ANY(space, w_self, w_none, w_maxsplit=-1):
-    selfnode = w_self._node
-    maxsplit = space.int_w(w_maxsplit)
-    res_w = [W_RopeObject(node)
-                for node in rope.rsplit_chars(selfnode, maxsplit)]
-    return space.newlist(res_w)
-
-
-def str_rsplit__Rope_Rope_ANY(space, w_self, w_by, w_maxsplit=-1):
-    # XXX works but flattens
-    maxsplit = space.int_w(w_maxsplit)
-    res_w = []
-    value = w_self._node.flatten_string()
-    end = len(value)
-    by = w_by._node.flatten_string()
-    bylen = len(by)
-    if bylen == 0:
-        raise OperationError(space.w_ValueError, space.wrap("empty separator"))
-
-    while maxsplit != 0:
-        next = value.rfind(by, 0, end)
-        if next < 0:
-            break
-        res_w.append(space.wrap(value[next+bylen: end]))
-        end = next
-        maxsplit -= 1   # NB. if it's already < 0, it stays < 0
-
-    res_w.append(space.wrap(value[:end]))
-    res_w.reverse()
-    return space.newlist(res_w)
-
-def str_join__Rope_ANY(space, w_self, w_list):
-    list_w = space.unpackiterable(w_list)
-    size = len(list_w)
-
-    if size == 0:
-        return W_RopeObject.EMPTY
-    if size == 1:
-        w_s = list_w[0]
-        # only one item,  return it if it's not a subclass of str
-        if (space.is_w(space.type(w_s), space.w_str) or
-            space.is_w(space.type(w_s), space.w_unicode)):
-            return w_s
-
-    self = w_self._node
-    l = []
-    for i in range(size):
-        w_s = list_w[i]
-        if not space.isinstance_w(w_s, space.w_str):
-            if space.isinstance_w(w_s, space.w_unicode):
-                w_u = space.call_function(space.w_unicode, w_self)
-                return space.call_method(w_u, "join", space.newlist(list_w))
-            raise operationerrfmt(
-                space.w_TypeError,
-                "sequence item %d: expected string, %s "
-                "found", i, space.type(w_s).getname(space))
-        assert isinstance(w_s, W_RopeObject)
-        node = w_s._node
-        l.append(node)
-    try:
-        return W_RopeObject(rope.join(self, l))
-    except OverflowError:
-        raise OperationError(space.w_OverflowError,
-                             space.wrap("string too long"))
-
-def str_rjust__Rope_ANY_ANY(space, w_self, w_arg, w_fillchar):
-    u_arg = space.int_w(w_arg)
-    selfnode = w_self._node
-    fillchar = space.str_w(w_fillchar)
-    if len(fillchar) != 1:
-        raise OperationError(space.w_TypeError,
-            space.wrap("rjust() argument 2 must be a single character"))
-
-    d = u_arg - selfnode.length()
-    if d > 0:
-        fillchar = fillchar[0]    # annotator hint: it's a single character
-        resultnode = rope.concatenate(
-                rope.multiply(rope.LiteralStringNode.PREBUILT[ord(fillchar)],
-                              d),
-                selfnode)
-        return W_RopeObject(resultnode)
-    else:
-        return W_RopeObject(selfnode)
-
-def str_ljust__Rope_ANY_ANY(space, w_self, w_arg, w_fillchar):
-    u_arg = space.int_w(w_arg)
-    selfnode = w_self._node
-    fillchar = space.str_w(w_fillchar)
-    if len(fillchar) != 1:
-        raise OperationError(space.w_TypeError,
-            space.wrap("rjust() argument 2 must be a single character"))
-
-    d = u_arg - selfnode.length()
-    if d > 0:
-        fillchar = fillchar[0]    # annotator hint: it's a single character
-        resultnode = rope.concatenate(
-                selfnode,
-                rope.multiply(rope.LiteralStringNode.PREBUILT[ord(fillchar)],
-                              d))
-        return W_RopeObject(resultnode)
-    else:
-        return W_RopeObject(selfnode)
-
-def _convert_idx_params(space, w_self, w_sub, w_start, w_end, upper_bound=False):
-    self = w_self._node
-    sub = w_sub._node
-
-    start, end = slicetype.unwrap_start_stop(
-            space, self.length(), w_start, w_end, upper_bound)
-
-    return (self, sub, start, end)
-_convert_idx_params._annspecialcase_ = 'specialize:arg(5)'
-
-def contains__Rope_Rope(space, w_self, w_sub):
-    self = w_self._node
-    sub = w_sub._node
-    return space.newbool(rope.find(self, sub) >= 0)
-
-def str_find__Rope_Rope_ANY_ANY(space, w_self, w_sub, w_start, w_end):
-
-    (self, sub, start, end) =  _convert_idx_params(space, w_self, w_sub, w_start, w_end)
-    res = rope.find(self, sub, start, end)
-    return wrapint(space, res)
-
-def str_rfind__Rope_Rope_ANY_ANY(space, w_self, w_sub, w_start, w_end):
-    # XXX works but flattens
-    (self, sub, start, end) =  _convert_idx_params(space, w_self, w_sub, w_start, w_end)
-    self = self.flatten_string()
-    sub = sub.flatten_string()
-    res = self.rfind(sub, start, end)
-    return wrapint(space, res)
-
-def str_partition__Rope_Rope(space, w_self, w_sub):
-    self = w_self._node
-    sub = w_sub._node
-    if not sub.length():
-        raise OperationError(space.w_ValueError,
-                             space.wrap("empty separator"))
-    pos = rope.find(self, sub)
-    if pos == -1:
-        return space.newtuple([w_self, W_RopeObject.EMPTY,
-                               W_RopeObject.EMPTY])
-    else:
-        return space.newtuple(
-            [W_RopeObject(rope.getslice_one(self, 0, pos)),
-             w_sub,
-             W_RopeObject(rope.getslice_one(self, pos + sub.length(),
-                                            self.length()))])
-
-def str_rpartition__Rope_Rope(space, w_self, w_sub):
-    # XXX works but flattens
-    self = w_self._node
-    sub = w_sub._node
-    if not sub.length():
-        raise OperationError(space.w_ValueError,
-                             space.wrap("empty separator"))
-    flattened_self = self.flatten_string()
-    flattened_sub = sub.flatten_string()
-    pos = flattened_self.rfind(flattened_sub)
-    if pos == -1:
-        return space.newtuple([W_RopeObject.EMPTY, W_RopeObject.EMPTY, w_self])
-    else:
-        return space.newtuple(
-            [W_RopeObject(rope.getslice_one(self, 0, pos)),
-             w_sub,
-             W_RopeObject(rope.getslice_one(self, pos + sub.length(),
-                                            self.length()))])
-
-def str_index__Rope_Rope_ANY_ANY(space, w_self, w_sub, w_start, w_end):
-
-    (self, sub, start, end) =  _convert_idx_params(space, w_self, w_sub, w_start, w_end)
-    res = rope.find(self, sub, start, end)
-    if res < 0:
-        raise OperationError(space.w_ValueError,
-                             space.wrap("substring not found in string.index"))
-
-    return wrapint(space, res)
-
-
-def str_rindex__Rope_Rope_ANY_ANY(space, w_self, w_sub, w_start, w_end):
-    (self, sub, start, end) =  _convert_idx_params(space, w_self, w_sub, w_start, w_end)
-    # XXX works but flattens
-    self = self.flatten_string()
-    sub = sub.flatten_string()
-    res = self.rfind(sub, start, end)
-    if res < 0:
-        raise OperationError(space.w_ValueError,
-                             space.wrap("substring not found in string.rindex"))
-
-    return wrapint(space, res)
-
-
-def str_replace__Rope_Rope_Rope_ANY(space, w_self, w_sub, w_by, w_maxsplit=-1):
-
-    node = w_self._node
-    length = node.length()
-    sub = w_sub._node
-    by = w_by._node
-    maxsplit = space.int_w(w_maxsplit)
-    if maxsplit == 0:
-        return w_self.create_if_subclassed()
-
-    if not sub.length():
-        upper = node.length()
-        if maxsplit > 0 and maxsplit < upper + 2:
-            upper = maxsplit - 1
-            assert upper >= 0
-        substrings = [by]
-        iter = rope.ItemIterator(node)
-        for i in range(upper):
-            substrings.append(iter.nextrope())
-            substrings.append(by)
-        substrings.append(rope.getslice_one(node, upper, length))
-        try:
-            return W_RopeObject(rope.rebalance(substrings))
-        except OverflowError:
-            raise OperationError(space.w_OverflowError,
-                                 space.wrap("string too long"))
-    substrings = rope.split(node, sub, maxsplit)
-    if not substrings:
-        return w_self.create_if_subclassed()
-    try:
-        return W_RopeObject(rope.join(by, substrings))
-    except OverflowError:
-        raise OperationError(space.w_OverflowError,
-                             space.wrap("string too long"))
-
-
-def _contains(i, string):
-    return chr(i) in string
-
-def str_strip__Rope_Rope(space, w_self, w_chars):
-    return W_RopeObject(rope.strip(w_self._node, True, True,
-                                   _contains, w_chars._node.flatten_string()))
-
-def str_strip__Rope_None(space, w_self, w_chars):
-    return W_RopeObject(rope.strip(w_self._node, left=True, right=True))
-
-def str_rstrip__Rope_Rope(space, w_self, w_chars):
-    return W_RopeObject(rope.strip(w_self._node, False, True,
-                                   _contains, w_chars._node.flatten_string()))
-
-def str_rstrip__Rope_None(space, w_self, w_chars):
-    return W_RopeObject(rope.strip(w_self._node, False, True))
-
-def str_lstrip__Rope_Rope(space, w_self, w_chars):
-    return W_RopeObject(rope.strip(w_self._node, True, False,
-                                   _contains, w_chars._node.flatten_string()))
-
-def str_lstrip__Rope_None(space, w_self, w_chars):
-    return W_RopeObject(rope.strip(w_self._node, left=True, right=False))
-
-
-def str_center__Rope_ANY_ANY(space, w_self, w_arg, w_fillchar):
-    node = w_self._node
-    length = node.length()
-    arg  = space.int_w(w_arg)
-    fillchar = space.str_w(w_fillchar)
-    if len(fillchar) != 1:
-        raise OperationError(space.w_TypeError,
-            space.wrap("center() argument 2 must be a single character"))
-
-    d = arg - length
-    if d>0:
-        offset = d//2 + (d & arg & 1)
-        fillcharnode = rope.LiteralStringNode.PREBUILT[ord(fillchar)]
-        pre = rope.multiply(fillcharnode, offset)
-        post = rope.multiply(fillcharnode, (d - offset))
-        centered = rope.rebalance([pre, node, post])
-        return W_RopeObject(centered)
-    else:
-        return w_self.create_if_subclassed()
-
-def str_count__Rope_Rope_ANY_ANY(space, w_self, w_arg, w_start, w_end):
-    selfnode  = w_self._node
-    length = selfnode.length()
-    argnode   = w_arg._node
-
-    u_start = slicetype.adapt_bound(space, length, w_start)
-    u_end = slicetype.adapt_bound(space, length, w_end)
-    assert u_start >= 0
-    assert u_end >= 0
-    iter = rope.FindIterator(selfnode, argnode, u_start, u_end)
-    i = 0
-    while 1:
-        try:
-            index = iter.next()
-        except StopIteration:
-            break
-        i += 1
-    return wrapint(space, i)
-
-
-def str_endswith__Rope_Rope_ANY_ANY(space, w_self, w_suffix, w_start, w_end):
-    (self, suffix, start, end) = _convert_idx_params(space, w_self,
-                                                     w_suffix, w_start, w_end,
-                                                     True)
-    return space.newbool(rope.endswith(self, suffix, start, end))
-
-def str_endswith__Rope_Tuple_ANY_ANY(space, w_self, w_suffixes, w_start, w_end):
-    (self, _, start, end) = _convert_idx_params(space, w_self,
-                                                W_RopeObject.EMPTY, w_start,
-                                                w_end, True)
-    for w_suffix in space.fixedview(w_suffixes):
-        if space.isinstance_w(w_suffix, space.w_unicode):
-            w_u = space.call_function(space.w_unicode, w_self)
-            return space.call_method(w_u, "endswith", w_suffixes, w_start,
-                                     w_end)
-        suffix = rope_w(space, w_suffix)
-        if rope.endswith(self, suffix, start, end):
-            return space.w_True
-    return space.w_False
-
-
-def str_startswith__Rope_Rope_ANY_ANY(space, w_self, w_prefix, w_start, w_end):
-    (self, prefix, start, end) = _convert_idx_params(space, w_self,
-                                                     w_prefix, w_start, w_end,
-                                                     True)
-    return space.newbool(rope.startswith(self, prefix, start, end))
-
-def str_startswith__Rope_Tuple_ANY_ANY(space, w_self, w_prefixes, w_start, w_end):
-    (self, _, start, end) = _convert_idx_params(space, w_self, W_RopeObject.EMPTY,
-                                                  w_start, w_end, True)
-    for w_prefix in space.fixedview(w_prefixes):
-        if space.isinstance_w(w_prefix, space.w_unicode):
-            w_u = space.call_function(space.w_unicode, w_self)
-            return space.call_method(w_u, "startswith", w_prefixes, w_start,
-                                     w_end)
-        prefix = rope_w(space, w_prefix)
-        if rope.startswith(self, prefix, start, end):
-            return space.w_True
-    return space.w_False
-
-
-def _tabindent(node, tabsize):
-    "calculates distance after the token to the next tabstop"
-    length = node.length()
-    distance = tabsize
-    if length:
-        distance = 0
-        iter = rope.ReverseItemIterator(node)
-
-        while 1:
-            # no sophisticated linebreak support now
-            # '\r' just for passing adapted CPython test
-            try:
-                char = iter.nextint()
-            except StopIteration:
-                break
-            if char == ord("\n") or char == ord("\r"):
-                break
-            distance += 1
-
-        #the same like distance = len(u_token) - (offset + 1)
-        distance = (tabsize - distance) % tabsize
-        if distance == 0:
-            return tabsize
-
-    return distance
-
-
-def str_expandtabs__Rope_ANY(space, w_self, w_tabsize):
-    node = w_self._node
-    length = node.length()
-    if length == 0:
-        return W_RopeObject.EMPTY
-    tabsize  = space.int_w(w_tabsize)
-
-    splitted = rope.split(node, rope.LiteralStringNode.PREBUILT[ord("\t")])
-    last = splitted[0]
-    expanded = [last]
-    for i in range(1, len(splitted)):
-        expanded.append(rope.multiply(rope.LiteralStringNode.PREBUILT[ord(" ")],
-                                      _tabindent(last, tabsize)))
-        last = splitted[i]
-        expanded.append(last)
-    try:
-        return W_RopeObject(rope.rebalance(expanded))
-    except OverflowError:
-        raise OperationError(space.w_OverflowError, space.wrap('new string is too long'))
-
-
-def str_splitlines__Rope_ANY(space, w_self, w_keepends):
-    keepends = bool(space.int_w(w_keepends))  # truth value, but type checked
-    node = w_self._node
-    return space.newlist(
-        [W_RopeObject(n) for n in rope.splitlines(node, keepends)])
-
-def str_zfill__Rope_ANY(space, w_self, w_width):
-    node = w_self._node
-    length = node.length()
-    width = space.int_w(w_width)
-
-    if length >= width:
-        return w_self.create_if_subclassed()
-    zero = rope.LiteralStringNode.PREBUILT[ord("0")]
-    if length == 0:
-        return W_RopeObject(rope.multiply(zero, width))
-
-    middle = width - length
-    firstchar = node.getchar(0)
-    if length > 0 and (firstchar == '+' or firstchar == '-'):
-        return W_RopeObject(rope.rebalance(
-            [rope.LiteralStringNode.PREBUILT[ord(firstchar)],
-             rope.multiply(zero, middle),
-             rope.getslice_one(node, 1, length)]))
-    else:
-        middle = width - length
-        return W_RopeObject(rope.concatenate(
-            rope.multiply(zero, middle), node))
-
-def hash__Rope(space, w_str):
-    return wrapint(space, rope.hash_rope(w_str._node))
-
-def lt__Rope_Rope(space, w_str1, w_str2):
-    n1 = w_str1._node
-    n2 = w_str2._node
-    return space.newbool(rope.compare(n1, n2) < 0)
-
-def le__Rope_Rope(space, w_str1, w_str2):
-    n1 = w_str1._node
-    n2 = w_str2._node
-    return space.newbool(rope.compare(n1, n2) <= 0)
-
-def _eq(w_str1, w_str2):
-    result = rope.eq(w_str1._node, w_str2._node)
-    return result
-
-def eq__Rope_Rope(space, w_str1, w_str2):
-    return space.newbool(_eq(w_str1, w_str2))
-
-def ne__Rope_Rope(space, w_str1, w_str2):
-    return space.newbool(not _eq(w_str1, w_str2))
-
-def gt__Rope_Rope(space, w_str1, w_str2):
-    n1 = w_str1._node
-    n2 = w_str2._node
-    return space.newbool(rope.compare(n1, n2) > 0)
-
-def ge__Rope_Rope(space, w_str1, w_str2):
-    n1 = w_str1._node
-    n2 = w_str2._node
-    return space.newbool(rope.compare(n1, n2) >= 0)
-
-def getitem__Rope_ANY(space, w_str, w_index):
-    ival = space.getindex_w(w_index, space.w_IndexError, "string index")
-    node = w_str._node
-    slen = node.length()
-    if ival < 0:
-        ival += slen
-    if ival < 0 or ival >= slen:
-        raise OperationError(space.w_IndexError,
-                             space.wrap("string index out of range"))
-    return wrapchar(space, node.getchar(ival))
-
-def getitem__Rope_Slice(space, w_str, w_slice):
-    node = w_str._node
-    length = node.length()
-    start, stop, step, sl = w_slice.indices4(space, length)
-    if sl == 0:
-        return W_RopeObject.EMPTY
-    return W_RopeObject(rope.getslice(node, start, stop, step, sl))
-
-def getslice__Rope_ANY_ANY(space, w_str, w_start, w_stop):
-    node = w_str._node
-    length = node.length()
-    start, stop = normalize_simple_slice(space, length, w_start, w_stop)
-    sl = stop - start
-    if sl == 0:
-        return W_RopeObject.EMPTY
-    return W_RopeObject(rope.getslice(node, start, stop, 1, sl))
-
-def mul_string_times(space, w_str, w_times):
-    try:
-        mul = space.getindex_w(w_times, space.w_OverflowError)
-    except OperationError, e:
-        if e.match(space, space.w_TypeError):
-            raise FailedToImplement
-        raise
-    if mul <= 0:
-        return W_RopeObject.EMPTY
-    node = w_str._node
-    try:
-        return W_RopeObject(rope.multiply(node, mul))
-    except OverflowError:
-        raise OperationError(space.w_OverflowError,
-                             space.wrap("string too long"))
-
-def mul__Rope_ANY(space, w_str, w_times):
-    return mul_string_times(space, w_str, w_times)
-
-def mul__ANY_Rope(space, w_times, w_str):
-    return mul_string_times(space, w_str, w_times)
-
-def add__Rope_Rope(space, w_left, w_right):
-    right = w_right._node
-    left = w_left._node
-    try:
-        return W_RopeObject(rope.concatenate(left, right))
-    except OverflowError:
-        raise OperationError(space.w_OverflowError,
-                             space.wrap("string too long"))
-
-def len__Rope(space, w_str):
-    return space.wrap(w_str._node.length())
-
-def str__Rope(space, w_str):
-    if type(w_str) is W_RopeObject:
-        return w_str
-    return W_RopeObject(w_str._node)
-
-def iter__Rope(space, w_str):
-    return W_RopeIterObject(w_str)
-
-def ord__Rope(space, w_str):
-    node = w_str._node
-    if node.length() != 1:
-        raise operationerrfmt(
-            space.w_TypeError,
-            "ord() expected a character, but string "
-            "of length %d found", node.length())
-    return space.wrap(node.getint(0))
-
-def getnewargs__Rope(space, w_str):
-    return space.newtuple([W_RopeObject(w_str._node)])
-
-def repr__Rope(space, w_str):
-    node = w_str._node
-    length = node.length()
-
-    i = 0
-    buf = [' '] * (length * 4 + 2) # safely overallocate
-
-    quote = "'"
-    if (rope.find_int(node, ord(quote)) != -1 and
-        rope.find_int(node, ord('"')) == -1):
-        quote = '"'
-
-    buf[0] = quote
-
-    iter = rope.ItemIterator(node)
-    while 1:
-        try:
-            c = iter.nextchar()
-            i += 1
-        except StopIteration:
-            break
-        bs_char = None # character quoted by backspace
-
-        if c == '\\' or c == quote:
-            bs_char = c
-        elif c == '\t': bs_char = 't'
-        elif c == '\r': bs_char = 'r'
-        elif c == '\n': bs_char = 'n'
-        elif not '\x20' <= c < '\x7f':
-            n = ord(c)
-            buf[i] = '\\'
-            i += 1
-            buf[i] = 'x'
-            i += 1
-            buf[i] = "0123456789abcdef"[n>>4]
-            i += 1
-            buf[i] = "0123456789abcdef"[n&0xF]
-        else:
-            buf[i] = c
-
-        if bs_char is not None:
-            buf[i] = '\\'
-            i += 1
-            buf[i] = bs_char
-
-    i += 1
-    buf[i] = quote
-
-    return W_RopeObject(rope.rope_from_charlist(buf[:i+1]))
-
-def str_translate__Rope_ANY_ANY(space, w_string, w_table, w_deletechars=''):
-    """charfilter - unicode handling is not implemented
-
-    Return a copy of the string where all characters occurring
-    in the optional argument deletechars are removed, and the
-    remaining characters have been mapped through the given translation table,
-    which must be a string of length 256"""
-
-    if space.is_w(w_table, space.w_None):
-        table = DEFAULT_NOOP_TABLE
-    else:
-        table = space.bufferstr_w(w_table)
-        if len(table) != 256:
-            raise OperationError(
-                space.w_ValueError,
-                space.wrap("translation table must be 256 characters long"))
-
-    node = w_string._node
-    chars = []
-    iter = rope.ItemIterator(node)
-    while 1:
-        try:
-            c = iter.nextchar()
-            w_char = W_RopeObject.PREBUILT[ord(c)]
-            if not space.is_true(space.contains(w_deletechars, w_char)):
-                 chars.append(table[ord(c)])
-        except StopIteration:
-            break
-    return W_RopeObject(rope.rope_from_charlist(chars))
-
-def str_decode__Rope_ANY_ANY(space, w_string, w_encoding=None, w_errors=None):
-    from pypy.objspace.std.unicodetype import _get_encoding_and_errors, \
-        getdefaultencoding
-    if space.config.objspace.std.withropeunicode:
-        from pypy.objspace.std.ropeunicodeobject import decode_string
-    else:
-        from pypy.objspace.std.unicodetype import decode_object as decode_string
-    encoding, errors = _get_encoding_and_errors(space, w_encoding, w_errors)
-    if encoding is None:
-        encoding = getdefaultencoding(space)
-    return decode_string(space, w_string, encoding, errors)
-
-def str_encode__Rope_ANY_ANY(space, w_string, w_encoding=None, w_errors=None):
-    from pypy.objspace.std.unicodetype import _get_encoding_and_errors, \
-        encode_object
-    encoding, errors = _get_encoding_and_errors(space, w_encoding, w_errors)
-    return encode_object(space, w_string, encoding, errors)
-
-def buffer__Rope(space, w_string):
-    from pypy.interpreter.buffer import StringBuffer
-    value = w_string._node.flatten_string()      # XXX inefficient
-    return space.wrap(StringBuffer(value))
-
-
-# methods of the iterator
-
-def iter__RopeIter(space, w_ropeiter):
-    return w_ropeiter
-
-def next__RopeIter(space, w_ropeiter):
-    if w_ropeiter.node is None:
-        raise OperationError(space.w_StopIteration, space.w_None)
-    try:
-        char = w_ropeiter.item_iter.nextchar()
-        w_item = wrapchar(space, char)
-    except StopIteration:
-        w_ropeiter.node = None
-        w_ropeiter.char_iter = None
-        raise OperationError(space.w_StopIteration, space.w_None)
-    w_ropeiter.index += 1
-    return w_item
-
-# XXX __length_hint__()
-##def len__RopeIter(space,  w_ropeiter):
-##    if w_ropeiter.node is None:
-##        return wrapint(space, 0)
-##    index = w_ropeiter.index
-##    length = w_ropeiter.node.length()
-##    result = length - index
-##    if result < 0:
-##        return wrapint(space, 0)
-##    return wrapint(space, result)
-
-# register all methods
-from pypy.objspace.std import stringtype
-register_all(vars(), stringtype)
diff --git a/pypy/objspace/std/ropeunicodeobject.py b/pypy/objspace/std/ropeunicodeobject.py
deleted file mode 100644
--- a/pypy/objspace/std/ropeunicodeobject.py
+++ /dev/null
@@ -1,1038 +0,0 @@
-from pypy.objspace.std.model import registerimplementation, W_Object
-from pypy.objspace.std.register_all import register_all
-from pypy.objspace.std.multimethod import FailedToImplement
-from pypy.interpreter.error import OperationError, operationerrfmt
-from pypy.interpreter import gateway
-from pypy.objspace.std.stringobject import W_StringObject
-from pypy.objspace.std.unicodeobject import _normalize_index
-from pypy.objspace.std.ropeobject import W_RopeObject
-from pypy.objspace.std.noneobject import W_NoneObject
-from pypy.rlib import rope
-from pypy.rlib.rstring import StringBuilder
-from pypy.objspace.std.sliceobject import W_SliceObject, normalize_simple_slice
-from pypy.objspace.std import unicodeobject, slicetype, iterobject
-from pypy.objspace.std.tupleobject import W_TupleObject
-from pypy.rlib.rarithmetic import intmask, ovfcheck
-from pypy.module.unicodedata import unicodedb
-from pypy.tool.sourcetools import func_with_new_name
-
-from pypy.objspace.std.formatting import mod_format
-
-from pypy.objspace.std.unicodeobject import (
-    format__Unicode_ANY as format__RopeUnicode_ANY)
-
-
-def wrapunicode(space, uni):
-    return W_RopeUnicodeObject(rope.rope_from_unicode(uni))
-
-def unicode_from_string(space, w_str):
-    from pypy.objspace.std.unicodetype import getdefaultencoding
-    assert isinstance(w_str, W_RopeObject)
-    encoding = getdefaultencoding(space)
-    w_retval = decode_string(space, w_str, encoding, "strict")
-    if not space.isinstance_w(w_retval, space.w_unicode):
-        raise operationerrfmt(
-            space.w_TypeError,
-            "decoder did not return an unicode object (type '%s')",
-            space.type(w_retval).getname(space))
-    assert isinstance(w_retval, W_RopeUnicodeObject)
-    return w_retval
-
-def decode_string(space, w_str, encoding, errors):
-    from pypy.objspace.std.unicodetype import decode_object
-    if errors is None or errors == "strict":
-        node = w_str._node
-        if encoding == 'ascii':
-            result = rope.str_decode_ascii(node)
-            if result is not None:
-                return W_RopeUnicodeObject(result)
-        elif encoding == 'latin-1':
-            assert node.is_bytestring()
-            return W_RopeUnicodeObject(node)
-        elif encoding == "utf-8":
-            result = rope.str_decode_utf8(node)
-            if result is not None:
-                return W_RopeUnicodeObject(result)
-    w_result = decode_object(space, w_str, encoding, errors)
-    return w_result
-
-def encode_unicode(space, w_unistr, encoding, errors):
-    from pypy.objspace.std.unicodetype import getdefaultencoding, \
-        _get_encoding_and_errors, encode_object
-    from pypy.objspace.std.ropeobject import W_RopeObject
-    if errors is None or errors == "strict":
-        node = w_unistr._node
-        if encoding == 'ascii':
-            result = rope.unicode_encode_ascii(node)
-            if result is not None:
-                return W_RopeObject(result)
-        elif encoding == 'latin-1':
-            result = rope.unicode_encode_latin1(node)
-            if result is not None:
-                return W_RopeObject(result)
-        elif encoding == "utf-8":
-            result = rope.unicode_encode_utf8(node, allow_surrogates=True)
-            if result is not None:
-                return W_RopeObject(result)
-    return encode_object(space, w_unistr, encoding, errors)
-
-
-class W_RopeUnicodeObject(unicodeobject.W_AbstractUnicodeObject):
-    from pypy.objspace.std.unicodetype import unicode_typedef as typedef
-    _immutable_fields_ = ['_node']
-
-    def __init__(w_self, node):
-        w_self._node = node
-
-    def __repr__(w_self):
-        """ representation for debugging purposes """
-        return "%s(%r)" % (w_self.__class__.__name__, w_self._node)
-
-    def unwrap(w_self, space):
-        # for testing
-        return w_self._node.flatten_unicode()
-
-    def str_w(w_self, space):
-        return space.str_w(space.str(w_self))
-
-    def create_if_subclassed(w_self):
-        if type(w_self) is W_RopeUnicodeObject:
-            return w_self
-        return W_RopeUnicodeObject(w_self._node)
-
-    def unicode_w(self, space):
-        return self._node.flatten_unicode()
-
-W_RopeUnicodeObject.EMPTY = W_RopeUnicodeObject(rope.LiteralStringNode.EMPTY)
-
-registerimplementation(W_RopeUnicodeObject)
-
-def _isspace(uchar_ord):
-    return unicodedb.isspace(uchar_ord)
-
-def ropeunicode_w(space, w_str):
-    if isinstance(w_str, W_RopeUnicodeObject):
-        return w_str._node
-    if isinstance(w_str, W_RopeObject):
-        return unicode_from_string(space, w_str)._node
-    return rope.LiteralUnicodeNode(space.unicode_w(w_str))
-
-
-class W_RopeUnicodeIterObject(iterobject.W_AbstractIterObject):
-    from pypy.objspace.std.itertype import iter_typedef as typedef
-
-    def __init__(w_self, w_rope, index=0):
-        w_self.node = node = w_rope._node
-        w_self.item_iter = rope.ItemIterator(node)
-        w_self.index = index
-
-def iter__RopeUnicode(space, w_uni):
-    return W_RopeUnicodeIterObject(w_uni)
-
-# Helper for converting int/long
-def unicode_to_decimal_w(space, w_unistr):
-    if not isinstance(w_unistr, W_RopeUnicodeObject):
-        raise OperationError(space.w_TypeError,
-                             space.wrap("expected unicode"))
-    unistr = w_unistr._node
-    length = unistr.length()
-    result = ['\0'] * length
-    digits = [ '0', '1', '2', '3', '4',
-               '5', '6', '7', '8', '9']
-    iter = rope.ItemIterator(unistr)
-    for i in range(length):
-        uchr = iter.nextint()
-        if unicodedb.isspace(uchr):
-            result[i] = ' '
-            continue
-        try:
-            result[i] = digits[unicodedb.decimal(uchr)]
-        except KeyError:
-            if 0 < uchr < 256:
-                result[i] = chr(uchr)
-            else:
-                w_encoding = space.wrap('decimal')
-                w_start = space.wrap(i)
-                w_end = space.wrap(i+1)
-                w_reason = space.wrap('invalid decimal Unicode string')
-                raise OperationError(space.w_UnicodeEncodeError, space.newtuple([w_encoding, w_unistr, w_start, w_end, w_reason]))
-    return ''.join(result)
-
-# string-to-unicode delegation
-def delegate_Rope2RopeUnicode(space, w_rope):
-    w_uni = unicode_from_string(space, w_rope)
-    assert isinstance(w_uni, W_RopeUnicodeObject) # help the annotator!
-    return w_uni
-
-def str__RopeUnicode(space, w_uni):
-    return space.call_method(w_uni, 'encode')
-
-def lt__RopeUnicode_RopeUnicode(space, w_str1, w_str2):
-    n1 = w_str1._node
-    n2 = w_str2._node
-    return space.newbool(rope.compare(n1, n2) < 0)
-
-def le__RopeUnicode_RopeUnicode(space, w_str1, w_str2):
-    n1 = w_str1._node
-    n2 = w_str2._node
-    return space.newbool(rope.compare(n1, n2) <= 0)
-
-def _eq(w_str1, w_str2):
-    result = rope.eq(w_str1._node, w_str2._node)
-    return result
-
-def eq__RopeUnicode_RopeUnicode(space, w_str1, w_str2):
-    return space.newbool(_eq(w_str1, w_str2))
-
-def eq__RopeUnicode_Rope(space, w_runi, w_rope):
-    from pypy.objspace.std.unicodeobject import _unicode_string_comparison
-    return _unicode_string_comparison(space, w_runi, w_rope,
-                    False,  unicode_from_string)
-
-def ne__RopeUnicode_RopeUnicode(space, w_str1, w_str2):
-    return space.newbool(not _eq(w_str1, w_str2))
-
-def ne__RopeUnicode_Rope(space, w_runi, w_rope):
-    from pypy.objspace.std.unicodeobject import _unicode_string_comparison
-    return _unicode_string_comparison(space, w_runi, w_rope,
-                    True, unicode_from_string)
-
-def gt__RopeUnicode_RopeUnicode(space, w_str1, w_str2):
-    n1 = w_str1._node
-    n2 = w_str2._node
-    return space.newbool(rope.compare(n1, n2) > 0)
-
-def ge__RopeUnicode_RopeUnicode(space, w_str1, w_str2):
-    n1 = w_str1._node
-    n2 = w_str2._node
-    return space.newbool(rope.compare(n1, n2) >= 0)
-
-
-def ord__RopeUnicode(space, w_uni):
-    if w_uni._node.length() != 1:
-        raise OperationError(space.w_TypeError, space.wrap('ord() expected a character'))
-    return space.wrap(w_uni._node.getint(0))
-
-def getnewargs__RopeUnicode(space, w_uni):
-    return space.newtuple([W_RopeUnicodeObject(w_uni._node)])
-
-def add__RopeUnicode_RopeUnicode(space, w_left, w_right):
-    right = w_right._node
-    left = w_left._node
-    try:
-        return W_RopeUnicodeObject(rope.concatenate(left, right))
-    except OverflowError:
-        raise OperationError(space.w_OverflowError,
-                             space.wrap("string too long"))
-
-def add__Rope_RopeUnicode(space, w_left, w_right):
-    return space.add(unicode_from_string(space, w_left) , w_right)
-
-def add__RopeUnicode_Rope(space, w_left, w_right):
-    return space.add(w_left, unicode_from_string(space, w_right))
-
-def contains__RopeUnicode_RopeUnicode(space, w_container, w_item):
-    item = w_item._node
-    container = w_container._node
-    return space.newbool(rope.find(container, item) != -1)
-
-def contains__Rope_RopeUnicode(space, w_container, w_item):
-    return space.contains(unicode_from_string(space, w_container), w_item )
-
-def unicode_join__RopeUnicode_ANY(space, w_self, w_list):
-    l_w = space.listview(w_list)
-    delim = w_self._node
-    totlen = 0
-    if len(l_w) == 0:
-        return W_RopeUnicodeObject.EMPTY
-    if (len(l_w) == 1 and
-        space.is_w(space.type(l_w[0]), space.w_unicode)):
-        return l_w[0]
-
-    values_list = []
-    for i in range(len(l_w)):
-        w_item = l_w[i]
-        if isinstance(w_item, W_RopeUnicodeObject):
-            # shortcut for performane
-            item = w_item._node
-        elif space.isinstance_w(w_item, space.w_str):
-            item = unicode_from_string(space, w_item)._node
-        else:
-            msg = 'sequence item %d: expected string or Unicode'
-            raise operationerrfmt(space.w_TypeError, msg, i)
-        values_list.append(item)
-    try:
-        return W_RopeUnicodeObject(rope.join(w_self._node, values_list))
-    except OverflowError:
-        raise OperationError(space.w_OverflowError,
-                             space.wrap("string too long"))
-
-def hash__RopeUnicode(space, w_uni):
-    return space.wrap(rope.hash_rope(w_uni._node))
-
-def len__RopeUnicode(space, w_uni):
-    return space.wrap(w_uni._node.length())
-
-def getitem__RopeUnicode_ANY(space, w_uni, w_index):
-    ival = space.getindex_w(w_index, space.w_IndexError, "string index")
-    uni = w_uni._node
-    ulen = uni.length()
-    if ival < 0:
-        ival += ulen
-    if ival < 0 or ival >= ulen:
-        exc = space.call_function(space.w_IndexError,
-                                  space.wrap("unicode index out of range"))
-        raise OperationError(space.w_IndexError, exc)
-    return W_RopeUnicodeObject(uni.getrope(ival))
-
-def getitem__RopeUnicode_Slice(space, w_uni, w_slice):
-    node = w_uni._node
-    length = node.length()
-    start, stop, step, sl = w_slice.indices4(space, length)
-    if sl == 0:
-        return W_RopeUnicodeObject.EMPTY
-    return W_RopeUnicodeObject(rope.getslice(node, start, stop, step, sl))
-
-def getslice__RopeUnicode_ANY_ANY(space, w_uni, w_start, w_stop):
-    node = w_uni._node
-    length = node.length()
-    start, stop = normalize_simple_slice(space, length, w_start, w_stop)
-    sl = stop - start
-    if sl == 0:
-        return W_RopeUnicodeObject.EMPTY
-    return W_RopeUnicodeObject(rope.getslice(node, start, stop, 1, sl))
-
-def mul__RopeUnicode_ANY(space, w_uni, w_times):
-    try:
-        times = space.getindex_w(w_times, space.w_OverflowError)
-    except OperationError, e:
-        if e.match(space, space.w_TypeError):
-            raise FailedToImplement
-        raise
-    node = w_uni._node
-    try:
-        return W_RopeUnicodeObject(rope.multiply(node, times))
-    except OverflowError:
-        raise OperationError(space.w_OverflowError,
-                             space.wrap("string too long"))
-
-def mul__ANY_RopeUnicode(space, w_times, w_uni):
-    return mul__RopeUnicode_ANY(space, w_uni, w_times)
-
-
-def make_generic(funcname):
-    def func(space, w_self):
-        node = w_self._node
-        if node.length() == 0:
-            return space.w_False
-        iter = rope.ItemIterator(node)
-        for idx in range(node.length()):
-            if not getattr(unicodedb, funcname)(iter.nextint()):
-                return space.w_False
-        return space.w_True
-    return func_with_new_name(func, "unicode_%s__RopeUnicode" % (funcname, ))
-
-unicode_isspace__RopeUnicode = make_generic("isspace")
-unicode_isalpha__RopeUnicode = make_generic("isalpha")
-unicode_isalnum__RopeUnicode = make_generic("isalnum")
-unicode_isdecimal__RopeUnicode = make_generic("isdecimal")
-unicode_isdigit__RopeUnicode = make_generic("isdigit")
-unicode_isnumeric__RopeUnicode = make_generic("isnumeric")
-
-def unicode_islower__RopeUnicode(space, w_unicode):
-    cased = False
-    iter = rope.ItemIterator(w_unicode._node)
-    while 1:
-        try:
-            ch = iter.nextint()
-        except StopIteration:
-            return space.newbool(cased)
-        if (unicodedb.isupper(ch) or
-            unicodedb.istitle(ch)):
-            return space.w_False
-        if not cased and unicodedb.islower(ch):
-            cased = True
-
-def unicode_isupper__RopeUnicode(space, w_unicode):
-    cased = False
-    iter = rope.ItemIterator(w_unicode._node)
-    while 1:
-        try:
-            ch = iter.nextint()
-        except StopIteration:
-            return space.newbool(cased)
-        if (unicodedb.islower(ch) or
-            unicodedb.istitle(ch)):
-            return space.w_False
-        if not cased and unicodedb.isupper(ch):
-            cased = True
-
-def unicode_istitle__RopeUnicode(space, w_unicode):
-    cased = False
-    previous_is_cased = False
-    iter = rope.ItemIterator(w_unicode._node)
-    while 1:
-        try:
-            ch = iter.nextint()
-        except StopIteration:
-            return space.newbool(cased)
-        if (unicodedb.isupper(ch) or
-            unicodedb.istitle(ch)):
-            if previous_is_cased:
-                return space.w_False
-            previous_is_cased = cased = True
-        elif unicodedb.islower(ch):
-            if not previous_is_cased:
-                return space.w_False
-            previous_is_cased = cased = True
-        else:
-            previous_is_cased = False
-
-
-def _contains(i, uni):
-    return unichr(i) in uni
-
-def unicode_strip__RopeUnicode_None(space, w_self, w_chars):
-    return W_RopeUnicodeObject(rope.strip(w_self._node, True, True, _isspace))
-def unicode_strip__RopeUnicode_RopeUnicode(space, w_self, w_chars):
-    return W_RopeUnicodeObject(rope.strip(w_self._node, True, True, _contains,
-                               w_chars._node.flatten_unicode()))
-
-def unicode_strip__RopeUnicode_Rope(space, w_self, w_chars):
-    return space.call_method(w_self, 'strip',
-                             unicode_from_string(space, w_chars))
-
-def unicode_lstrip__RopeUnicode_None(space, w_self, w_chars):
-    return W_RopeUnicodeObject(rope.strip(w_self._node, True, False, _isspace))
-def unicode_lstrip__RopeUnicode_RopeUnicode(space, w_self, w_chars):
-    return W_RopeUnicodeObject(rope.strip(w_self._node, True, False, _contains,
-                               w_chars._node.flatten_unicode()))
-def unicode_lstrip__RopeUnicode_Rope(space, w_self, w_chars):
-    return space.call_method(w_self, 'lstrip',
-                             unicode_from_string(space, w_chars))
-
-def unicode_rstrip__RopeUnicode_None(space, w_self, w_chars):
-    return W_RopeUnicodeObject(rope.strip(w_self._node, False, True, _isspace))
-def unicode_rstrip__RopeUnicode_RopeUnicode(space, w_self, w_chars):
-    return W_RopeUnicodeObject(rope.strip(w_self._node, False, True, _contains,
-                               w_chars._node.flatten_unicode()))
-def unicode_rstrip__RopeUnicode_Rope(space, w_self, w_chars):
-    return space.call_method(w_self, 'rstrip',
-                             unicode_from_string(space, w_chars))
-
-def unicode_capitalize__RopeUnicode(space, w_self):
-    input = w_self._node
-    length = input.length()
-    if length == 0:
-        return w_self
-    result = [u'\0'] * length
-    iter = rope.ItemIterator(input)
-    result[0] = unichr(unicodedb.toupper(iter.nextint()))
-    for i in range(1, length):
-        result[i] = unichr(unicodedb.tolower(iter.nextint()))
-    return W_RopeUnicodeObject(rope.rope_from_unicharlist(result))
-
-def unicode_title__RopeUnicode(space, w_self):
-    input = w_self._node
-    length = input.length()
-    if length == 0:
-        return w_self
-    result = [u'\0'] * length
-    iter = rope.ItemIterator(input)
-
-    previous_is_cased = False
-    for i in range(input.length()):
-        unichar = iter.nextint()
-        if previous_is_cased:
-            result[i] = unichr(unicodedb.tolower(unichar))
-        else:
-            result[i] = unichr(unicodedb.totitle(unichar))
-        previous_is_cased = unicodedb.iscased(unichar)
-    return W_RopeUnicodeObject(rope.rope_from_unicharlist(result))
-
-
-def _local_transform(node, transform):
-    l = node.length()
-    res = [u' '] * l
-    iter = rope.ItemIterator(node)
-    for i in range(l):
-        ch = iter.nextint()
-        res[i] = transform(ch)
-
-    return W_RopeUnicodeObject(rope.rope_from_unicharlist(res))
-_local_transform._annspecialcase_ = "specialize:arg(1)"
-
-def _tolower(ordch):
-    return unichr(unicodedb.tolower(ordch))
-def unicode_lower__RopeUnicode(space, w_self):
-    return _local_transform(w_self._node, _tolower)
-
-def _toupper(ordch):
-    return unichr(unicodedb.toupper(ordch))
-def unicode_upper__RopeUnicode(space, w_self):
-    return _local_transform(w_self._node, _toupper)
-
-def _swapcase(ordch):
-    if unicodedb.islower(ordch):
-        return unichr(unicodedb.toupper(ordch))
-    elif unicodedb.isupper(ordch):
-        return unichr(unicodedb.tolower(ordch))
-    else:
-        return unichr(ordch)
-
-def unicode_swapcase__RopeUnicode(space, w_self):
-    return _local_transform(w_self._node, _swapcase)
-
-def _convert_idx_params(space, w_self, w_start, w_end):
-    self = w_self._node
-    length = w_self._node.length()
-    if space.is_w(w_start, space.w_None):
-        w_start = space.wrap(0)
-    if space.is_w(w_end, space.w_None):
-        w_end = space.len(w_self)
-    start = slicetype.adapt_bound(space, length, w_start)
-    end = slicetype.adapt_bound(space, length, w_end)
-
-    assert start >= 0
-    assert end >= 0
-
-    return (self, start, end)
-
-def unicode_endswith__RopeUnicode_RopeUnicode_ANY_ANY(space, w_self, w_substr, w_start, w_end):
-    self, start, end = _convert_idx_params(space, w_self, w_start, w_end)
-    return space.newbool(rope.endswith(self, w_substr._node, start, end))
-
-def unicode_startswith__RopeUnicode_RopeUnicode_ANY_ANY(space, w_self, w_substr, w_start, w_end):
-    self, start, end = _convert_idx_params(space, w_self, w_start, w_end)
-    # XXX this stuff can be waaay better for ootypebased backends if
-    #     we re-use more of our rpython machinery (ie implement startswith
-    #     with additional parameters as rpython)
-
-    self, start, end = _convert_idx_params(space, w_self, w_start, w_end)
-    return space.newbool(rope.startswith(self, w_substr._node, start, end))
-
-def unicode_startswith__RopeUnicode_Tuple_ANY_ANY(space, w_unistr, w_prefixes,
-                                              w_start, w_end):
-    unistr, start, end = _convert_idx_params(space, w_unistr, w_start, w_end)
-    for w_prefix in space.fixedview(w_prefixes):
-        prefix = ropeunicode_w(space, w_prefix)
-        if rope.startswith(unistr, prefix, start, end):
-            return space.w_True
-    return space.w_False
-
-def unicode_endswith__RopeUnicode_Tuple_ANY_ANY(space, w_unistr, w_suffixes,
-                                            w_start, w_end):
-    unistr, start, end = _convert_idx_params(space, w_unistr, w_start, w_end)
-    for w_suffix in space.fixedview(w_suffixes):
-        suffix = ropeunicode_w(space, w_suffix)
-        if rope.endswith(unistr, suffix, start, end):
-            return space.w_True
-    return space.w_False
-
-
-def _to_unichar_w(space, w_char):
-    try:
-        unistr = ropeunicode_w(space, w_char)
-    except OperationError, e:
-        if e.match(space, space.w_TypeError):
-            msg = 'The fill character cannot be converted to Unicode'
-            raise OperationError(space.w_TypeError, space.wrap(msg))
-        else:
-            raise
-
-    if unistr.length() != 1:
-        raise OperationError(space.w_TypeError, space.wrap('The fill character must be exactly one character long'))
-    return unistr
-
-def unicode_center__RopeUnicode_ANY_ANY(space, w_self, w_width, w_fillchar):
-    self = w_self._node
-    length = self.length()
-    width = space.int_w(w_width)
-    fillchar = _to_unichar_w(space, w_fillchar)
-    padding = width - length
-    if padding < 0:
-        return w_self.create_if_subclassed()
-    offset = padding // 2
-    pre = rope.multiply(fillchar, offset)
-    post = rope.multiply(fillchar, (padding - offset))
-    centered = rope.rebalance([pre, self, post])
-    return W_RopeUnicodeObject(centered)
-
-def unicode_ljust__RopeUnicode_ANY_ANY(space, w_self, w_width, w_fillchar):
-    self = w_self._node
-    length = self.length()
-    width = space.int_w(w_width)
-    fillchar = _to_unichar_w(space, w_fillchar)
-    padding = width - length
-    if padding < 0:
-        return w_self.create_if_subclassed()
-    resultnode = rope.concatenate(self, rope.multiply(fillchar, padding))
-    return W_RopeUnicodeObject(resultnode)
-
-def unicode_rjust__RopeUnicode_ANY_ANY(space, w_self, w_width, w_fillchar):
-    self = w_self._node
-    length = self.length()
-    width = space.int_w(w_width)
-    fillchar = _to_unichar_w(space, w_fillchar)
-    padding = width - length
-    if padding < 0:
-        return w_self.create_if_subclassed()
-    resultnode = rope.concatenate(rope.multiply(fillchar, padding), self)
-    return W_RopeUnicodeObject(resultnode)
-
-def unicode_zfill__RopeUnicode_ANY(space, w_self, w_width):
-    self = w_self._node
-    length = self.length()
-    width = space.int_w(w_width)
-    zero = rope.LiteralStringNode.PREBUILT[ord("0")]
-    if self.length() == 0:
-        return W_RopeUnicodeObject(
-            rope.multiply(zero, width))
-    padding = width - length
-    if padding <= 0:
-        return w_self.create_if_subclassed()
-    firstchar = self.getunichar(0)
-    if firstchar in (u'+', u'-'):
-        return W_RopeUnicodeObject(rope.rebalance(
-            [rope.LiteralStringNode.PREBUILT[ord(firstchar)],
-             rope.multiply(zero, padding),
-             rope.getslice_one(self, 1, length)]))
-    else:
-        return W_RopeUnicodeObject(rope.concatenate(
-            rope.multiply(zero, padding), self))
-
-def unicode_splitlines__RopeUnicode_ANY(space, w_self, w_keepends):
-    keepends = bool(space.int_w(w_keepends))  # truth value, but type checked
-    node = w_self._node
-    return space.newlist(
-        [W_RopeUnicodeObject(n) for n in rope.splitlines(node, keepends)])
-
-def unicode_find__RopeUnicode_RopeUnicode_ANY_ANY(space, w_self, w_substr, w_start, w_end):
-    self, start, end = _convert_idx_params(space, w_self, w_start, w_end)
-    sub = w_substr._node
-    return space.wrap(rope.find(self, sub, start, end))
-
-def unicode_rfind__RopeUnicode_RopeUnicode_ANY_ANY(space, w_self, w_substr, w_start, w_end):
-    self, start, end = _convert_idx_params(space, w_self, w_start, w_end)
-    self = self.flatten_unicode()
-    sub = w_substr._node.flatten_unicode()
-    res = self.rfind(sub, start, end)
-    return space.wrap(res)
-
-def unicode_index__RopeUnicode_RopeUnicode_ANY_ANY(space, w_self, w_substr, w_start, w_end):
-    self, start, end = _convert_idx_params(space, w_self, w_start, w_end)
-    sub = w_substr._node
-    res = rope.find(self, sub, start, end)
-    if res < 0:
-        raise OperationError(space.w_ValueError,
-                             space.wrap("substring not found in string.index"))
-    return space.wrap(res)
-
-def unicode_rindex__RopeUnicode_RopeUnicode_ANY_ANY(space, w_self, w_substr, w_start, w_end):
-    # XXX works but flattens string
-    self, start, end = _convert_idx_params(space, w_self, w_start, w_end)
-    self = self.flatten_unicode()
-    sub = w_substr._node.flatten_unicode()
-    res = self.rfind(sub, start, end)
-    if res < 0:
-        raise OperationError(space.w_ValueError,
-                             space.wrap("substring not found in string.rindex"))
-
-    return space.wrap(res)
-
-def unicode_count__RopeUnicode_RopeUnicode_ANY_ANY(space, w_self, w_substr, w_start, w_end):
-    self, start, end = _convert_idx_params(space, w_self, w_start, w_end)
-    assert start >= 0
-    assert end >= 0
-    iter = rope.FindIterator(self, w_substr._node, start, end)
-    i = 0
-    while 1:
-        try:
-            index = iter.next()
-        except StopIteration:
-            break
-        i += 1
-    return space.wrap(i)
-
-def unicode_split__RopeUnicode_None_ANY(space, w_self, w_none, w_maxsplit):
-    selfnode = w_self._node
-    maxsplit = space.int_w(w_maxsplit)
-    res_w = [W_RopeUnicodeObject(node)
-                for node in rope.split_chars(selfnode, maxsplit, _isspace)]
-    return space.newlist(res_w)
-
-def unicode_split__RopeUnicode_RopeUnicode_ANY(space, w_self, w_delim, w_maxsplit):
-    maxsplit = space.int_w(w_maxsplit)
-    start = 0
-    selfnode = w_self._node
-    delimnode = w_delim._node
-    delimlen = delimnode.length()
-    if delimlen == 0:
-        raise OperationError(space.w_ValueError, space.wrap("empty separator"))
-    res_w = [W_RopeUnicodeObject(node)
-                for node in rope.split(selfnode, delimnode, maxsplit)]
-    return space.newlist(res_w)
-
-def unicode_rsplit__RopeUnicode_None_ANY(space, w_self, w_none, w_maxsplit):
-    selfnode = w_self._node
-    maxsplit = space.int_w(w_maxsplit)
-    res_w = [W_RopeUnicodeObject(node)
-                for node in rope.rsplit_chars(selfnode, maxsplit, _isspace)]
-    return space.newlist(res_w)
-
-
-def unicode_rsplit__RopeUnicode_RopeUnicode_ANY(space, w_self, w_delim, w_maxsplit):
-    # XXX works but flattens
-    self = w_self._node.flatten_unicode()
-    delim = w_delim._node.flatten_unicode()
-    maxsplit = space.int_w(w_maxsplit)
-    delim_len = len(delim)
-    if delim_len == 0:
-        raise OperationError(space.w_ValueError,
-                             space.wrap('empty separator'))
-    parts = []
-    if len(self) == 0:
-        return space.newlist([])
-    start = 0
-    end = len(self)
-    while maxsplit != 0:
-        index = self.rfind(delim, 0, end)
-        if index < 0:
-            break
-        parts.append(W_RopeUnicodeObject(
-            rope.getslice_one(w_self._node, index+delim_len, end)))
-        end = index
-        maxsplit -= 1
-    parts.append(W_RopeUnicodeObject(
-        rope.getslice_one(w_self._node, 0, end)))
-    parts.reverse()
-    return space.newlist(parts)
-
-def _split_into_chars(self, maxsplit):
-    if maxsplit == 0:
-        return [self]
-    index = 0
-    end = self.length()
-    parts = [rope.LiteralStringNode.EMPTY]
-    maxsplit -= 1
-    while maxsplit != 0:
-        if index >= end:
-            break
-        parts.append(self.getrope(index))
-        index += 1
-        maxsplit -= 1
-    parts.append(rope.getslice_one(self, index, self.length()))
-    return parts
-
-def unicode_replace__RopeUnicode_RopeUnicode_RopeUnicode_ANY(
-        space, w_self, w_old, w_new, w_maxsplit):
-    self = w_self._node
-    old = w_old._node
-    maxsplit = space.int_w(w_maxsplit)
-    oldlength = old.length()
-    if not oldlength:
-        parts = _split_into_chars(self, maxsplit)
-        try:
-            return W_RopeUnicodeObject(rope.join(w_new._node, parts))
-        except OverflowError:
-            raise OperationError(space.w_OverflowError,
-                                 space.wrap("string too long"))
-    substrings = rope.split(self, old, maxsplit)
-    if not substrings:
-        return w_self.create_if_subclassed()
-    try:
-        return W_RopeUnicodeObject(rope.join(w_new._node, substrings))
-    except OverflowError:
-        raise OperationError(space.w_OverflowError,
-                             space.wrap("string too long"))
-
-
-def unicode_encode__RopeUnicode_ANY_ANY(space, w_unistr,
-                                        w_encoding=None,
-                                        w_errors=None):
-
-    from pypy.objspace.std.unicodetype import getdefaultencoding, \
-        _get_encoding_and_errors
-    encoding, errors = _get_encoding_and_errors(space, w_encoding, w_errors)
-    if encoding is None:
-        encoding = getdefaultencoding(space)
-    return encode_unicode(space, w_unistr, encoding, errors)
-
-def unicode_partition__RopeUnicode_RopeUnicode(space, w_unistr, w_unisub):
-    self = w_unistr._node
-    sub = w_unisub._node
-    if not sub.length():
-        raise OperationError(space.w_ValueError,
-                             space.wrap("empty separator"))
-    pos = rope.find(self, sub)
-    if pos == -1:
-        return space.newtuple([w_unistr, W_RopeUnicodeObject.EMPTY,
-                               W_RopeUnicodeObject.EMPTY])
-    else:
-        return space.newtuple(
-            [W_RopeUnicodeObject(rope.getslice_one(self, 0, pos)),
-             w_unisub,
-             W_RopeUnicodeObject(rope.getslice_one(self, pos + sub.length(),
-                                            self.length()))])
-
-def unicode_rpartition__RopeUnicode_RopeUnicode(space, w_unistr, w_unisub):
-    # XXX works but flattens
-    unistr = w_unistr._node.flatten_unicode()
-    unisub = w_unisub._node.flatten_unicode()
-    if not unisub:
-        raise OperationError(space.w_ValueError,
-                             space.wrap("empty separator"))
-    pos = unistr.rfind(unisub)
-    if pos == -1:
-        return space.newtuple([W_RopeUnicodeObject.EMPTY,
-                               W_RopeUnicodeObject.EMPTY, w_unistr])
-    else:
-        assert pos >= 0
-        return space.newtuple([space.wrap(unistr[:pos]), w_unisub,
-                               space.wrap(unistr[pos+len(unisub):])])
-
-
-def unicode_expandtabs__RopeUnicode_ANY(space, w_self, w_tabsize):
-    from pypy.objspace.std.ropeobject import _tabindent
-    self = w_self._node
-    tabsize  = space.int_w(w_tabsize)
-    splitted = rope.split(self, rope.LiteralStringNode.PREBUILT[ord('\t')])
-    last = splitted[0]
-    expanded = [last]
-    for i in range(1, len(splitted)):


More information about the pypy-commit mailing list