[pypy-commit] pypy stm-gc: Comment.

arigo noreply at buildbot.pypy.org
Fri Apr 27 10:28:06 CEST 2012


Author: Armin Rigo <arigo at tunes.org>
Branch: stm-gc
Changeset: r54771:84017bfb4a89
Date: 2012-04-27 10:27 +0200
http://bitbucket.org/pypy/pypy/changeset/84017bfb4a89/

Log:	Comment.

diff --git a/pypy/translator/stm/src_stm/lists.c b/pypy/translator/stm/src_stm/lists.c
--- a/pypy/translator/stm/src_stm/lists.c
+++ b/pypy/translator/stm/src_stm/lists.c
@@ -232,7 +232,12 @@
 {
   /* XXX it would be a good idea to try to compactify the list,
      by removing duplicate entries.  We are only interested in
-     the set of entries present, and the order doesn't matter. */
+     the set of entries present, and the order doesn't matter.
+     See for example if, in practice, there are many consecutive
+     duplicate entries; if so, add a check here.  Otherwise, or
+     in addition, we need a general de-duplicator logic called
+     at every local_collection().
+  */
   if (oreclist->size == oreclist->alloc)
     _oreclist_grow(oreclist);
   oreclist->items[oreclist->size++] = newitem;


More information about the pypy-commit mailing list