[pypy-commit] pypy string-promote-2: explain XXX

fijal noreply at buildbot.pypy.org
Wed Oct 12 00:33:17 CEST 2011


Author: Maciej Fijalkowski <fijall at gmail.com>
Branch: string-promote-2
Changeset: r47956:9b85dbd68f25
Date: 2011-10-12 00:33 +0200
http://bitbucket.org/pypy/pypy/changeset/9b85dbd68f25/

Log:	explain XXX

diff --git a/pypy/jit/codewriter/jtransform.py b/pypy/jit/codewriter/jtransform.py
--- a/pypy/jit/codewriter/jtransform.py
+++ b/pypy/jit/codewriter/jtransform.py
@@ -466,7 +466,8 @@
                                         EffectInfo.EF_ELIDABLE_CANNOT_RAISE)
             descr, p = self.callcontrol.callinfocollection.callinfo_for_oopspec(
                 EffectInfo.OS_STREQ_NONNULL)
-            # XXX
+            # XXX this is fairly ugly way of creating a constant,
+            #     however, callinfocollection has no better interface
             c = Constant(p.adr.ptr, lltype.typeOf(p.adr.ptr))
             op1 = SpaceOperation('str_guard_value', [op.args[0], c, descr],
                                  op.result)


More information about the pypy-commit mailing list