[pypy-commit] pypy default: Actually, it seems that the new code replaces any need for the old

[arigo]

Author: Armin Rigo <arigo at tunes.org>
Branch: 
Changeset: r49997:46119931a154
Date: 2011-11-30 03:15 +0100
http://bitbucket.org/pypy/pypy/changeset/46119931a154/

Log:	Actually, it seems that the new code replaces any need for the old
	code. Good, I can remove the comment in rffi.py too...

diff --git a/pypy/jit/codewriter/effectinfo.py b/pypy/jit/codewriter/effectinfo.py
--- a/pypy/jit/codewriter/effectinfo.py
+++ b/pypy/jit/codewriter/effectinfo.py
@@ -241,15 +241,6 @@
         return op.opname == 'jit_force_quasi_immutable'
 
 class RandomEffectsAnalyzer(BoolGraphAnalyzer):
-    def analyze_direct_call(self, graph, seen=None):
-        if hasattr(graph, "func") and hasattr(graph.func, "_ptr"):
-            # the attribute _ptr is stored on the function 'graph.func'
-            # by rffi.llexternal().  It's a hack...
-            if graph.func._ptr._obj.random_effects_on_gcobjs:
-                return True
-        return super(RandomEffectsAnalyzer, self).analyze_direct_call(graph,
-                                                                      seen)
-
     def analyze_external_call(self, op, seen=None):
         try:
             funcobj = op.args[0].value._obj
diff --git a/pypy/rpython/lltypesystem/rffi.py b/pypy/rpython/lltypesystem/rffi.py
--- a/pypy/rpython/lltypesystem/rffi.py
+++ b/pypy/rpython/lltypesystem/rffi.py
@@ -245,7 +245,6 @@
     wrapper._annspecialcase_ = 'specialize:ll'
     wrapper._always_inline_ = True
     # for debugging, stick ll func ptr to that
-    # (nowadays used in a not-for-debugging way by jit/codewriter/effectinfo)
     wrapper._ptr = funcptr
     wrapper = func_with_new_name(wrapper, name)